* [meta-oe][PATCH 1/2] lmbench: use base_libdir instead of hardcoded /lib
@ 2014-01-14 9:10 b28495
2014-01-14 9:10 ` [meta-oe][PATCH 2/2] inetutils: not hard coded libreadline path b28495
0 siblings, 1 reply; 5+ messages in thread
From: b28495 @ 2014-01-14 9:10 UTC (permalink / raw)
To: openembedded-devel
From: Ting Liu <b28495@freescale.com>
Fix the below QA warning when building 64bit target:
| WARNING: QA Issue: lmbench: Files/directories were installed but not
| shipped
| /usr/lib
| /usr/lib/libmbench.a
Signed-off-by: Ting Liu <b28495@freescale.com>
---
.../use-base_libdir-instead-of-hardcoded-lib.patch | 32 ++++++++++++++++++++
.../recipes-benchmark/lmbench/lmbench_3.0-a9.bb | 1 +
2 files changed, 33 insertions(+), 0 deletions(-)
create mode 100644 meta-oe/recipes-benchmark/lmbench/lmbench-3.0-a9/use-base_libdir-instead-of-hardcoded-lib.patch
diff --git a/meta-oe/recipes-benchmark/lmbench/lmbench-3.0-a9/use-base_libdir-instead-of-hardcoded-lib.patch b/meta-oe/recipes-benchmark/lmbench/lmbench-3.0-a9/use-base_libdir-instead-of-hardcoded-lib.patch
new file mode 100644
index 0000000..3351ce8
--- /dev/null
+++ b/meta-oe/recipes-benchmark/lmbench/lmbench-3.0-a9/use-base_libdir-instead-of-hardcoded-lib.patch
@@ -0,0 +1,32 @@
+From 0d09e31970616e09beb7f238c2b59bfc541148fb Mon Sep 17 00:00:00 2001
+From: Ting Liu <b28495@freescale.com>
+Date: Fri, 22 Nov 2013 15:20:08 +0800
+Subject: [PATCH] use base_libdir instead of hardcoded /lib
+
+Upsteam Status: Inappropriate [configuration]
+
+Signed-off-by: Ting Liu <b28495@freescale.com>
+---
+ src/Makefile | 4 ++--
+ 1 files changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/src/Makefile b/src/Makefile
+index c7a8c79..c7e4e3c 100644
+--- a/src/Makefile
++++ b/src/Makefile
+@@ -143,10 +143,10 @@ install-target:
+ if [ ! -d $(BASE) ]; then mkdir $(BASE); fi
+ if [ ! -d $(BASE)/bin ]; then mkdir $(BASE)/bin; fi
+ if [ ! -d $(BASE)/include ]; then mkdir $(BASE)/include; fi
+- if [ ! -d $(BASE)/lib ]; then mkdir $(BASE)/lib; fi
++ if [ ! -d $(BASE)$(base_libdir) ]; then mkdir $(BASE)$(base_libdir); fi
+ cp $(EXES) $(BASE)/bin
+ cp $(INCS) $(BASE)/include
+- cp $O/lmbench.a $(BASE)/lib/libmbench.a
++ cp $O/lmbench.a $(BASE)$(base_libdir)
+ cd ../doc; env MAKEFLAGS="$(MAKEFLAGS)" make CC="${CC}" OS="${OS}" BASE="$(BASE)" install
+
+
+--
+1.7.5.4
+
diff --git a/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb b/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb
index b4020d7..eb38f07 100644
--- a/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb
+++ b/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb
@@ -15,6 +15,7 @@ SRC_URI = "${SOURCEFORGE_MIRROR}/lmbench/lmbench-${PV}.tgz \
file://update-results-script.patch \
file://obey-ranlib.patch \
file://update-config-script.patch \
+ file://use-base_libdir-instead-of-hardcoded-lib.patch \
"
SRC_URI[md5sum] = "b3351a3294db66a72e2864a199d37cbf"
SRC_URI[sha256sum] = "cbd5777d15f44eab7666dcac418054c3c09df99826961a397d9acf43d8a2a551"
--
1.7.3.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [meta-oe][PATCH 2/2] inetutils: not hard coded libreadline path
2014-01-14 9:10 [meta-oe][PATCH 1/2] lmbench: use base_libdir instead of hardcoded /lib b28495
@ 2014-01-14 9:10 ` b28495
2014-01-14 9:21 ` Martin Jansa
0 siblings, 1 reply; 5+ messages in thread
From: b28495 @ 2014-01-14 9:10 UTC (permalink / raw)
To: openembedded-devel
From: Ting Liu <b28495@freescale.com>
Avoid below QA issues:
| ERROR: QA Issue: package inetutils-ftp contains bad RPATH
| ERROR: QA Issue: package inetutils-telnet contains bad RPATH
| ERROR: QA Issue: package inetutils-telnetd contains bad RPATH
| ERROR: QA run found fatal errors. Please consider fixing them.
| ERROR: Function failed: do_package_qa
Signed-off-by: Ting Liu <b28495@freescale.com>
---
.../inetutils/inetutils_1.9.1.bb | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb b/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb
index 97fc6a1..03b8e65 100644
--- a/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb
+++ b/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb
@@ -37,7 +37,6 @@ PACKAGECONFIG[uucpd] = "--enable-uucpd,--disable-uucpd,readline"
EXTRA_OECONF = "--with-ncurses-include-dir=${STAGING_INCDIR} \
${noipv6} \
- --with-libreadline-prefix=${STAGING_DIR_HOST}${prefix} \
"
do_configure_prepend () {
--
1.7.3.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [meta-oe][PATCH 2/2] inetutils: not hard coded libreadline path
2014-01-14 9:10 ` [meta-oe][PATCH 2/2] inetutils: not hard coded libreadline path b28495
@ 2014-01-14 9:21 ` Martin Jansa
[not found] ` <d6d29dfe2a204196a850afc04467a23d@BN1PR03MB156.namprd03.prod.outlook.com>
0 siblings, 1 reply; 5+ messages in thread
From: Martin Jansa @ 2014-01-14 9:21 UTC (permalink / raw)
To: b28495; +Cc: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 1581 bytes --]
On Tue, Jan 14, 2014 at 05:10:10PM +0800, b28495@freescale.com wrote:
> From: Ting Liu <b28495@freescale.com>
>
> Avoid below QA issues:
> | ERROR: QA Issue: package inetutils-ftp contains bad RPATH
> | ERROR: QA Issue: package inetutils-telnet contains bad RPATH
> | ERROR: QA Issue: package inetutils-telnetd contains bad RPATH
> | ERROR: QA run found fatal errors. Please consider fixing them.
> | ERROR: Function failed: do_package_qa
Doesn't it autodetect libreadline?
> Signed-off-by: Ting Liu <b28495@freescale.com>
> ---
> .../inetutils/inetutils_1.9.1.bb | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb b/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb
> index 97fc6a1..03b8e65 100644
> --- a/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb
> +++ b/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb
> @@ -37,7 +37,6 @@ PACKAGECONFIG[uucpd] = "--enable-uucpd,--disable-uucpd,readline"
>
> EXTRA_OECONF = "--with-ncurses-include-dir=${STAGING_INCDIR} \
> ${noipv6} \
> - --with-libreadline-prefix=${STAGING_DIR_HOST}${prefix} \
> "
>
> do_configure_prepend () {
> --
> 1.7.3.4
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-oe][PATCH 2/2] inetutils: not hard coded libreadline path
[not found] ` <d6d29dfe2a204196a850afc04467a23d@BN1PR03MB156.namprd03.prod.outlook.com>
@ 2014-01-14 9:50 ` Martin Jansa
2014-01-14 9:54 ` ting.liu
0 siblings, 1 reply; 5+ messages in thread
From: Martin Jansa @ 2014-01-14 9:50 UTC (permalink / raw)
To: ting.liu@freescale.com; +Cc: openembedded-devel@lists.openembedded.org
[-- Attachment #1: Type: text/plain, Size: 2472 bytes --]
On Tue, Jan 14, 2014 at 09:26:18AM +0000, ting.liu@freescale.com wrote:
> > -----Original Message-----
> > From: Martin Jansa [mailto:martin.jansa@gmail.com]
> > Sent: Tuesday, January 14, 2014 5:22 PM
> > To: Liu Ting-B28495
> > Cc: openembedded-devel@lists.openembedded.org
> > Subject: Re: [oe] [meta-oe][PATCH 2/2] inetutils: not hard coded
> > libreadline path
> >
> > On Tue, Jan 14, 2014 at 05:10:10PM +0800, b28495@freescale.com wrote:
> > > From: Ting Liu <b28495@freescale.com>
> > >
> > > Avoid below QA issues:
> > > | ERROR: QA Issue: package inetutils-ftp contains bad RPATH
> > > | ERROR: QA Issue: package inetutils-telnet contains bad RPATH
> > > | ERROR: QA Issue: package inetutils-telnetd contains bad RPATH
> > > | ERROR: QA run found fatal errors. Please consider fixing them.
> > > | ERROR: Function failed: do_package_qa
> >
> > Doesn't it autodetect libreadline?
>
> it can find libreadline without specifying --with-libreadline-prefix, so just remove the option to avoid QA errors.
If it disables libreadline support, that should be clearly stated in
commit message - from current one it looks like you're just fixing QA
issue.
>
> >
> > > Signed-off-by: Ting Liu <b28495@freescale.com>
> > > ---
> > > .../inetutils/inetutils_1.9.1.bb | 1 -
> > > 1 files changed, 0 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/meta-networking/recipes-
> > connectivity/inetutils/inetutils_1.9.1.bb b/meta-networking/recipes-
> > connectivity/inetutils/inetutils_1.9.1.bb
> > > index 97fc6a1..03b8e65 100644
> > > --- a/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb
> > > +++ b/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb
> > > @@ -37,7 +37,6 @@ PACKAGECONFIG[uucpd] = "--enable-uucpd,--disable-
> > uucpd,readline"
> > >
> > > EXTRA_OECONF = "--with-ncurses-include-dir=${STAGING_INCDIR} \
> > > ${noipv6} \
> > > - --with-libreadline-prefix=${STAGING_DIR_HOST}${prefix} \
> > > "
> > >
> > > do_configure_prepend () {
> > > --
> > > 1.7.3.4
> > >
> > >
> > > _______________________________________________
> > > Openembedded-devel mailing list
> > > Openembedded-devel@lists.openembedded.org
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >
> > --
> > Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-oe][PATCH 2/2] inetutils: not hard coded libreadline path
2014-01-14 9:50 ` Martin Jansa
@ 2014-01-14 9:54 ` ting.liu
0 siblings, 0 replies; 5+ messages in thread
From: ting.liu @ 2014-01-14 9:54 UTC (permalink / raw)
To: Martin Jansa; +Cc: openembedded-devel@lists.openembedded.org
> -----Original Message-----
> From: Martin Jansa [mailto:martin.jansa@gmail.com]
> Sent: Tuesday, January 14, 2014 5:50 PM
> To: Liu Ting-B28495
> Cc: openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [meta-oe][PATCH 2/2] inetutils: not hard coded
> libreadline path
>
> On Tue, Jan 14, 2014 at 09:26:18AM +0000, ting.liu@freescale.com wrote:
> > > -----Original Message-----
> > > From: Martin Jansa [mailto:martin.jansa@gmail.com]
> > > Sent: Tuesday, January 14, 2014 5:22 PM
> > > To: Liu Ting-B28495
> > > Cc: openembedded-devel@lists.openembedded.org
> > > Subject: Re: [oe] [meta-oe][PATCH 2/2] inetutils: not hard coded
> > > libreadline path
> > >
> > > On Tue, Jan 14, 2014 at 05:10:10PM +0800, b28495@freescale.com wrote:
> > > > From: Ting Liu <b28495@freescale.com>
> > > >
> > > > Avoid below QA issues:
> > > > | ERROR: QA Issue: package inetutils-ftp contains bad RPATH
> > > > | ERROR: QA Issue: package inetutils-telnet contains bad RPATH
> > > > | ERROR: QA Issue: package inetutils-telnetd contains bad RPATH
> > > > | ERROR: QA run found fatal errors. Please consider fixing them.
> > > > | ERROR: Function failed: do_package_qa
> > >
> > > Doesn't it autodetect libreadline?
> >
> > it can find libreadline without specifying --with-libreadline-prefix,
> so just remove the option to avoid QA errors.
>
> If it disables libreadline support, that should be clearly stated in
> commit message - from current one it looks like you're just fixing QA
> issue.
>
OK. I will check. Thanks.
> >
> > >
> > > > Signed-off-by: Ting Liu <b28495@freescale.com>
> > > > ---
> > > > .../inetutils/inetutils_1.9.1.bb | 1 -
> > > > 1 files changed, 0 insertions(+), 1 deletions(-)
> > > >
> > > > diff --git a/meta-networking/recipes-
> > > connectivity/inetutils/inetutils_1.9.1.bb b/meta-networking/recipes-
> > > connectivity/inetutils/inetutils_1.9.1.bb
> > > > index 97fc6a1..03b8e65 100644
> > > > ---
> > > > a/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.b
> > > > b
> > > > +++ b/meta-networking/recipes-connectivity/inetutils/inetutils_1.9
> > > > +++ .1.bb
> > > > @@ -37,7 +37,6 @@ PACKAGECONFIG[uucpd] =
> > > > "--enable-uucpd,--disable-
> > > uucpd,readline"
> > > >
> > > > EXTRA_OECONF = "--with-ncurses-include-dir=${STAGING_INCDIR} \
> > > > ${noipv6} \
> > > > - --with-libreadline-prefix=${STAGING_DIR_HOST}${prefix} \
> > > > "
> > > >
> > > > do_configure_prepend () {
> > > > --
> > > > 1.7.3.4
> > > >
> > > >
> > > > _______________________________________________
> > > > Openembedded-devel mailing list
> > > > Openembedded-devel@lists.openembedded.org
> > > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> > >
> > > --
> > > Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
>
> --
> Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-01-14 9:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-14 9:10 [meta-oe][PATCH 1/2] lmbench: use base_libdir instead of hardcoded /lib b28495
2014-01-14 9:10 ` [meta-oe][PATCH 2/2] inetutils: not hard coded libreadline path b28495
2014-01-14 9:21 ` Martin Jansa
[not found] ` <d6d29dfe2a204196a850afc04467a23d@BN1PR03MB156.namprd03.prod.outlook.com>
2014-01-14 9:50 ` Martin Jansa
2014-01-14 9:54 ` ting.liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.