From: Peter Zijlstra <peterz@infradead.org>
To: Daniel J Blueman <daniel@numascale.com>
Cc: Waiman Long <waiman.long@hp.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()
Date: Tue, 14 Jan 2014 12:03:07 +0100 [thread overview]
Message-ID: <20140114110307.GW7572@laptop.programming.kicks-ass.net> (raw)
In-Reply-To: <52D4A0C7.5070601@numascale.com>
On Tue, Jan 14, 2014 at 10:28:23AM +0800, Daniel J Blueman wrote:
> >Peter,
> >
> >I found out that the build failure was caused by the fact that the
> >__native_word() macro (used internally by compiletime_assert_atomic())
> >allows only a size of 4 or 8 for x86-64. The data type that I used is a
> >byte. Is there a reason why byte and short are not considered native?
>
> It seems likely it was implemented like that since there was no existing
> need; long can be relied on as the largest native type, so this should
> suffice and works here:
There's Alphas that cannot actually atomically adres a byte; I do not
konw if Linux cares about them, but if it does, we cannot in fact rely
on this in generic primitives like this.
next prev parent reply other threads:[~2014-01-14 11:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-13 2:47 [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock() Daniel J Blueman
2014-01-13 3:49 ` Paul E. McKenney
2014-01-13 16:41 ` Waiman Long
2014-01-14 2:28 ` Daniel J Blueman
2014-01-14 11:03 ` Peter Zijlstra [this message]
2014-01-14 15:25 ` Waiman Long
2014-01-14 17:08 ` Matt Turner
2014-01-14 18:01 ` Richard Henderson
2014-01-14 19:09 ` Waiman Long
2014-01-14 20:20 ` Peter Zijlstra
2014-01-14 23:44 ` Paul E. McKenney
2014-01-15 0:25 ` Linus Torvalds
2014-01-15 2:39 ` Paul E. McKenney
2014-01-15 8:07 ` Peter Zijlstra
2014-01-15 20:53 ` Paul E. McKenney
2014-01-15 23:21 ` Peter Zijlstra
[not found] ` <CA+55aFydYLQeBq=4AQQp_4dAnq09ocLmde1LFaXiNAJ=wJzfFA@mail.gmail.com>
2014-01-16 10:36 ` Peter Zijlstra
2014-01-18 10:01 ` Paul E. McKenney
2014-01-18 11:34 ` Peter Zijlstra
2014-01-18 12:25 ` Paul E. McKenney
2014-01-18 12:41 ` Peter Zijlstra
2014-01-18 21:22 ` Paul E. McKenney
2014-01-19 0:57 ` Linus Torvalds
2014-01-19 8:04 ` Paul E. McKenney
2014-01-19 19:56 ` Linus Torvalds
2014-01-20 0:52 ` Paul E. McKenney
2014-01-21 15:02 ` Waiman Long
2014-01-21 15:41 ` Peter Zijlstra
2014-01-21 16:16 ` Waiman Long
2014-01-15 3:08 ` Daniel J Blueman
-- strict thread matches above, loose matches on Subject: below --
2014-01-08 16:59 [PATCH v8 0/4] qrwlock: Introducing a queue read/write lock implementation Waiman Long
2014-01-08 16:59 ` [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock() Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140114110307.GW7572@laptop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=daniel@numascale.com \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rth@twiddle.net \
--cc=torvalds@linux-foundation.org \
--cc=waiman.long@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.