Re: [PATCH nft] expression: fix output of verdict maps

[Patrick McHardy <kaber@trash.net>]

On Tue, Jan 14, 2014 at 12:29:51PM +0100, Pablo Neira Ayuso wrote:
> On Tue, Jan 14, 2014 at 09:00:09AM +0000, Patrick McHardy wrote:
> > On Mon, Jan 13, 2014 at 12:42:03PM +0000, Patrick McHardy wrote:
> > > On Mon, Jan 13, 2014 at 01:39:16PM +0100, Pablo Neira Ayuso wrote:
> > > > % nft list table filter
> > > > table ip filter {
> > > > 	...
> > > > 	chain output {
> > > > 		...
> > > > 		ip saddr map { 1.1.1.1 => accept}
> > > > 	}
> > > > }
> > > > 
> > > > It displays 'map' instead of 'vmap'. Fix it by checking the mapping
> > > > type in map_expr_print().
> > > 
> > > The fix is fine of course, but even better would be to get rid of the
> > > vmap keyword IMO. IIRC it only exists because I couldn't manage to get
> > > a conflict free grammar together, but it would be worth another try.
> > 
> > Actually this works fine. Is there agreement on removing the VMAP keyword?
> > If so we should do it before the 0.099 release.
> 
> Sure, go ahead. I like it :) and it's consistent with other data maps.

Crap, I missed that it actually does introduce conflicts. Will try to solve
them or revert that patch.