From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] expression: fix output of verdict maps
Date: Thu, 16 Jan 2014 16:57:53 +0000 [thread overview]
Message-ID: <20140116165753.GA4958@macbook.localnet> (raw)
In-Reply-To: <20140116165337.GA5205@localhost>
On Thu, Jan 16, 2014 at 05:53:37PM +0100, Pablo Neira Ayuso wrote:
> On Mon, Jan 13, 2014 at 01:39:16PM +0100, Pablo Neira Ayuso wrote:
> > % nft list table filter
> > table ip filter {
> > ...
> > chain output {
> > ...
> > ip saddr map { 1.1.1.1 => accept}
> > }
> > }
> >
> > It displays 'map' instead of 'vmap'. Fix it by checking the mapping
> > type in map_expr_print().
>
> Spinning over the list of pending stuff in my notepad before the
> release.
>
> I think it's not so bad if we keep the 'vmap' for verdict maps. This
> can just become a synonym of 'map' if we ever find the way to make it
> work without ambiguity complains from the parser.
Yes, absolutely. We should just add your patch to fix the output for now.
next prev parent reply other threads:[~2014-01-16 16:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-13 12:39 [PATCH nft] expression: fix output of verdict maps Pablo Neira Ayuso
2014-01-13 12:42 ` Patrick McHardy
2014-01-14 9:00 ` Patrick McHardy
2014-01-14 11:29 ` Pablo Neira Ayuso
2014-01-14 12:33 ` Patrick McHardy
2014-01-16 16:53 ` Pablo Neira Ayuso
2014-01-16 16:57 ` Patrick McHardy [this message]
2014-01-16 17:03 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140116165753.GA4958@macbook.localnet \
--to=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.