From: Marcelo Tosatti <mtosatti@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Vadim Rozenfeld <vrozenfe@redhat.com>, kvm@vger.kernel.org, pl@dlhnet.de
Subject: Re: [RFC PATCH v4 2/2] add support for Hyper-V partition reference time enlightenment
Date: Tue, 14 Jan 2014 17:10:33 -0200 [thread overview]
Message-ID: <20140114191033.GA4898@amt.cnet> (raw)
In-Reply-To: <52D5197C.6090207@redhat.com>
On Tue, Jan 14, 2014 at 12:03:24PM +0100, Paolo Bonzini wrote:
> The cleanup between v3 and v4 is really nice; thanks. What happened to
> the glitch you reported in the v3 thread.
>
> Il 14/01/2014 10:22, Vadim Rozenfeld ha scritto:
> > + tsc_ref.tsc_scale = ((10000LL << 32) /
> > + vcpu->arch.virtual_tsc_khz) << 32;
>
> As mentioned in the review of v3, I don't really like the tsc_scale to
> come from two different sources in the two cases of MSR write and
> KVM_SET_CLOCK. This is the only qualm I still have with this patch.
> Marcelo, do you have any ideas?
It should be at kvm_guest_time_update.
next prev parent reply other threads:[~2014-01-14 23:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 9:22 [RFC PATCH v4 0/2] Hyper-V timers Vadim Rozenfeld
2014-01-14 9:22 ` [RFC PATCH v4 1/2] add support for Hyper-V reference time counter Vadim Rozenfeld
2014-01-14 11:06 ` Paolo Bonzini
2014-01-14 9:22 ` [RFC PATCH v4 2/2] add support for Hyper-V partition reference time enlightenment Vadim Rozenfeld
2014-01-14 11:03 ` Paolo Bonzini
2014-01-14 19:10 ` Marcelo Tosatti [this message]
2014-01-14 19:20 ` Marcelo Tosatti
2014-01-16 13:53 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140114191033.GA4898@amt.cnet \
--to=mtosatti@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=pl@dlhnet.de \
--cc=vrozenfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.