From: Mark Brown <broonie@kernel.org>
To: Mike Turquette <mturquette@linaro.org>
Cc: Saravana Kannan <skannan@codeaurora.org>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 02/15] clk: Allow drivers to pass in a regmap
Date: Wed, 15 Jan 2014 10:54:46 +0000 [thread overview]
Message-ID: <20140115105446.GF15567@sirena.org.uk> (raw)
In-Reply-To: <20140115093641.4167.83109@quantum>
[-- Attachment #1: Type: text/plain, Size: 772 bytes --]
On Wed, Jan 15, 2014 at 01:36:41AM -0800, Mike Turquette wrote:
> Providing common functions for the basic case (e.g. read-modify-write on
> a register using a known mask) is reasonable. But that is exactly what
> the existing basic clock types do (sans regmap) and they have all become
> pretty ugly over time. And the clk-composite implementation just makes
> me a sad panda.
What we've tried to do with regulators is just have multiple helper
functions in the core rather than trying to merge their implementation,
the drivers pick the right one for their usage, and in cases where there
aren't many drivers doing the same thing we just have the driver either
copy the bits of the implementation they reuse or call the helper
function from within the implementation.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 02/15] clk: Allow drivers to pass in a regmap
Date: Wed, 15 Jan 2014 10:54:46 +0000 [thread overview]
Message-ID: <20140115105446.GF15567@sirena.org.uk> (raw)
In-Reply-To: <20140115093641.4167.83109@quantum>
On Wed, Jan 15, 2014 at 01:36:41AM -0800, Mike Turquette wrote:
> Providing common functions for the basic case (e.g. read-modify-write on
> a register using a known mask) is reasonable. But that is exactly what
> the existing basic clock types do (sans regmap) and they have all become
> pretty ugly over time. And the clk-composite implementation just makes
> me a sad panda.
What we've tried to do with regulators is just have multiple helper
functions in the core rather than trying to merge their implementation,
the drivers pick the right one for their usage, and in cases where there
aren't many drivers doing the same thing we just have the driver either
copy the bits of the implementation they reuse or call the helper
function from within the implementation.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140115/8b75c283/attachment.sig>
next prev parent reply other threads:[~2014-01-15 10:55 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 1:12 [PATCH v4 00/15] Add support for MSM's mmio clock/reset controller Stephen Boyd
2013-12-24 1:12 ` Stephen Boyd
2013-12-24 1:12 ` [PATCH v4 01/15] reset: Silence warning in reset-controller.h Stephen Boyd
2013-12-24 1:12 ` Stephen Boyd
2014-01-06 17:28 ` Philipp Zabel
2014-01-06 17:28 ` Philipp Zabel
2013-12-24 1:12 ` [PATCH v4 02/15] clk: Allow drivers to pass in a regmap Stephen Boyd
2013-12-24 1:12 ` Stephen Boyd
2013-12-24 1:12 ` Stephen Boyd
2013-12-24 13:13 ` Mark Brown
2013-12-24 13:13 ` Mark Brown
2014-01-09 1:51 ` Mike Turquette
2014-01-09 1:51 ` Mike Turquette
2014-01-09 2:11 ` Stephen Boyd
2014-01-09 2:11 ` Stephen Boyd
2014-01-09 22:12 ` Stephen Boyd
2014-01-09 22:12 ` Stephen Boyd
2014-01-10 5:44 ` Mike Turquette
2014-01-10 5:44 ` Mike Turquette
2014-01-10 7:05 ` Stephen Boyd
2014-01-10 7:05 ` Stephen Boyd
2014-01-14 2:25 ` Stephen Boyd
2014-01-14 2:25 ` Stephen Boyd
2014-01-15 9:28 ` Mike Turquette
2014-01-15 9:28 ` Mike Turquette
2014-01-15 19:03 ` Stephen Boyd
2014-01-15 19:03 ` Stephen Boyd
2014-01-14 3:54 ` Saravana Kannan
2014-01-14 3:54 ` Saravana Kannan
2014-01-15 9:36 ` Mike Turquette
2014-01-15 9:36 ` Mike Turquette
2014-01-15 10:54 ` Mark Brown [this message]
2014-01-15 10:54 ` Mark Brown
2014-01-17 1:38 ` Saravana Kannan
2014-01-17 1:38 ` Saravana Kannan
2013-12-24 1:12 ` [PATCH v4 03/15] clk: Add regmap core helpers for enable/disable/is_enabled Stephen Boyd
2013-12-24 1:12 ` Stephen Boyd
2013-12-24 1:12 ` Stephen Boyd
2013-12-24 13:14 ` Mark Brown
2013-12-24 13:14 ` Mark Brown
2013-12-24 15:07 ` Gerhard Sittig
2013-12-24 15:07 ` Gerhard Sittig
2013-12-26 19:31 ` Stephen Boyd
2013-12-26 19:31 ` Stephen Boyd
2013-12-31 13:02 ` Gerhard Sittig
2013-12-31 13:02 ` Gerhard Sittig
2013-12-24 1:12 ` [PATCH v4 04/15] clk: Add set_rate_and_parent() op Stephen Boyd
2013-12-24 1:12 ` Stephen Boyd
2013-12-24 1:12 ` Stephen Boyd
2013-12-24 1:12 ` [PATCH v4 05/15] clk: qcom: Add support for phase locked loops (PLLs) Stephen Boyd
2013-12-24 1:12 ` Stephen Boyd
2013-12-24 1:12 ` [PATCH v4 06/15] clk: qcom: Add support for root clock generators (RCGs) Stephen Boyd
2013-12-24 1:12 ` Stephen Boyd
2013-12-24 1:12 ` [PATCH v4 07/15] clk: qcom: Add support for branches/gate clocks Stephen Boyd
2013-12-24 1:12 ` Stephen Boyd
2013-12-24 1:12 ` [PATCH v4 08/15] clk: qcom: Add reset controller support Stephen Boyd
2013-12-24 1:12 ` Stephen Boyd
2013-12-24 1:12 ` [PATCH v4 09/15] clk: qcom: Add support for MSM8960's global clock controller (GCC) Stephen Boyd
2013-12-24 1:12 ` Stephen Boyd
2013-12-24 1:12 ` [PATCH v4 10/15] clk: qcom: Add support for MSM8960's multimedia clock controller (MMCC) Stephen Boyd
2013-12-24 1:12 ` Stephen Boyd
2013-12-24 1:12 ` [PATCH v4 11/15] clk: qcom: Add support for MSM8974's global clock controller (GCC) Stephen Boyd
2013-12-24 1:12 ` Stephen Boyd
2013-12-24 1:12 ` [PATCH v4 12/15] clk: qcom: Add support for MSM8974's multimedia clock controller (MMCC) Stephen Boyd
2013-12-24 1:12 ` Stephen Boyd
2013-12-24 1:12 ` [PATCH v4 13/15] clk: qcom: Add support for MSM8660's global clock controller (GCC) Stephen Boyd
2013-12-24 1:12 ` Stephen Boyd
2013-12-24 1:12 ` [PATCH v4 14/15] devicetree: bindings: Document qcom,gcc Stephen Boyd
2013-12-24 1:12 ` Stephen Boyd
2013-12-24 1:12 ` Stephen Boyd
2013-12-24 1:12 ` [PATCH v4 15/15] devicetree: bindings: Document qcom,mmcc Stephen Boyd
2013-12-24 1:12 ` Stephen Boyd
2013-12-24 1:12 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140115105446.GF15567@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=sboyd@codeaurora.org \
--cc=skannan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.