From: Mark Brown <broonie@kernel.org>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: alsa-devel@alsa-project.org, Xiubo Li <Li.Xiubo@freescale.com>,
lgirdwood@gmail.com,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
linux-kernel@vger.kernel.org
Subject: Re: Problems with simple-card
Date: Wed, 15 Jan 2014 18:56:21 +0000 [thread overview]
Message-ID: <20140115185621.GL15567@sirena.org.uk> (raw)
In-Reply-To: <20140115191831.5965d17e@armhf>
[-- Attachment #1.1: Type: text/plain, Size: 752 bytes --]
On Wed, Jan 15, 2014 at 07:18:31PM +0100, Jean-Francois Moine wrote:
> The main problem is about sysclk: when there is no clock in the DT,
> you get the clock of the CPU or CODEC DAI. In my system, two clocks
> are declared in the controller CPU DAI, but there is no .set_sysclk
> pointer. So, snd_soc_dai_set_sysclk() returns -EINVAL and the card is
> not created.
set_sysclk() should be returning -ENOTSUPP in this case as with
set_fmt() and the generic code then ignoring that error.
> As I don't know why you need these fmt and sysclk, may you have a
> look at these problems?
The overwhelming majority of combinations of devices need a format
specifying (usually one will be imposed by the system design even if
both devices could be master).
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: Xiubo Li <Li.Xiubo@freescale.com>,
lgirdwood@gmail.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: Problems with simple-card
Date: Wed, 15 Jan 2014 18:56:21 +0000 [thread overview]
Message-ID: <20140115185621.GL15567@sirena.org.uk> (raw)
In-Reply-To: <20140115191831.5965d17e@armhf>
[-- Attachment #1: Type: text/plain, Size: 752 bytes --]
On Wed, Jan 15, 2014 at 07:18:31PM +0100, Jean-Francois Moine wrote:
> The main problem is about sysclk: when there is no clock in the DT,
> you get the clock of the CPU or CODEC DAI. In my system, two clocks
> are declared in the controller CPU DAI, but there is no .set_sysclk
> pointer. So, snd_soc_dai_set_sysclk() returns -EINVAL and the card is
> not created.
set_sysclk() should be returning -ENOTSUPP in this case as with
set_fmt() and the generic code then ignoring that error.
> As I don't know why you need these fmt and sysclk, may you have a
> look at these problems?
The overwhelming majority of combinations of devices need a format
specifying (usually one will be imposed by the system design even if
both devices could be master).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-01-15 18:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 18:18 Problems with simple-card Jean-Francois Moine
2014-01-15 18:50 ` Mark Brown
2014-01-15 18:56 ` Mark Brown [this message]
2014-01-15 18:56 ` Mark Brown
2014-01-16 0:30 ` [alsa-devel] " Kuninori Morimoto
2014-01-16 3:47 ` Li.Xiubo
2014-01-16 3:47 ` Li.Xiubo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140115185621.GL15567@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=moinejf@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.