Re: [PATCH v3 1/2] Hard disk S3 resume time optimization

[Todd E Brandt <todd.e.brandt@linux.intel.com>]

On Wed, Jan 15, 2014 at 08:01:04AM -0500, Tejun Heo wrote:
> Hello,
> 
> On Tue, Jan 14, 2014 at 04:31:40PM -0800, Todd E Brandt wrote:
> ....
> > Signed-off-by: Todd Brandt <todd.e.brandt@intel.com>
> > Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
> > 
> >  drivers/ata/libata-core.c | 32 +++++++++++++++++---------------
> >  1 file changed, 17 insertions(+), 15 deletions(-)
> > 
> > Signed-off-by: Todd Brandt <todd.e.brandt@intel.com>
> > Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
> 
> Hmmm?  Duplicate SOBs and there's supposed to be "---" separator
> between patch description and the rest.

It's just an editor mistake, sorry

> 
> > @@ -5326,7 +5326,7 @@ bool ata_link_offline(struct ata_link *link)
> >  #ifdef CONFIG_PM
> >  static int ata_port_request_pm(struct ata_port *ap, pm_message_t mesg,
> >  			       unsigned int action, unsigned int ehi_flags,
> > -			       int *async)
> > +			       bool async, int *async_result)
> 
> Do we still need @async_result?  Only resume is async and resume
> doesn't care about the result.  Suspend is always synchronous and thus
> can just return the result, no?

Good point, will fix, thanks.

> 
> Thanks.
> 
> -- 
> tejun