From: Phillip Susi <psusi@ubuntu.com>
To: "Brandt, Todd E" <todd.e.brandt@intel.com>,
"todd.e.brandt@linux.intel.com" <todd.e.brandt@linux.intel.com>,
"tj@kernel.org" <tj@kernel.org>,
"James.Bottomley@HansenPartnership.com"
<James.Bottomley@HansenPartnership.com>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH/RESEND v2 1/2] Hard disk S3 resume time optimization
Date: Fri, 10 Jan 2014 21:13:08 -0500 [thread overview]
Message-ID: <52D0A8B4.90905@ubuntu.com> (raw)
In-Reply-To: <11E08D716F0541429B7042699DD5C1A17073C362@FMSMSX103.amr.corp.intel.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
On 01/10/2014 06:11 PM, Brandt, Todd E wrote:
> Yes yours is simpler, but it also opens a potential memory issue
> by passing a static int as the return location for the error value.
> I think it's just safer to tell the callback to attempt no return
> value at all, and for that you need to expand it into two
> arguments, one for selection, the other for the output address.
What sort of memory issue? Also isn't there a system NULL page
somewhere that could be used?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBCgAGBQJS0Ki0AAoJEI5FoCIzSKrwzAUH/3PXkCbb1zW6ObzBVOS8I4vM
SjeE9unHqTlFbFL8M/sTWV+LJTKnIpEBEfV7QXFENDKPi+o58Aq1PanvW0Pu/R5+
/hOR08ry7HMRqK+Q/J+CynjoMQO3Qfw0elIVQUkSsayqdeA2QeLMDbWLxQhh9j85
o5AD7VsW1X8M7l1yzCUvl5A68M/ZR9dapW3RlErRmTdECZE5qLTN2RKezfboM5lo
i4y8IWadF7tou4vbqoGQd/JVgmgc4SRlal7HAqbVWuwmumslMGGBNpZTcgY7ffvT
PLHnx8txmeK2ELVg/aRm34j2TdI8mAYzIQ2pJ7hKwRlBc5W8ho4XHEy9o1jDaLg=
=MCaR
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2014-01-11 2:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 0:56 [PATCH/RESEND v2 1/2] Hard disk S3 resume time optimization Todd E Brandt
2014-01-09 17:03 ` Phillip Susi
2014-01-10 23:11 ` Brandt, Todd E
2014-01-11 2:13 ` Phillip Susi [this message]
2014-01-11 3:13 ` Dan Williams
2014-01-13 20:06 ` Todd E Brandt
2014-01-13 20:37 ` Dan Williams
2014-01-13 23:51 ` Todd E Brandt
2014-01-14 0:05 ` Dan Williams
2014-01-11 19:13 ` Tejun Heo
2014-01-13 19:55 ` Todd E Brandt
2014-01-13 20:30 ` Tejun Heo
2014-01-13 23:30 ` Todd E Brandt
2014-01-14 14:31 ` Tejun Heo
2014-01-15 0:31 ` [PATCH v3 0/2] " Todd E Brandt
2014-01-15 12:55 ` Tejun Heo
2014-01-15 0:31 ` [PATCH v3 1/2] " Todd E Brandt
2014-01-15 13:01 ` Tejun Heo
2014-01-15 20:04 ` Todd E Brandt
2014-01-15 0:32 ` [PATCH v3 2/2] " Todd E Brandt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D0A8B4.90905@ubuntu.com \
--to=psusi@ubuntu.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tj@kernel.org \
--cc=todd.e.brandt@intel.com \
--cc=todd.e.brandt@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.