* [PATCH] sh: kgdb: Add missing #include <linux/sched.h>
@ 2014-01-16 22:20 ` Geert Uytterhoeven
0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2014-01-16 22:20 UTC (permalink / raw)
To: Andrew Morton
Cc: Greg Kroah-Hartman, linux-sh, linux-kernel, Wanlong Gao,
Geert Uytterhoeven
From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
arch/sh/kernel/kgdb.c: In function 'sleeping_thread_to_gdb_regs':
arch/sh/kernel/kgdb.c:225:32: error: implicit declaration of function 'task_stack_page' [-Werror=implicit-function-declaration]
arch/sh/kernel/kgdb.c:242:23: error: dereferencing pointer to incomplete type
arch/sh/kernel/kgdb.c:243:22: error: dereferencing pointer to incomplete type
arch/sh/kernel/kgdb.c: In function 'singlestep_trap_handler':
arch/sh/kernel/kgdb.c:310:27: error: 'SIGTRAP' undeclared (first use in this function)
arch/sh/kernel/kgdb.c:310:27: note: each undeclared identifier is reported only once for each function it appears in
This is introduced by commit 16559ae48c76f1ceb970b9719dea62b77eb5d06b
("kgdb: remove #include <linux/serial_8250.h> from kgdb.h").
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
[geert: Reworded and reformatted]
Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
---
http://kisskb.ellerman.id.au/kisskb/buildresult/10477672/
arch/sh/kernel/kgdb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/sh/kernel/kgdb.c b/arch/sh/kernel/kgdb.c
index 38b313909ac9..adad46e41a1d 100644
--- a/arch/sh/kernel/kgdb.c
+++ b/arch/sh/kernel/kgdb.c
@@ -13,6 +13,7 @@
#include <linux/kdebug.h>
#include <linux/irq.h>
#include <linux/io.h>
+#include <linux/sched.h>
#include <asm/cacheflush.h>
#include <asm/traps.h>
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] sh: kgdb: Add missing #include <linux/sched.h>
@ 2014-01-16 22:20 ` Geert Uytterhoeven
0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2014-01-16 22:20 UTC (permalink / raw)
To: Andrew Morton
Cc: Greg Kroah-Hartman, linux-sh, linux-kernel, Wanlong Gao,
Geert Uytterhoeven
From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
arch/sh/kernel/kgdb.c: In function 'sleeping_thread_to_gdb_regs':
arch/sh/kernel/kgdb.c:225:32: error: implicit declaration of function 'task_stack_page' [-Werror=implicit-function-declaration]
arch/sh/kernel/kgdb.c:242:23: error: dereferencing pointer to incomplete type
arch/sh/kernel/kgdb.c:243:22: error: dereferencing pointer to incomplete type
arch/sh/kernel/kgdb.c: In function 'singlestep_trap_handler':
arch/sh/kernel/kgdb.c:310:27: error: 'SIGTRAP' undeclared (first use in this function)
arch/sh/kernel/kgdb.c:310:27: note: each undeclared identifier is reported only once for each function it appears in
This is introduced by commit 16559ae48c76f1ceb970b9719dea62b77eb5d06b
("kgdb: remove #include <linux/serial_8250.h> from kgdb.h").
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
[geert: Reworded and reformatted]
Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
---
http://kisskb.ellerman.id.au/kisskb/buildresult/10477672/
arch/sh/kernel/kgdb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/sh/kernel/kgdb.c b/arch/sh/kernel/kgdb.c
index 38b313909ac9..adad46e41a1d 100644
--- a/arch/sh/kernel/kgdb.c
+++ b/arch/sh/kernel/kgdb.c
@@ -13,6 +13,7 @@
#include <linux/kdebug.h>
#include <linux/irq.h>
#include <linux/io.h>
+#include <linux/sched.h>
#include <asm/cacheflush.h>
#include <asm/traps.h>
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] sh: kgdb: Add missing #include <linux/sched.h>
2014-01-16 22:20 ` Geert Uytterhoeven
@ 2014-01-16 22:24 ` Greg Kroah-Hartman
-1 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2014-01-16 22:24 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Andrew Morton, linux-sh, linux-kernel, Wanlong Gao,
Geert Uytterhoeven
On Thu, Jan 16, 2014 at 11:20:00PM +0100, Geert Uytterhoeven wrote:
> From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
>
> arch/sh/kernel/kgdb.c: In function 'sleeping_thread_to_gdb_regs':
> arch/sh/kernel/kgdb.c:225:32: error: implicit declaration of function 'task_stack_page' [-Werror=implicit-function-declaration]
> arch/sh/kernel/kgdb.c:242:23: error: dereferencing pointer to incomplete type
> arch/sh/kernel/kgdb.c:243:22: error: dereferencing pointer to incomplete type
> arch/sh/kernel/kgdb.c: In function 'singlestep_trap_handler':
> arch/sh/kernel/kgdb.c:310:27: error: 'SIGTRAP' undeclared (first use in this function)
> arch/sh/kernel/kgdb.c:310:27: note: each undeclared identifier is reported only once for each function it appears in
>
> This is introduced by commit 16559ae48c76f1ceb970b9719dea62b77eb5d06b
> ("kgdb: remove #include <linux/serial_8250.h> from kgdb.h").
Which showed up in 3.9-rc1, seems that no one seems to care about this
arch/config much :)
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> [geert: Reworded and reformatted]
> Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
Cc: stable <stable@vger.kernel.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] sh: kgdb: Add missing #include <linux/sched.h>
@ 2014-01-16 22:24 ` Greg Kroah-Hartman
0 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2014-01-16 22:24 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Andrew Morton, linux-sh, linux-kernel, Wanlong Gao,
Geert Uytterhoeven
On Thu, Jan 16, 2014 at 11:20:00PM +0100, Geert Uytterhoeven wrote:
> From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
>
> arch/sh/kernel/kgdb.c: In function 'sleeping_thread_to_gdb_regs':
> arch/sh/kernel/kgdb.c:225:32: error: implicit declaration of function 'task_stack_page' [-Werror=implicit-function-declaration]
> arch/sh/kernel/kgdb.c:242:23: error: dereferencing pointer to incomplete type
> arch/sh/kernel/kgdb.c:243:22: error: dereferencing pointer to incomplete type
> arch/sh/kernel/kgdb.c: In function 'singlestep_trap_handler':
> arch/sh/kernel/kgdb.c:310:27: error: 'SIGTRAP' undeclared (first use in this function)
> arch/sh/kernel/kgdb.c:310:27: note: each undeclared identifier is reported only once for each function it appears in
>
> This is introduced by commit 16559ae48c76f1ceb970b9719dea62b77eb5d06b
> ("kgdb: remove #include <linux/serial_8250.h> from kgdb.h").
Which showed up in 3.9-rc1, seems that no one seems to care about this
arch/config much :)
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> [geert: Reworded and reformatted]
> Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
Cc: stable <stable@vger.kernel.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] sh: kgdb: Add missing #include <linux/sched.h>
2014-01-16 22:24 ` Greg Kroah-Hartman
@ 2014-01-16 22:28 ` Geert Uytterhoeven
-1 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2014-01-16 22:28 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Andrew Morton, Linux-sh list, linux-kernel@vger.kernel.org,
Wanlong Gao, Geert Uytterhoeven
On Thu, Jan 16, 2014 at 11:24 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Thu, Jan 16, 2014 at 11:20:00PM +0100, Geert Uytterhoeven wrote:
>> From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
>>
>> arch/sh/kernel/kgdb.c: In function 'sleeping_thread_to_gdb_regs':
>> arch/sh/kernel/kgdb.c:225:32: error: implicit declaration of function 'task_stack_page' [-Werror=implicit-function-declaration]
>> arch/sh/kernel/kgdb.c:242:23: error: dereferencing pointer to incomplete type
>> arch/sh/kernel/kgdb.c:243:22: error: dereferencing pointer to incomplete type
>> arch/sh/kernel/kgdb.c: In function 'singlestep_trap_handler':
>> arch/sh/kernel/kgdb.c:310:27: error: 'SIGTRAP' undeclared (first use in this function)
>> arch/sh/kernel/kgdb.c:310:27: note: each undeclared identifier is reported only once for each function it appears in
>>
>> This is introduced by commit 16559ae48c76f1ceb970b9719dea62b77eb5d06b
>> ("kgdb: remove #include <linux/serial_8250.h> from kgdb.h").
>
> Which showed up in 3.9-rc1, seems that no one seems to care about this
> arch/config much :)
That's why I didn't dare to add a CC to stable myself ;-)
BTW, the patch is also a few months old.
>> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
>> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
>> [geert: Reworded and reformatted]
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
>
> Cc: stable <stable@vger.kernel.org>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] sh: kgdb: Add missing #include <linux/sched.h>
@ 2014-01-16 22:28 ` Geert Uytterhoeven
0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2014-01-16 22:28 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Andrew Morton, Linux-sh list, linux-kernel@vger.kernel.org,
Wanlong Gao, Geert Uytterhoeven
On Thu, Jan 16, 2014 at 11:24 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Thu, Jan 16, 2014 at 11:20:00PM +0100, Geert Uytterhoeven wrote:
>> From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
>>
>> arch/sh/kernel/kgdb.c: In function 'sleeping_thread_to_gdb_regs':
>> arch/sh/kernel/kgdb.c:225:32: error: implicit declaration of function 'task_stack_page' [-Werror=implicit-function-declaration]
>> arch/sh/kernel/kgdb.c:242:23: error: dereferencing pointer to incomplete type
>> arch/sh/kernel/kgdb.c:243:22: error: dereferencing pointer to incomplete type
>> arch/sh/kernel/kgdb.c: In function 'singlestep_trap_handler':
>> arch/sh/kernel/kgdb.c:310:27: error: 'SIGTRAP' undeclared (first use in this function)
>> arch/sh/kernel/kgdb.c:310:27: note: each undeclared identifier is reported only once for each function it appears in
>>
>> This is introduced by commit 16559ae48c76f1ceb970b9719dea62b77eb5d06b
>> ("kgdb: remove #include <linux/serial_8250.h> from kgdb.h").
>
> Which showed up in 3.9-rc1, seems that no one seems to care about this
> arch/config much :)
That's why I didn't dare to add a CC to stable myself ;-)
BTW, the patch is also a few months old.
>> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
>> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
>> [geert: Reworded and reformatted]
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
>
> Cc: stable <stable@vger.kernel.org>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-01-16 22:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-16 22:20 [PATCH] sh: kgdb: Add missing #include <linux/sched.h> Geert Uytterhoeven
2014-01-16 22:20 ` Geert Uytterhoeven
2014-01-16 22:24 ` Greg Kroah-Hartman
2014-01-16 22:24 ` Greg Kroah-Hartman
2014-01-16 22:28 ` Geert Uytterhoeven
2014-01-16 22:28 ` Geert Uytterhoeven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.