All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Olof Johansson <olof@lixom.net>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Arnd Bergmann <arnd@arndb.de>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: How to support SDIO wifi/bt in DT
Date: Fri, 17 Jan 2014 11:14:56 +0100	[thread overview]
Message-ID: <20140117101456.GD2348@piout.net> (raw)
In-Reply-To: <CAGb2v640Qeb60dMq2kH6M6NqkVbdUh1JcCus3a7D7icQeDdKNg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1777 bytes --]

On Fri, Jan 17, 2014 at 06:06:41PM +0800, Chen-Yu Tsai wrote :
> On Fri, Jan 17, 2014 at 5:39 PM, Alexandre Belloni
> <alexandre.belloni@free-electrons.com> wrote:
> > Maybe it is not completely related but I think it needs to be thought
> > about while you are it:
> >
> > The TI wilink chips (TiWi, wl12xx, wl18xx) have wifi on SDIO and BT on
> > UART but they share the same clock. So, the next question would be what
> > if I just want to enable one or the other (and take that decision at
> > runtime) ?
> 
> Some Broadcom chips (BCM4329/4330) and the AP6210 found on CubieTruck
> are like this as well. In our case, the SD/MMC host driver hasn't been
> mainlined yet. But BT on UART is independent and usable.
> 
> > Where do I put the pinctrl/clocks/regulators in the DT ? I guess it can
> > become an issue to enable both WiFi and BT at the same time if both SDIO
> > and UART are trying to handle the same pinctrl and regulators.
> 
> Shouldn't the clocks and regulators be registered in the DT _AS_ clocks
> and regulators? fixed-regulator already accepts GPIO lines. fixed-rate-clock
> mentions GPIOs in DT bindings, but doesn't seem to use them in the code.
> We'd still need a device to tie them to, especially in the UART use case.
> 

Yeah, I meant if you tie your clock/pinctrl/reset/regulator to both the
BT and the WiFI nodes because it is shared, you'll at least get a
warning or one of the two won't be working.

> Or we could try rfkill devices. Not saying it's the correct way, but it is
> a solution.
> 

You'll get the same issue there. Two rfkill devices sharing the same
clock or reset for example.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: How to support SDIO wifi/bt in DT
Date: Fri, 17 Jan 2014 11:14:56 +0100	[thread overview]
Message-ID: <20140117101456.GD2348@piout.net> (raw)
In-Reply-To: <CAGb2v640Qeb60dMq2kH6M6NqkVbdUh1JcCus3a7D7icQeDdKNg@mail.gmail.com>

On Fri, Jan 17, 2014 at 06:06:41PM +0800, Chen-Yu Tsai wrote :
> On Fri, Jan 17, 2014 at 5:39 PM, Alexandre Belloni
> <alexandre.belloni@free-electrons.com> wrote:
> > Maybe it is not completely related but I think it needs to be thought
> > about while you are it:
> >
> > The TI wilink chips (TiWi, wl12xx, wl18xx) have wifi on SDIO and BT on
> > UART but they share the same clock. So, the next question would be what
> > if I just want to enable one or the other (and take that decision at
> > runtime) ?
> 
> Some Broadcom chips (BCM4329/4330) and the AP6210 found on CubieTruck
> are like this as well. In our case, the SD/MMC host driver hasn't been
> mainlined yet. But BT on UART is independent and usable.
> 
> > Where do I put the pinctrl/clocks/regulators in the DT ? I guess it can
> > become an issue to enable both WiFi and BT at the same time if both SDIO
> > and UART are trying to handle the same pinctrl and regulators.
> 
> Shouldn't the clocks and regulators be registered in the DT _AS_ clocks
> and regulators? fixed-regulator already accepts GPIO lines. fixed-rate-clock
> mentions GPIOs in DT bindings, but doesn't seem to use them in the code.
> We'd still need a device to tie them to, especially in the UART use case.
> 

Yeah, I meant if you tie your clock/pinctrl/reset/regulator to both the
BT and the WiFI nodes because it is shared, you'll at least get a
warning or one of the two won't be working.

> Or we could try rfkill devices. Not saying it's the correct way, but it is
> a solution.
> 

You'll get the same issue there. Two rfkill devices sharing the same
clock or reset for example.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140117/d440c2f6/attachment.sig>

  reply	other threads:[~2014-01-17 10:15 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-16 13:36 How to support SDIO wifi/bt in DT Russell King - ARM Linux
2014-01-16 13:51 ` Chen-Yu Tsai
2014-01-16 14:02 ` Arnd Bergmann
2014-01-16 17:15   ` Olof Johansson
2014-01-16 17:15     ` Olof Johansson
2014-01-16 19:58     ` Russell King - ARM Linux
2014-01-16 19:58       ` Russell King - ARM Linux
2014-01-16 20:00       ` Olof Johansson
2014-01-16 20:00         ` Olof Johansson
2014-01-16 20:03         ` Russell King - ARM Linux
2014-01-16 20:03           ` Russell King - ARM Linux
2014-01-17  9:39         ` Alexandre Belloni
2014-01-17  9:39           ` Alexandre Belloni
2014-01-17 10:06           ` Chen-Yu Tsai
2014-01-17 10:06             ` Chen-Yu Tsai
2014-01-17 10:14             ` Alexandre Belloni [this message]
2014-01-17 10:14               ` Alexandre Belloni
2014-01-17 10:44           ` Andrew Lunn
2014-01-17 10:44             ` Andrew Lunn
2014-02-05 17:11             ` Mark Brown
2014-02-05 17:11               ` Mark Brown
2014-01-16 21:46     ` Arnd Bergmann
2014-01-16 21:46       ` Arnd Bergmann
2014-01-16 21:52       ` Olof Johansson
2014-01-16 21:52         ` Olof Johansson
2014-01-16 22:14       ` Marcel Holtmann
2014-01-16 22:14         ` Marcel Holtmann
2014-01-17  3:08     ` Nicolas Pitre
2014-01-17  3:08       ` Nicolas Pitre
2014-01-17 14:47       ` Arnd Bergmann
2014-01-17 14:47         ` Arnd Bergmann
     [not found]       ` <alpine.LFD.2.10.1401162204560.28907-fMhRO7WWcppj+hNMo8g0rg@public.gmane.org>
2014-01-17 15:14         ` Rob Herring
2014-01-17 15:14           ` Rob Herring
2014-01-17 16:58           ` Nicolas Pitre
2014-01-17 16:58             ` Nicolas Pitre
2014-01-19 19:29             ` Olof Johansson
2014-01-19 19:29               ` Olof Johansson
2014-01-19 20:28               ` Arnd Bergmann
2014-01-19 20:28                 ` Arnd Bergmann
2014-01-19 23:26                 ` Olof Johansson
2014-01-19 23:26                   ` Olof Johansson
2014-01-19 23:09               ` Alexandre Belloni
2014-01-19 23:09                 ` Alexandre Belloni
2014-01-19 23:30                 ` Olof Johansson
2014-01-19 23:30                   ` Olof Johansson
2014-01-20  3:57                   ` Olof Johansson
2014-01-20  3:57                     ` Olof Johansson
2014-01-17  9:02     ` Alexandre Belloni
2014-01-17  9:02       ` Alexandre Belloni
2014-01-17  9:38       ` Nicolas Ferre
2014-01-17  9:38         ` Nicolas Ferre
2014-01-16 14:08 ` Alexandre Belloni
2014-01-16 14:34   ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140117101456.GD2348@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=olof@lixom.net \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.