From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org
Subject: Randconfig build failure: screwed dependencies for phy-msm-usb.c
Date: Fri, 17 Jan 2014 13:22:32 +0000 [thread overview]
Message-ID: <20140117132232.GC15937@n2100.arm.linux.org.uk> (raw)
drivers/usb/phy/phy-msm-usb.c: In function 'msm_otg_runtime_suspend':
drivers/usb/phy/phy-msm-usb.c:1691:2: error: implicit declaration of function 'msm_otg_suspend'
drivers/usb/phy/phy-msm-usb.c: In function 'msm_otg_runtime_resume':
drivers/usb/phy/phy-msm-usb.c:1699:2: error: implicit declaration of function 'msm_otg_resume'
#ifdef CONFIG_PM_SLEEP
static int msm_otg_suspend(struct msm_otg *motg)
{
...
}
static int msm_otg_resume(struct msm_otg *motg)
{
...
}
#endif
...
#ifdef CONFIG_PM_RUNTIME
...
static int msm_otg_runtime_suspend(struct device *dev)
{
struct msm_otg *motg = dev_get_drvdata(dev);
dev_dbg(dev, "OTG runtime suspend\n");
return msm_otg_suspend(motg);
}
static int msm_otg_runtime_resume(struct device *dev)
{
struct msm_otg *motg = dev_get_drvdata(dev);
dev_dbg(dev, "OTG runtime resume\n");
return msm_otg_resume(motg);
}
#endif
So, if runtime PM is enabled, but PM sleep isn't, this fails as above.
If the msm_otg_* functions are required for runtime PM, they shouldn't
be conditional on CONfIG_PM_SLEEP.
--
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: Randconfig build failure: screwed dependencies for phy-msm-usb.c
Date: Fri, 17 Jan 2014 13:22:32 +0000 [thread overview]
Message-ID: <20140117132232.GC15937@n2100.arm.linux.org.uk> (raw)
drivers/usb/phy/phy-msm-usb.c: In function 'msm_otg_runtime_suspend':
drivers/usb/phy/phy-msm-usb.c:1691:2: error: implicit declaration of function 'msm_otg_suspend'
drivers/usb/phy/phy-msm-usb.c: In function 'msm_otg_runtime_resume':
drivers/usb/phy/phy-msm-usb.c:1699:2: error: implicit declaration of function 'msm_otg_resume'
#ifdef CONFIG_PM_SLEEP
static int msm_otg_suspend(struct msm_otg *motg)
{
...
}
static int msm_otg_resume(struct msm_otg *motg)
{
...
}
#endif
...
#ifdef CONFIG_PM_RUNTIME
...
static int msm_otg_runtime_suspend(struct device *dev)
{
struct msm_otg *motg = dev_get_drvdata(dev);
dev_dbg(dev, "OTG runtime suspend\n");
return msm_otg_suspend(motg);
}
static int msm_otg_runtime_resume(struct device *dev)
{
struct msm_otg *motg = dev_get_drvdata(dev);
dev_dbg(dev, "OTG runtime resume\n");
return msm_otg_resume(motg);
}
#endif
So, if runtime PM is enabled, but PM sleep isn't, this fails as above.
If the msm_otg_* functions are required for runtime PM, they shouldn't
be conditional on CONfIG_PM_SLEEP.
--
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".
next reply other threads:[~2014-01-17 13:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 13:22 Russell King - ARM Linux [this message]
2014-01-17 13:22 ` Randconfig build failure: screwed dependencies for phy-msm-usb.c Russell King - ARM Linux
2014-01-17 17:26 ` [PATCH] usb: phy: msm: fix compilation errors when !CONFIG_PM_SLEEP Josh Cartwright
2014-01-17 17:26 ` Josh Cartwright
2014-01-17 17:46 ` Christopher Covington
2014-01-17 17:46 ` Christopher Covington
2014-01-17 17:54 ` Kevin Hilman
2014-01-17 17:54 ` Kevin Hilman
[not found] ` <87lhyemr3y.fsf-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-01-17 17:58 ` [PATCH v2] " Josh Cartwright
2014-01-17 17:58 ` Josh Cartwright
2014-01-17 17:58 ` Josh Cartwright
2014-01-17 18:26 ` Josh Cartwright
2014-01-17 18:26 ` Josh Cartwright
2014-02-18 16:24 ` Felipe Balbi
2014-02-18 16:24 ` Felipe Balbi
2014-02-18 16:24 ` Felipe Balbi
[not found] ` <20140218162407.GF9878-HgARHv6XitL9zxVx7UNMDg@public.gmane.org>
2014-02-18 16:33 ` Josh Cartwright
2014-02-18 16:33 ` Josh Cartwright
2014-02-18 16:33 ` Josh Cartwright
2014-02-18 16:42 ` Felipe Balbi
2014-02-18 16:42 ` Felipe Balbi
2014-02-18 16:42 ` Felipe Balbi
2014-02-18 16:36 ` [PATCH RESEND v3] " Josh Cartwright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140117132232.GC15937@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.