From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 3/3] power: reset: use syscon driver to parse reboot register from scu
Date: Fri, 17 Jan 2014 17:52:46 +0100 [thread overview]
Message-ID: <201401171752.47393.arnd@arndb.de> (raw)
In-Reply-To: <1389748055-23534-4-git-send-email-fkan@apm.com>
On Wednesday 15 January 2014, Feng Kan wrote:
> +static int __init xgene_reboot_init(void)
> {
> arm_pm_restart = xgene_restart;
> return 0;
> }
> device_initcall(xgene_reboot_init);
This won't work on a generic kernel, since you unconditionally set the
pm_restart function to your own, which is broken for everything else.
Please keep the platform_driver to attach to the reboot device
as you had before. It might be good to turn this into a generic
"syscon-reset" driver that gets both the register number and
the contents to write from the device node.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Feng Kan <fkan@apm.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH V3 3/3] power: reset: use syscon driver to parse reboot register from scu
Date: Fri, 17 Jan 2014 17:52:46 +0100 [thread overview]
Message-ID: <201401171752.47393.arnd@arndb.de> (raw)
In-Reply-To: <1389748055-23534-4-git-send-email-fkan@apm.com>
On Wednesday 15 January 2014, Feng Kan wrote:
> +static int __init xgene_reboot_init(void)
> {
> arm_pm_restart = xgene_restart;
> return 0;
> }
> device_initcall(xgene_reboot_init);
This won't work on a generic kernel, since you unconditionally set the
pm_restart function to your own, which is broken for everything else.
Please keep the platform_driver to attach to the reboot device
as you had before. It might be good to turn this into a generic
"syscon-reset" driver that gets both the register number and
the contents to write from the device node.
Arnd
next prev parent reply other threads:[~2014-01-17 16:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 1:07 [PATCH V3 0/3] Enable X-Gene platform reboot driver Feng Kan
2014-01-15 1:07 ` Feng Kan
2014-01-15 1:07 ` [PATCH V3 1/3] arm64: add reboot dts entry for X-Gene platform Feng Kan
2014-01-15 1:07 ` Feng Kan
2014-01-15 1:07 ` [PATCH V3 2/3] arm64: Enable system reset via arch Kconfig for X-Gene system Feng Kan
2014-01-15 1:07 ` Feng Kan
2014-01-15 1:07 ` [PATCH V3 3/3] power: reset: use syscon driver to parse reboot register from scu Feng Kan
2014-01-15 1:07 ` Feng Kan
2014-01-17 16:52 ` Arnd Bergmann [this message]
2014-01-17 16:52 ` Arnd Bergmann
2014-01-17 16:59 ` Alexander Shiyan
2014-01-17 16:59 ` Alexander Shiyan
2014-01-17 16:59 ` Alexander Shiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201401171752.47393.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.