All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Mats Liljegren <mats.liljegren-AM1FMPraTHU@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v3 1/2] ethdev: Introduce if_index field to struct rte_eth_dev_info
Date: Fri, 17 Jan 2014 18:33:02 +0100	[thread overview]
Message-ID: <201401171833.02597.thomas.monjalon@6wind.com> (raw)
In-Reply-To: <1389274977-53532-2-git-send-email-liljegren.mats2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

what about this title?
"ethdev: introduce if_index in device info"

> This field is intended for pcap to describe the name of the interface
> as known to Linux. It is an interface index, but can be translated into
> an interface name using if_indextoname() function.
> 
> When using pcap, interrupt affinity becomes important, and this field
> gives the application a chance to ensure that interrupt affinity is set
> to the lcore handling the device.
> 
> Signed-off-by: Mats Liljegren <mats.liljegren-AM1FMPraTHU@public.gmane.org>
> 
[...]
> +	unsigned int if_index; /**< Index to bounded host interface, or 0 if
> none. Use if_indextoname() to translate into an interface name. */

I'd split this long line like this:
+	unsigned if_index; /**< Index to bounded host interface, or 0 if none.
+	         Use if_indextoname() to translate into an interface name. */

-- 
Thomas

  parent reply	other threads:[~2014-01-17 17:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-09 13:42 [PATCH v3 0/2] Introduce if_index field to struct rte_eth_dev_info liljegren.mats2-Re5JQEeQqe8AvxtiuMwx3w
     [not found] ` <1389274977-53532-1-git-send-email-liljegren.mats2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-01-09 13:42   ` [PATCH v3 1/2] ethdev: " liljegren.mats2-Re5JQEeQqe8AvxtiuMwx3w
     [not found]     ` <1389274977-53532-2-git-send-email-liljegren.mats2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-01-17 17:33       ` Thomas Monjalon [this message]
2014-01-09 13:42   ` [PATCH v3 2/2] pcap: Fill in if_index field for rte_eth_dev_info_get() liljegren.mats2-Re5JQEeQqe8AvxtiuMwx3w
     [not found]     ` <1389274977-53532-3-git-send-email-liljegren.mats2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-01-17 17:48       ` Thomas Monjalon
     [not found]         ` <201401171848.52284.thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-01-21  8:40           ` Mats Liljegren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201401171833.02597.thomas.monjalon@6wind.com \
    --to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=mats.liljegren-AM1FMPraTHU@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.