All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: aliguori@amazon.com
Cc: Bandan Das <bsd@redhat.com>, qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [PULL 2/7] vfio: warn if host device rom can't be read
Date: Fri, 17 Jan 2014 12:25:20 -0700	[thread overview]
Message-ID: <20140117192520.10456.74054.stgit@bling.home> (raw)
In-Reply-To: <20140117192252.10456.96113.stgit@bling.home>

From: Bandan Das <bsd@redhat.com>

If the device rom can't be read, report an error to the
user. This alerts the user that the device has a bad
state that is causing rom read failure or option rom
loading has been disabled from the device boot menu
(among other reasons).

Signed-off-by: Bandan Das <bsd@redhat.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
 hw/misc/vfio.c |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c
index ec9f41b..ef615fc 100644
--- a/hw/misc/vfio.c
+++ b/hw/misc/vfio.c
@@ -1125,6 +1125,13 @@ static void vfio_pci_load_rom(VFIODevice *vdev)
     vdev->rom_offset = reg_info.offset;
 
     if (!vdev->rom_size) {
+        error_report("vfio-pci: Cannot read device rom at "
+                    "%04x:%02x:%02x.%x\n",
+                    vdev->host.domain, vdev->host.bus, vdev->host.slot,
+                    vdev->host.function);
+        error_printf("Device option ROM contents are probably invalid "
+                    "(check dmesg).\nSkip option ROM probe with rombar=0, "
+                    "or load from file with romfile=\n");
         return;
     }
 


WARNING: multiple messages have this Message-ID (diff)
From: Alex Williamson <alex.williamson@redhat.com>
To: aliguori@amazon.com
Cc: Bandan Das <bsd@redhat.com>, qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [Qemu-devel] [PULL 2/7] vfio: warn if host device rom can't be read
Date: Fri, 17 Jan 2014 12:25:20 -0700	[thread overview]
Message-ID: <20140117192520.10456.74054.stgit@bling.home> (raw)
In-Reply-To: <20140117192252.10456.96113.stgit@bling.home>

From: Bandan Das <bsd@redhat.com>

If the device rom can't be read, report an error to the
user. This alerts the user that the device has a bad
state that is causing rom read failure or option rom
loading has been disabled from the device boot menu
(among other reasons).

Signed-off-by: Bandan Das <bsd@redhat.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
 hw/misc/vfio.c |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c
index ec9f41b..ef615fc 100644
--- a/hw/misc/vfio.c
+++ b/hw/misc/vfio.c
@@ -1125,6 +1125,13 @@ static void vfio_pci_load_rom(VFIODevice *vdev)
     vdev->rom_offset = reg_info.offset;
 
     if (!vdev->rom_size) {
+        error_report("vfio-pci: Cannot read device rom at "
+                    "%04x:%02x:%02x.%x\n",
+                    vdev->host.domain, vdev->host.bus, vdev->host.slot,
+                    vdev->host.function);
+        error_printf("Device option ROM contents are probably invalid "
+                    "(check dmesg).\nSkip option ROM probe with rombar=0, "
+                    "or load from file with romfile=\n");
         return;
     }
 

  parent reply	other threads:[~2014-01-17 19:25 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-17 19:25 [PULL 0/7] vfio pull request Alex Williamson
2014-01-17 19:25 ` [Qemu-devel] " Alex Williamson
2014-01-17 19:25 ` [PULL 1/7] vfio: Destroy memory regions Alex Williamson
2014-01-17 19:25   ` [Qemu-devel] " Alex Williamson
2014-01-17 19:25 ` Alex Williamson [this message]
2014-01-17 19:25   ` [Qemu-devel] [PULL 2/7] vfio: warn if host device rom can't be read Alex Williamson
2014-01-17 19:25 ` [PULL 3/7] vfio: Do not reattempt a failed rom read Alex Williamson
2014-01-17 19:25   ` [Qemu-devel] " Alex Williamson
2014-01-17 19:25 ` [PULL 4/7] vfio: Filter out bogus mappings Alex Williamson
2014-01-17 19:25   ` [Qemu-devel] " Alex Williamson
2014-01-17 19:25 ` [PULL 5/7] vfio-pci: Fail initfn on DMA mapping errors Alex Williamson
2014-01-17 19:25   ` [Qemu-devel] " Alex Williamson
2014-01-17 19:25 ` [PULL 6/7] kvm: initialize qemu_host_page_size Alex Williamson
2014-01-17 19:25   ` [Qemu-devel] " Alex Williamson
2014-01-17 19:25 ` [PULL 7/7] vfio: fix mapping of MSIX bar Alex Williamson
2014-01-17 19:25   ` [Qemu-devel] " Alex Williamson
2014-01-19 14:03   ` Kai Huang
2014-01-19 14:03     ` [Qemu-devel] " Kai Huang
2014-01-19 14:11     ` Alex Williamson
2014-01-19 14:11       ` [Qemu-devel] " Alex Williamson
2014-01-19 15:46       ` Kai Huang
2014-01-19 15:46         ` [Qemu-devel] " Kai Huang
2014-01-19 16:59         ` Alex Williamson
2014-01-19 16:59           ` [Qemu-devel] " Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140117192520.10456.74054.stgit@bling.home \
    --to=alex.williamson@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=bsd@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.