From: Mike Turquette <mturquette@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kbuild-all@01.org
Subject: Re: [PATCH] clk: qcom: Fix modular build
Date: Fri, 17 Jan 2014 13:40:03 -0800 [thread overview]
Message-ID: <20140117214003.4167.53304@quantum> (raw)
In-Reply-To: <1389989380-17441-1-git-send-email-sboyd@codeaurora.org>
Quoting Stephen Boyd (2014-01-17 12:09:40)
> According to Documentation/kbuild/makefiles.txt these symbols
> should be clk-qcom-y. Otherwise the build will fail if
> CONFIG_COMMON_CLK_QCOM=m. Fix it.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Taken into clk-next.
Regards,
Mike
> ---
> drivers/clk/qcom/Makefile | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/clk/qcom/Makefile b/drivers/clk/qcom/Makefile
> index 190d38433202..f60db2ef1aee 100644
> --- a/drivers/clk/qcom/Makefile
> +++ b/drivers/clk/qcom/Makefile
> @@ -1,11 +1,11 @@
> obj-$(CONFIG_COMMON_CLK_QCOM) += clk-qcom.o
>
> -clk-qcom-$(CONFIG_COMMON_CLK_QCOM) += clk-regmap.o
> -clk-qcom-$(CONFIG_COMMON_CLK_QCOM) += clk-pll.o
> -clk-qcom-$(CONFIG_COMMON_CLK_QCOM) += clk-rcg.o
> -clk-qcom-$(CONFIG_COMMON_CLK_QCOM) += clk-rcg2.o
> -clk-qcom-$(CONFIG_COMMON_CLK_QCOM) += clk-branch.o
> -clk-qcom-$(CONFIG_COMMON_CLK_QCOM) += reset.o
> +clk-qcom-y += clk-regmap.o
> +clk-qcom-y += clk-pll.o
> +clk-qcom-y += clk-rcg.o
> +clk-qcom-y += clk-rcg2.o
> +clk-qcom-y += clk-branch.o
> +clk-qcom-y += reset.o
>
> obj-$(CONFIG_MSM_GCC_8660) += gcc-msm8660.o
> obj-$(CONFIG_MSM_GCC_8960) += gcc-msm8960.o
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
>
WARNING: multiple messages have this Message-ID (diff)
From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: qcom: Fix modular build
Date: Fri, 17 Jan 2014 13:40:03 -0800 [thread overview]
Message-ID: <20140117214003.4167.53304@quantum> (raw)
In-Reply-To: <1389989380-17441-1-git-send-email-sboyd@codeaurora.org>
Quoting Stephen Boyd (2014-01-17 12:09:40)
> According to Documentation/kbuild/makefiles.txt these symbols
> should be clk-qcom-y. Otherwise the build will fail if
> CONFIG_COMMON_CLK_QCOM=m. Fix it.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Taken into clk-next.
Regards,
Mike
> ---
> drivers/clk/qcom/Makefile | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/clk/qcom/Makefile b/drivers/clk/qcom/Makefile
> index 190d38433202..f60db2ef1aee 100644
> --- a/drivers/clk/qcom/Makefile
> +++ b/drivers/clk/qcom/Makefile
> @@ -1,11 +1,11 @@
> obj-$(CONFIG_COMMON_CLK_QCOM) += clk-qcom.o
>
> -clk-qcom-$(CONFIG_COMMON_CLK_QCOM) += clk-regmap.o
> -clk-qcom-$(CONFIG_COMMON_CLK_QCOM) += clk-pll.o
> -clk-qcom-$(CONFIG_COMMON_CLK_QCOM) += clk-rcg.o
> -clk-qcom-$(CONFIG_COMMON_CLK_QCOM) += clk-rcg2.o
> -clk-qcom-$(CONFIG_COMMON_CLK_QCOM) += clk-branch.o
> -clk-qcom-$(CONFIG_COMMON_CLK_QCOM) += reset.o
> +clk-qcom-y += clk-regmap.o
> +clk-qcom-y += clk-pll.o
> +clk-qcom-y += clk-rcg.o
> +clk-qcom-y += clk-rcg2.o
> +clk-qcom-y += clk-branch.o
> +clk-qcom-y += reset.o
>
> obj-$(CONFIG_MSM_GCC_8660) += gcc-msm8660.o
> obj-$(CONFIG_MSM_GCC_8960) += gcc-msm8960.o
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
>
next prev parent reply other threads:[~2014-01-17 21:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <52d8dde8.Mqtb7njO7G6foYTt%fengguang.wu@intel.com>
2014-01-17 20:09 ` [PATCH] clk: qcom: Fix modular build Stephen Boyd
2014-01-17 20:09 ` Stephen Boyd
2014-01-17 21:40 ` Mike Turquette [this message]
2014-01-17 21:40 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140117214003.4167.53304@quantum \
--to=mturquette@linaro.org \
--cc=kbuild-all@01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.