All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 01/10] eigen: add C++ toolchain dependency
Date: Sat, 18 Jan 2014 20:49:21 +0100	[thread overview]
Message-ID: <20140118194921.GA23411@free.fr> (raw)
In-Reply-To: <1390073027-14239-2-git-send-email-s.martin49@gmail.com>

Samuel, All,

On 2014-01-18 20:23 +0100, Samuel Martin spake thusly:
> As said in its help text, eigen heavily uses C++ features.
> So, explicit this dependency in the Config.in.
> 
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
> changes v1 -> v2:
> - add Reviewed-by tag
> ---
>  package/eigen/Config.in | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/eigen/Config.in b/package/eigen/Config.in
> index c7fcde2..e94f9a3 100644
> --- a/package/eigen/Config.in
> +++ b/package/eigen/Config.in
> @@ -1,5 +1,6 @@
>  config BR2_PACKAGE_EIGEN
>  	bool "eigen"
> +	depends on BR2_INSTALL_LIBSTDCPP
>  	help
>  	  Eigen is a C++ template library for linear algebra: vectors,
>  	  matrices, and related algorithms. It is versatile, fast, elegant
> @@ -11,3 +12,6 @@ config BR2_PACKAGE_EIGEN
>  	  template library defined in the headers.
>  
>  	  http://eigen.tuxfamily.org/
> +
> +comment "eigen needs a toolchain w/ C++"
> +	depends on !BR2_INSTALL_LIBSTDCPP
> -- 
> 1.8.5.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-01-18 19:49 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-18 19:23 [Buildroot] [PATCH 00/10] Misc fixes Samuel Martin
2014-01-18 19:23 ` [Buildroot] [PATCH 01/10] eigen: add C++ toolchain dependency Samuel Martin
2014-01-18 19:49   ` Yann E. MORIN [this message]
2014-01-19 20:16   ` Peter Korsgaard
2014-01-18 19:23 ` [Buildroot] [PATCH 02/10] transmission: add url in Config.in Samuel Martin
2014-01-18 19:50   ` Yann E. MORIN
2014-01-19 20:16   ` Peter Korsgaard
2014-01-18 19:23 ` [Buildroot] [PATCH 03/10] transmission: use <PKG>_INSTALL_INIT_SYSV infra instead of custom hook Samuel Martin
2014-01-18 19:52   ` Yann E. MORIN
2014-01-19 20:19   ` Peter Korsgaard
2014-01-18 19:23 ` [Buildroot] [PATCH 04/10] pkg-cmake.mk: build shared library when !BR2_PREFER_STATIC_LIB Samuel Martin
2014-01-19 20:28   ` Peter Korsgaard
2014-01-24  0:08   ` Yann E. MORIN
2014-01-18 19:23 ` [Buildroot] [PATCH 05/10] qt: add an option to install the test module Samuel Martin
2014-02-11 20:06   ` Samuel Martin
2014-01-18 19:23 ` [Buildroot] [PATCH 06/10] opencv: fix qt selection when highgui is enable Samuel Martin
2014-02-11 20:07   ` Samuel Martin
2014-01-18 19:23 ` [Buildroot] [PATCH 07/10] connman: add systemd unit file Samuel Martin
2014-01-18 19:56   ` Yann E. MORIN
2014-01-18 22:19   ` Lucas De Marchi
2014-01-18 19:23 ` [Buildroot] [PATCH 08/10] support: mkusers: add warning when using mkpasswd from the host system Samuel Martin
2014-01-19 20:29   ` Peter Korsgaard
2014-01-19 21:29     ` Yann E. MORIN
2014-01-18 19:23 ` [Buildroot] [PATCH 09/10] urg: make sdl support optional Samuel Martin
2014-01-18 20:00   ` Yann E. MORIN
2014-01-19 20:31   ` Peter Korsgaard
2014-01-18 19:23 ` [Buildroot] [PATCH 10/10] hostapd: fix static build failure Samuel Martin
2014-01-18 20:05   ` Yann E. MORIN
2014-02-10 11:53     ` Samuel Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140118194921.GA23411@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.