All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 09/10] urg: make sdl support optional
Date: Sat, 18 Jan 2014 21:00:31 +0100	[thread overview]
Message-ID: <20140118200031.GE23411@free.fr> (raw)
In-Reply-To: <1390073027-14239-10-git-send-email-s.martin49@gmail.com>

Samuel, All,

On 2014-01-18 20:23 +0100, Samuel Martin spake thusly:
> Only enable SDL support if SDL and SDL_net are already enabled in the
> configuration.
> 
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

However, I have a comment, see below...

> ---
>  package/urg/Config.in |  5 ++---
>  package/urg/urg.mk    | 10 +++++++---
>  2 files changed, 9 insertions(+), 6 deletions(-)
> 
> diff --git a/package/urg/Config.in b/package/urg/Config.in
> index ded8204..232f4c4 100644
> --- a/package/urg/Config.in
> +++ b/package/urg/Config.in
> @@ -1,11 +1,10 @@
>  config BR2_PACKAGE_URG
>  	bool "urg"
>  	depends on BR2_INSTALL_LIBSTDCPP
> -	select BR2_PACKAGE_SDL
> -	select BR2_PACKAGE_SDL_NET
>  	help
>  	  Library to control Hokuyo's URG series sensors.
> -	  Requires SDL & SDL_net.
> +
> +	  If SDL and SDL_net are enable, SDL support will be automatically added.

I don't think we systematically add such info in the help entries.
I wonder if we should.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-01-18 20:00 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-18 19:23 [Buildroot] [PATCH 00/10] Misc fixes Samuel Martin
2014-01-18 19:23 ` [Buildroot] [PATCH 01/10] eigen: add C++ toolchain dependency Samuel Martin
2014-01-18 19:49   ` Yann E. MORIN
2014-01-19 20:16   ` Peter Korsgaard
2014-01-18 19:23 ` [Buildroot] [PATCH 02/10] transmission: add url in Config.in Samuel Martin
2014-01-18 19:50   ` Yann E. MORIN
2014-01-19 20:16   ` Peter Korsgaard
2014-01-18 19:23 ` [Buildroot] [PATCH 03/10] transmission: use <PKG>_INSTALL_INIT_SYSV infra instead of custom hook Samuel Martin
2014-01-18 19:52   ` Yann E. MORIN
2014-01-19 20:19   ` Peter Korsgaard
2014-01-18 19:23 ` [Buildroot] [PATCH 04/10] pkg-cmake.mk: build shared library when !BR2_PREFER_STATIC_LIB Samuel Martin
2014-01-19 20:28   ` Peter Korsgaard
2014-01-24  0:08   ` Yann E. MORIN
2014-01-18 19:23 ` [Buildroot] [PATCH 05/10] qt: add an option to install the test module Samuel Martin
2014-02-11 20:06   ` Samuel Martin
2014-01-18 19:23 ` [Buildroot] [PATCH 06/10] opencv: fix qt selection when highgui is enable Samuel Martin
2014-02-11 20:07   ` Samuel Martin
2014-01-18 19:23 ` [Buildroot] [PATCH 07/10] connman: add systemd unit file Samuel Martin
2014-01-18 19:56   ` Yann E. MORIN
2014-01-18 22:19   ` Lucas De Marchi
2014-01-18 19:23 ` [Buildroot] [PATCH 08/10] support: mkusers: add warning when using mkpasswd from the host system Samuel Martin
2014-01-19 20:29   ` Peter Korsgaard
2014-01-19 21:29     ` Yann E. MORIN
2014-01-18 19:23 ` [Buildroot] [PATCH 09/10] urg: make sdl support optional Samuel Martin
2014-01-18 20:00   ` Yann E. MORIN [this message]
2014-01-19 20:31   ` Peter Korsgaard
2014-01-18 19:23 ` [Buildroot] [PATCH 10/10] hostapd: fix static build failure Samuel Martin
2014-01-18 20:05   ` Yann E. MORIN
2014-02-10 11:53     ` Samuel Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140118200031.GE23411@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.