From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: export __clk_get_hw for re-use in others
Date: Sun, 19 Jan 2014 09:37:12 -0800 [thread overview]
Message-ID: <20140119173712.GA26481@kroah.com> (raw)
In-Reply-To: <1390110907-29918-1-git-send-email-sj38.park@gmail.com>
On Sun, Jan 19, 2014 at 02:55:07PM +0900, SeongJae Park wrote:
> Following build comes while modprobe process:
> > ERROR: "__clk_get_hw" [drivers/clk/clk-max77686.ko] undefined!
> > make[2]: *** [__modpost] Error 1
> > make[1]: *** [modules] Error 2
>
> Export the symbol to fix it and for other part's usecase.
>
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
> ---
> drivers/clk/clk.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 2b38dc9..3883fba 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -575,6 +575,7 @@ struct clk_hw *__clk_get_hw(struct clk *clk)
> {
> return !clk ? NULL : clk->hw;
> }
> +EXPORT_SYMBOL_GPL(__clk_get_hw);
__ functions should usually only be for "internal" use, why does this
get exported to modules? Why not just put it in a .h file?
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: SeongJae Park <sj38.park@gmail.com>
Cc: mturquette@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: export __clk_get_hw for re-use in others
Date: Sun, 19 Jan 2014 09:37:12 -0800 [thread overview]
Message-ID: <20140119173712.GA26481@kroah.com> (raw)
In-Reply-To: <1390110907-29918-1-git-send-email-sj38.park@gmail.com>
On Sun, Jan 19, 2014 at 02:55:07PM +0900, SeongJae Park wrote:
> Following build comes while modprobe process:
> > ERROR: "__clk_get_hw" [drivers/clk/clk-max77686.ko] undefined!
> > make[2]: *** [__modpost] Error 1
> > make[1]: *** [modules] Error 2
>
> Export the symbol to fix it and for other part's usecase.
>
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
> ---
> drivers/clk/clk.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 2b38dc9..3883fba 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -575,6 +575,7 @@ struct clk_hw *__clk_get_hw(struct clk *clk)
> {
> return !clk ? NULL : clk->hw;
> }
> +EXPORT_SYMBOL_GPL(__clk_get_hw);
__ functions should usually only be for "internal" use, why does this
get exported to modules? Why not just put it in a .h file?
greg k-h
next prev parent reply other threads:[~2014-01-19 17:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-19 5:55 [PATCH] clk: export __clk_get_hw for re-use in others SeongJae Park
2014-01-19 5:55 ` SeongJae Park
2014-01-19 17:37 ` Greg KH [this message]
2014-01-19 17:37 ` Greg KH
2014-01-20 7:47 ` Mike Turquette
2014-01-20 7:47 ` Mike Turquette
2014-01-20 8:07 ` SeongJae Park
2014-01-20 8:07 ` SeongJae Park
2014-01-22 3:05 ` SeongJae Park
2014-01-22 3:05 ` SeongJae Park
2014-01-22 4:59 ` Greg KH
2014-01-22 4:59 ` Greg KH
2014-01-22 5:23 ` SeongJae Park
2014-01-22 5:23 ` SeongJae Park
2014-01-22 17:59 ` Stephen Boyd
2014-01-22 17:59 ` Stephen Boyd
2014-01-22 18:11 ` Mike Turquette
2014-01-22 18:11 ` Mike Turquette
2014-01-23 2:05 ` SeongJae Park
2014-01-23 2:05 ` SeongJae Park
2014-01-29 7:29 ` David Rientjes
2014-01-29 7:29 ` David Rientjes
2014-01-29 8:13 ` SeongJae Park
2014-01-29 8:13 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140119173712.GA26481@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.