All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Olof Johansson <olof@lixom.net>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	linux-pwm@vger.kernel.org, "arm@kernel.org" <arm@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: PWM...
Date: Sun, 19 Jan 2014 21:26:40 +0100	[thread overview]
Message-ID: <201401192126.41543.arnd@arndb.de> (raw)
In-Reply-To: <20140119193026.GS15937@n2100.arm.linux.org.uk>

On Sunday 19 January 2014, Russell King - ARM Linux wrote:
> On Sun, Jan 19, 2014 at 11:11:41AM -0800, Olof Johansson wrote:
> > On Sun, Jan 19, 2014 at 11:08 AM, Arnd Bergmann <arnd@arndb.de> wrote:

> > Ah, yes, if you add a cell that can be done. There'll still be the
> > "dead" first cell that will always be 0, but that's alright.
> 
> Does it not mean that PWM specifications of:
> 
>         <&pwm1 0 n> <&pwm2 0 n>
> 
> would need to be converted to:
> 
>         <&pwm1 0 n 0> <&pwm2 0 n 0>
> 
> in every DT file referring to these PWMs - because isn't this just
> treated in DT as one single array of values?  (If DT knew how many
> were in each specification, we wouldn't need the #foo-cells...)

Right: if you change an existing dts file from #pwm-cells=<2> to
#pwm-cells=<3>, that requires changing all references to the pwm
controller at the same time. If both the per-soc .dtsi files
and the per-board .dts files contain references to the same pwm
controller, that can end up in significant work. I have not checked
if this is the case for i.MX though.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: PWM...
Date: Sun, 19 Jan 2014 21:26:40 +0100	[thread overview]
Message-ID: <201401192126.41543.arnd@arndb.de> (raw)
In-Reply-To: <20140119193026.GS15937@n2100.arm.linux.org.uk>

On Sunday 19 January 2014, Russell King - ARM Linux wrote:
> On Sun, Jan 19, 2014 at 11:11:41AM -0800, Olof Johansson wrote:
> > On Sun, Jan 19, 2014 at 11:08 AM, Arnd Bergmann <arnd@arndb.de> wrote:

> > Ah, yes, if you add a cell that can be done. There'll still be the
> > "dead" first cell that will always be 0, but that's alright.
> 
> Does it not mean that PWM specifications of:
> 
>         <&pwm1 0 n> <&pwm2 0 n>
> 
> would need to be converted to:
> 
>         <&pwm1 0 n 0> <&pwm2 0 n 0>
> 
> in every DT file referring to these PWMs - because isn't this just
> treated in DT as one single array of values?  (If DT knew how many
> were in each specification, we wouldn't need the #foo-cells...)

Right: if you change an existing dts file from #pwm-cells=<2> to
#pwm-cells=<3>, that requires changing all references to the pwm
controller at the same time. If both the per-soc .dtsi files
and the per-board .dts files contain references to the same pwm
controller, that can end up in significant work. I have not checked
if this is the case for i.MX though.

	Arnd

  reply	other threads:[~2014-01-19 20:26 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-19 16:49 PWM Russell King - ARM Linux
2014-01-19 16:49 ` PWM Russell King - ARM Linux
2014-01-19 19:03 ` PWM Olof Johansson
2014-01-19 19:03   ` PWM Olof Johansson
2014-01-19 19:08   ` PWM Arnd Bergmann
2014-01-19 19:08     ` PWM Arnd Bergmann
2014-01-19 19:11     ` PWM Olof Johansson
2014-01-19 19:11       ` PWM Olof Johansson
2014-01-19 19:30       ` PWM Russell King - ARM Linux
2014-01-19 19:30         ` PWM Russell King - ARM Linux
2014-01-19 20:26         ` Arnd Bergmann [this message]
2014-01-19 20:26           ` PWM Arnd Bergmann
2014-01-19 23:33           ` PWM Olof Johansson
2014-01-19 23:33             ` PWM Olof Johansson
2014-01-20  0:14           ` PWM Simon Horman
2014-01-20  0:14             ` PWM Simon Horman
2014-01-20  7:24             ` PWM Sascha Hauer
2014-01-20  7:24               ` PWM Sascha Hauer
2014-01-20 16:11             ` PWM Mark Brown
2014-01-20 16:11               ` PWM Mark Brown
2014-01-21  0:39               ` PWM Simon Horman
2014-01-21  0:39                 ` PWM Simon Horman
2014-01-20  7:21   ` PWM Sascha Hauer
2014-01-20  7:21     ` PWM Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201401192126.41543.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=arm@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=olof@lixom.net \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.