All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Majewski <l.majewski@samsung.com>
To: Thomas Abraham <ta.omasab@gmail.com>
Cc: cpufreq@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, mturquette@linaro.org,
	shawn.guo@linaro.org, kgene.kim@samsung.com, t.figa@samsung.com,
	viresh.kumar@linaro.org, thomas.ab@samsung.com
Subject: Re: [PATCH v2 6/7] ARM: Exynos: switch to using generic cpufreq-cpu0 driver
Date: Mon, 20 Jan 2014 08:48:14 +0100	[thread overview]
Message-ID: <20140120084814.220a8efa@amdc2363> (raw)
In-Reply-To: <1390047057-2239-7-git-send-email-thomas.ab@samsung.com>

Hi Thomas,

> From: Thomas Abraham <thomas.ab@samsung.com>
> 
> Remove the platform device instantiation for Exynos specific cpufreq
> driver and add the platform device for cpufreq-cpu0 driver.
> 
> Cc: Kukjin Kim <kgene.kim@samsung.com>
> Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
> ---
>  arch/arm/mach-exynos/common.c          |    5 -----
>  arch/arm/mach-exynos/common.h          |    1 -
>  arch/arm/mach-exynos/mach-exynos4-dt.c |    2 +-
>  arch/arm/mach-exynos/mach-exynos5-dt.c |    2 +-
>  4 files changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos/common.c
> b/arch/arm/mach-exynos/common.c index f18be40..72ae5d3 100644
> --- a/arch/arm/mach-exynos/common.c
> +++ b/arch/arm/mach-exynos/common.c
> @@ -303,11 +303,6 @@ void __init exynos_cpuidle_init(void)
>  	platform_device_register(&exynos_cpuidle);
>  }
>  
> -void __init exynos_cpufreq_init(void)
> -{
> -	platform_device_register_simple("exynos-cpufreq", -1, NULL,
> 0); -}
> -
>  void __init exynos_init_late(void)
>  {
>  	if (of_machine_is_compatible("samsung,exynos5440"))
> diff --git a/arch/arm/mach-exynos/common.h
> b/arch/arm/mach-exynos/common.h index f76967b..0c31b34 100644
> --- a/arch/arm/mach-exynos/common.h
> +++ b/arch/arm/mach-exynos/common.h
> @@ -22,7 +22,6 @@ void exynos_init_io(void);
>  void exynos4_restart(enum reboot_mode mode, const char *cmd);
>  void exynos5_restart(enum reboot_mode mode, const char *cmd);
>  void exynos_cpuidle_init(void);
> -void exynos_cpufreq_init(void);
>  void exynos_init_late(void);
>  
>  void exynos_firmware_init(void);
> diff --git a/arch/arm/mach-exynos/mach-exynos4-dt.c
> b/arch/arm/mach-exynos/mach-exynos4-dt.c index d3e54b7..9a25320 100644
> --- a/arch/arm/mach-exynos/mach-exynos4-dt.c
> +++ b/arch/arm/mach-exynos/mach-exynos4-dt.c
> @@ -22,8 +22,8 @@
>  static void __init exynos4_dt_machine_init(void)
>  {
>  	exynos_cpuidle_init();
> -	exynos_cpufreq_init();
>  
> +	platform_device_register_simple("cpufreq-cpu0", -1, NULL, 0);
>  	of_platform_populate(NULL, of_default_bus_match_table, NULL,
> NULL); }
>  
> diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c
> b/arch/arm/mach-exynos/mach-exynos5-dt.c index 37ea261..9dc3710 100644
> --- a/arch/arm/mach-exynos/mach-exynos5-dt.c
> +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c
> @@ -44,8 +44,8 @@ static void __init exynos5_dt_machine_init(void)
>  	}
>  
>  	exynos_cpuidle_init();
> -	exynos_cpufreq_init();
>  
> +	platform_device_register_simple("cpufreq-cpu0", -1, NULL, 0);
>  	of_platform_populate(NULL, of_default_bus_match_table, NULL,
> NULL); }
>  

Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

WARNING: multiple messages have this Message-ID (diff)
From: l.majewski@samsung.com (Lukasz Majewski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 6/7] ARM: Exynos: switch to using generic cpufreq-cpu0 driver
Date: Mon, 20 Jan 2014 08:48:14 +0100	[thread overview]
Message-ID: <20140120084814.220a8efa@amdc2363> (raw)
In-Reply-To: <1390047057-2239-7-git-send-email-thomas.ab@samsung.com>

Hi Thomas,

> From: Thomas Abraham <thomas.ab@samsung.com>
> 
> Remove the platform device instantiation for Exynos specific cpufreq
> driver and add the platform device for cpufreq-cpu0 driver.
> 
> Cc: Kukjin Kim <kgene.kim@samsung.com>
> Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
> ---
>  arch/arm/mach-exynos/common.c          |    5 -----
>  arch/arm/mach-exynos/common.h          |    1 -
>  arch/arm/mach-exynos/mach-exynos4-dt.c |    2 +-
>  arch/arm/mach-exynos/mach-exynos5-dt.c |    2 +-
>  4 files changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos/common.c
> b/arch/arm/mach-exynos/common.c index f18be40..72ae5d3 100644
> --- a/arch/arm/mach-exynos/common.c
> +++ b/arch/arm/mach-exynos/common.c
> @@ -303,11 +303,6 @@ void __init exynos_cpuidle_init(void)
>  	platform_device_register(&exynos_cpuidle);
>  }
>  
> -void __init exynos_cpufreq_init(void)
> -{
> -	platform_device_register_simple("exynos-cpufreq", -1, NULL,
> 0); -}
> -
>  void __init exynos_init_late(void)
>  {
>  	if (of_machine_is_compatible("samsung,exynos5440"))
> diff --git a/arch/arm/mach-exynos/common.h
> b/arch/arm/mach-exynos/common.h index f76967b..0c31b34 100644
> --- a/arch/arm/mach-exynos/common.h
> +++ b/arch/arm/mach-exynos/common.h
> @@ -22,7 +22,6 @@ void exynos_init_io(void);
>  void exynos4_restart(enum reboot_mode mode, const char *cmd);
>  void exynos5_restart(enum reboot_mode mode, const char *cmd);
>  void exynos_cpuidle_init(void);
> -void exynos_cpufreq_init(void);
>  void exynos_init_late(void);
>  
>  void exynos_firmware_init(void);
> diff --git a/arch/arm/mach-exynos/mach-exynos4-dt.c
> b/arch/arm/mach-exynos/mach-exynos4-dt.c index d3e54b7..9a25320 100644
> --- a/arch/arm/mach-exynos/mach-exynos4-dt.c
> +++ b/arch/arm/mach-exynos/mach-exynos4-dt.c
> @@ -22,8 +22,8 @@
>  static void __init exynos4_dt_machine_init(void)
>  {
>  	exynos_cpuidle_init();
> -	exynos_cpufreq_init();
>  
> +	platform_device_register_simple("cpufreq-cpu0", -1, NULL, 0);
>  	of_platform_populate(NULL, of_default_bus_match_table, NULL,
> NULL); }
>  
> diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c
> b/arch/arm/mach-exynos/mach-exynos5-dt.c index 37ea261..9dc3710 100644
> --- a/arch/arm/mach-exynos/mach-exynos5-dt.c
> +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c
> @@ -44,8 +44,8 @@ static void __init exynos5_dt_machine_init(void)
>  	}
>  
>  	exynos_cpuidle_init();
> -	exynos_cpufreq_init();
>  
> +	platform_device_register_simple("cpufreq-cpu0", -1, NULL, 0);
>  	of_platform_populate(NULL, of_default_bus_match_table, NULL,
> NULL); }
>  

Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

  reply	other threads:[~2014-01-20  7:48 UTC|newest]

Thread overview: 103+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-18 12:10 [PATCH v2 0/7] cpufreq: use cpufreq-cpu0 driver for exynos based platforms Thomas Abraham
2014-01-18 12:10 ` Thomas Abraham
2014-01-18 12:10 ` [PATCH v2 1/7] cpufreq: cpufreq-cpu0: allow optional safe voltage during frequency transitions Thomas Abraham
2014-01-18 12:10   ` Thomas Abraham
2014-01-20  8:09   ` Lukasz Majewski
2014-01-20  8:09     ` Lukasz Majewski
2014-01-27  7:16   ` Shawn Guo
2014-01-27  7:16     ` Shawn Guo
2014-01-28  4:30     ` Thomas Abraham
2014-01-28  4:30       ` Thomas Abraham
2014-01-27 20:25   ` Mike Turquette
2014-01-27 20:25     ` Mike Turquette
2014-01-28  5:30     ` Thomas Abraham
2014-01-28  5:30       ` Thomas Abraham
2014-01-28  8:17       ` Lukasz Majewski
2014-01-28  8:17         ` Lukasz Majewski
2014-01-28 11:36         ` Thomas Abraham
2014-01-28 11:36           ` Thomas Abraham
2014-01-28 15:06           ` Lukasz Majewski
2014-01-28 15:06             ` Lukasz Majewski
2014-01-28 15:15             ` Thomas Abraham
2014-01-28 15:15               ` Thomas Abraham
2014-01-28 11:49       ` Shawn Guo
2014-01-28 11:49         ` Shawn Guo
2014-01-28 12:47         ` Thomas Abraham
2014-01-28 12:47           ` Thomas Abraham
2014-01-28 18:47       ` Mike Turquette
2014-01-28 18:47         ` Mike Turquette
2014-01-30 12:53         ` Thomas Abraham
2014-01-30 12:53           ` Thomas Abraham
2014-01-30 15:09           ` Heiko Stübner
2014-01-30 15:09             ` Heiko Stübner
2014-02-01  4:10             ` Mike Turquette
2014-02-01  4:10               ` Mike Turquette
2014-02-01  4:10               ` Mike Turquette
2014-02-03 16:06               ` Thomas Abraham
2014-02-03 16:06                 ` Thomas Abraham
2014-02-05  9:53               ` Heiko Stübner
2014-02-05  9:53                 ` Heiko Stübner
2014-02-03 16:06             ` Thomas Abraham
2014-02-03 16:06               ` Thomas Abraham
2014-01-18 12:10 ` [PATCH v2 2/7] clk: samsung: add infrastructure to register cpu clocks Thomas Abraham
2014-01-18 12:10   ` Thomas Abraham
2014-01-20  8:24   ` Lukasz Majewski
2014-01-20  8:24     ` Lukasz Majewski
2014-01-21  8:35     ` Thomas Abraham
2014-01-21  8:35       ` Thomas Abraham
2014-01-21 10:25       ` Lukasz Majewski
2014-01-21 10:25         ` Lukasz Majewski
2014-01-21 10:38         ` Thomas Abraham
2014-01-21 10:38           ` Thomas Abraham
2014-01-21 10:59           ` Lukasz Majewski
2014-01-21 10:59             ` Lukasz Majewski
2014-01-18 12:10 ` [PATCH v2 3/7] devicetree: bindings: add cpu clock configuration data binding for Exynos4/5 Thomas Abraham
2014-01-18 12:10   ` Thomas Abraham
2014-01-18 15:22   ` Rob Herring
2014-01-18 15:22     ` Rob Herring
2014-01-21  7:31     ` Thomas Abraham
2014-01-21  7:31       ` Thomas Abraham
2014-01-24 15:24       ` Thomas Abraham
2014-01-24 15:24         ` Thomas Abraham
2014-01-18 12:10 ` [PATCH v2 4/7] ARM: dts: Exynos: add cpu nodes, opp and cpu clock frequency table Thomas Abraham
2014-01-18 12:10   ` Thomas Abraham
2014-01-20  7:32   ` Lukasz Majewski
2014-01-20  7:32     ` Lukasz Majewski
2014-01-21  7:33     ` Thomas Abraham
2014-01-21  7:33       ` Thomas Abraham
2014-01-18 12:10 ` [PATCH v2 5/7] clk: exynos: use cpu-clock provider type to represent arm clock Thomas Abraham
2014-01-18 12:10   ` Thomas Abraham
2014-01-20  7:47   ` Lukasz Majewski
2014-01-20  7:47     ` Lukasz Majewski
2014-01-21  7:52     ` Thomas Abraham
2014-01-21  7:52       ` Thomas Abraham
2014-01-21 10:38       ` Lukasz Majewski
2014-01-21 10:38         ` Lukasz Majewski
2014-01-21 11:15         ` Thomas Abraham
2014-01-21 11:15           ` Thomas Abraham
2014-01-21 11:42           ` Lukasz Majewski
2014-01-21 11:42             ` Lukasz Majewski
2014-01-18 12:10 ` [PATCH v2 6/7] ARM: Exynos: switch to using generic cpufreq-cpu0 driver Thomas Abraham
2014-01-18 12:10   ` Thomas Abraham
2014-01-20  7:48   ` Lukasz Majewski [this message]
2014-01-20  7:48     ` Lukasz Majewski
2014-01-18 12:10 ` [PATCH v2 7/7] cpufreq: exynos: remove all exynos specific cpufreq driver support Thomas Abraham
2014-01-18 12:10   ` Thomas Abraham
2014-01-20  8:08   ` Lukasz Majewski
2014-01-20  8:08     ` Lukasz Majewski
2014-01-21  8:08     ` Thomas Abraham
2014-01-21  8:08       ` Thomas Abraham
2014-01-21  8:27       ` Lukasz Majewski
2014-01-21  8:27         ` Lukasz Majewski
2014-02-05 10:21     ` Thomas Abraham
2014-02-05 10:21       ` Thomas Abraham
2014-02-05 11:44       ` Lukasz Majewski
2014-02-05 11:44         ` Lukasz Majewski
2014-02-05 12:43         ` Thomas Abraham
2014-02-05 12:43           ` Thomas Abraham
2014-02-05 13:15           ` Lukasz Majewski
2014-02-05 13:15             ` Lukasz Majewski
2014-02-05 13:36           ` Nishanth Menon
2014-02-05 13:36             ` Nishanth Menon
2014-02-05 13:49             ` Lukasz Majewski
2014-02-05 13:49               ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140120084814.220a8efa@amdc2363 \
    --to=l.majewski@samsung.com \
    --cc=cpufreq@vger.kernel.org \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=shawn.guo@linaro.org \
    --cc=t.figa@samsung.com \
    --cc=ta.omasab@gmail.com \
    --cc=thomas.ab@samsung.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.