From: Stephen Boyd <sboyd@codeaurora.org>
To: Rob Herring <robherring2@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Wolfram Sang <wsa@the-dreams.de>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
Matt Porter <matt.porter@linaro.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@sonymobile.com>,
Grant Likely <grant.likely@linaro.org>,
James Ralston <james.d.ralston@intel.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Ivan T. Ivanov" <iivanov@mm-sol.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Rob Herring <rob.herring@calxeda.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Bill Brown <bill.e.brown@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v3 1/2] i2c: qup: Add device tree bindings information
Date: Mon, 20 Jan 2014 18:40:07 -0800 [thread overview]
Message-ID: <20140121024007.GE13785@codeaurora.org> (raw)
In-Reply-To: <CAL_JsqJBEu8iLzE8-dXniZFytr6cQsprBYiYnJeXS2-80iy1Mw@mail.gmail.com>
On 01/20, Rob Herring wrote:
> On Fri, Jan 17, 2014 at 5:03 PM, Bjorn Andersson
> <bjorn.andersson@sonymobile.com> wrote:
>
> > .../devicetree/bindings/i2c/qcom,i2c-qup.txt | 41 ++++++++++++++++++++++
> > 1 file changed, 41 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/i2c/qcom,i2c-qup.txt
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.txt b/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.txt
> > new file mode 100644
> > index 0000000..a99711b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.txt
> > @@ -0,0 +1,41 @@
> > +Qualcomm Universal Peripheral (QUP) I2C controller
> > +
> > +Required properties:
> > + - compatible: Should be "qcom,i2c-qup".
>
> Seems a bit generic. All versions of the IP are exactly the same?
> "qcom,<chip>-i2c-qup" would be better.
>
There are different versions of the IP in different SoCs. The
versions for platforms supported upstream are:
1.1.1 (MSM8660, MSM8960)
2.2.1 (MSM8974v2)
so how about one of "qcom,i2c-qup-v1.1.1" or
"qcom,i2c-qup-v2.2.1" should be specified as more specific
compatible strings in addition to "qcom,i2c-qup"?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/2] i2c: qup: Add device tree bindings information
Date: Mon, 20 Jan 2014 18:40:07 -0800 [thread overview]
Message-ID: <20140121024007.GE13785@codeaurora.org> (raw)
In-Reply-To: <CAL_JsqJBEu8iLzE8-dXniZFytr6cQsprBYiYnJeXS2-80iy1Mw@mail.gmail.com>
On 01/20, Rob Herring wrote:
> On Fri, Jan 17, 2014 at 5:03 PM, Bjorn Andersson
> <bjorn.andersson@sonymobile.com> wrote:
>
> > .../devicetree/bindings/i2c/qcom,i2c-qup.txt | 41 ++++++++++++++++++++++
> > 1 file changed, 41 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/i2c/qcom,i2c-qup.txt
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.txt b/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.txt
> > new file mode 100644
> > index 0000000..a99711b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.txt
> > @@ -0,0 +1,41 @@
> > +Qualcomm Universal Peripheral (QUP) I2C controller
> > +
> > +Required properties:
> > + - compatible: Should be "qcom,i2c-qup".
>
> Seems a bit generic. All versions of the IP are exactly the same?
> "qcom,<chip>-i2c-qup" would be better.
>
There are different versions of the IP in different SoCs. The
versions for platforms supported upstream are:
1.1.1 (MSM8660, MSM8960)
2.2.1 (MSM8974v2)
so how about one of "qcom,i2c-qup-v1.1.1" or
"qcom,i2c-qup-v2.2.1" should be specified as more specific
compatible strings in addition to "qcom,i2c-qup"?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-01-21 2:40 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 23:03 [PATCH v3 0/2] Qualcomm Universal Peripheral (QUP) I2C controller Bjorn Andersson
2014-01-17 23:03 ` Bjorn Andersson
2014-01-17 23:03 ` [PATCH v3 1/2] i2c: qup: Add device tree bindings information Bjorn Andersson
2014-01-17 23:03 ` Bjorn Andersson
2014-01-20 14:10 ` Rob Herring
2014-01-20 14:10 ` Rob Herring
2014-01-20 14:10 ` Rob Herring
2014-01-21 2:40 ` Stephen Boyd [this message]
2014-01-21 2:40 ` Stephen Boyd
2014-01-24 7:18 ` Andy Gross
2014-01-24 7:18 ` Andy Gross
2014-01-23 19:11 ` Matthew Locke
2014-01-23 19:11 ` Matthew Locke
2014-01-23 19:50 ` Arnd Bergmann
2014-01-23 19:50 ` Arnd Bergmann
2014-01-23 20:22 ` Bjorn Andersson
2014-01-23 20:22 ` Bjorn Andersson
2014-01-17 23:03 ` [PATCH v3 2/2] i2c: New bus driver for the QUP I2C controller Bjorn Andersson
2014-01-17 23:03 ` Bjorn Andersson
2014-01-21 2:22 ` Stephen Boyd
2014-01-21 2:22 ` Stephen Boyd
2014-01-24 1:25 ` Philip Elcan
2014-01-24 1:25 ` Philip Elcan
[not found] ` <1389999819-10648-1-git-send-email-bjorn.andersson-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org>
2014-01-29 8:14 ` [PATCH v3 0/2] Qualcomm Universal Peripheral (QUP) " Ivan T. Ivanov
2014-01-29 8:14 ` Ivan T. Ivanov
2014-01-29 8:14 ` Ivan T. Ivanov
2014-01-29 16:32 ` Bjorn Andersson
2014-01-29 16:32 ` Bjorn Andersson
2014-01-30 15:30 ` Ivan T. Ivanov
2014-01-30 15:30 ` Ivan T. Ivanov
2014-01-30 23:27 ` Bjorn Andersson
2014-01-30 23:27 ` Bjorn Andersson
-- strict thread matches above, loose matches on Subject: below --
2014-02-21 0:38 Bjorn Andersson
[not found] ` <1392943090-30556-1-git-send-email-bjorn.andersson-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org>
2014-02-21 0:38 ` [PATCH v3 1/2] i2c: qup: Add device tree bindings information Bjorn Andersson
2014-02-21 0:38 ` Bjorn Andersson
2014-02-21 0:38 ` Bjorn Andersson
2014-02-21 11:01 ` Mark Rutland
2014-02-21 11:01 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140121024007.GE13785@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bill.e.brown@intel.com \
--cc=bjorn.andersson@sonymobile.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=iivanov@mm-sol.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=james.d.ralston@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matt.porter@linaro.org \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=robherring2@gmail.com \
--cc=schwidefsky@de.ibm.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.