From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
kernel-janitors@vger.kernel.org,
Seung-Woo Kim <sw0312.kim@samsung.com>,
dri-devel@lists.freedesktop.org,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [patch] drm/exynos: potential use after free in exynos_drm_open()
Date: Tue, 21 Jan 2014 13:35:56 +0000 [thread overview]
Message-ID: <20140121133556.GY7444@mwanda> (raw)
In-Reply-To: <52DE6B8B.6080304@bfs.de>
On Tue, Jan 21, 2014 at 01:43:55PM +0100, walter harms wrote:
>
> i have just noticed: The function already exits
>
> 194 static void exynos_drm_postclose(struct drm_device *dev, struct drm_file *file)
> 195 {
> 196 if (!file->driver_priv)
> 197 return;
> 198
> 199 kfree(file->driver_priv);
> 200 file->driver_priv = NULL;
> 201 }
The function is different in the current code. I glanced through
drm_open_helper() and I don't see that file->driver_priv to NULL is
needed anyway...
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
kernel-janitors@vger.kernel.org,
Seung-Woo Kim <sw0312.kim@samsung.com>,
dri-devel@lists.freedesktop.org,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [patch] drm/exynos: potential use after free in exynos_drm_open()
Date: Tue, 21 Jan 2014 16:35:56 +0300 [thread overview]
Message-ID: <20140121133556.GY7444@mwanda> (raw)
In-Reply-To: <52DE6B8B.6080304@bfs.de>
On Tue, Jan 21, 2014 at 01:43:55PM +0100, walter harms wrote:
>
> i have just noticed: The function already exits
>
> 194 static void exynos_drm_postclose(struct drm_device *dev, struct drm_file *file)
> 195 {
> 196 if (!file->driver_priv)
> 197 return;
> 198
> 199 kfree(file->driver_priv);
> 200 file->driver_priv = NULL;
> 201 }
The function is different in the current code. I glanced through
drm_open_helper() and I don't see that file->driver_priv to NULL is
needed anyway...
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: dan.carpenter@oracle.com (Dan Carpenter)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch] drm/exynos: potential use after free in exynos_drm_open()
Date: Tue, 21 Jan 2014 16:35:56 +0300 [thread overview]
Message-ID: <20140121133556.GY7444@mwanda> (raw)
In-Reply-To: <52DE6B8B.6080304@bfs.de>
On Tue, Jan 21, 2014 at 01:43:55PM +0100, walter harms wrote:
>
> i have just noticed: The function already exits
>
> 194 static void exynos_drm_postclose(struct drm_device *dev, struct drm_file *file)
> 195 {
> 196 if (!file->driver_priv)
> 197 return;
> 198
> 199 kfree(file->driver_priv);
> 200 file->driver_priv = NULL;
> 201 }
The function is different in the current code. I glanced through
drm_open_helper() and I don't see that file->driver_priv to NULL is
needed anyway...
regards,
dan carpenter
next prev parent reply other threads:[~2014-01-21 13:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 6:57 [patch] drm/exynos: potential use after free in exynos_drm_open() Dan Carpenter
2014-01-21 6:57 ` Dan Carpenter
2014-01-21 6:57 ` Dan Carpenter
2014-01-21 7:12 ` Jingoo Han
2014-01-21 7:12 ` Jingoo Han
2014-01-21 7:12 ` Jingoo Han
2014-01-21 7:12 ` Inki Dae
2014-01-21 7:12 ` Inki Dae
2014-01-21 7:12 ` Inki Dae
2014-01-21 12:37 ` walter harms
2014-01-21 12:37 ` walter harms
2014-01-21 12:37 ` walter harms
2014-01-21 12:43 ` walter harms
2014-01-21 12:43 ` walter harms
2014-01-21 12:43 ` walter harms
2014-01-21 13:35 ` Dan Carpenter [this message]
2014-01-21 13:35 ` Dan Carpenter
2014-01-21 13:35 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140121133556.GY7444@mwanda \
--to=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sw0312.kim@samsung.com \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.