From: Marek Vasut <marex@denx.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Geert Uytterhoeven <geert+renesas@linux-m68k.org>,
linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org,
Sourav Poddar <sourav.poddar@ti.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 4/4] mtd: m25p80: Enable Dual SPI read transfers for s25fl256s1 and s25fl512s
Date: Tue, 21 Jan 2014 16:42:55 +0100 [thread overview]
Message-ID: <201401211642.55461.marex@denx.de> (raw)
In-Reply-To: <1390309159-19643-5-git-send-email-geert@linux-m68k.org>
On Tuesday, January 21, 2014 at 01:59:19 PM, Geert Uytterhoeven wrote:
> From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
>
> Spansion s25fl256s1 and s25fl512s support Dual SPI transfers, hence set the
> M25P80_DUAL_READ flag.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
> ---
> drivers/mtd/devices/m25p80.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index 73bf661100f7..f0871a2e449d 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -960,8 +960,8 @@ static const struct spi_device_id m25p_ids[] = {
> { "s25sl032p", INFO(0x010215, 0x4d00, 64 * 1024, 64, 0) },
> { "s25sl064p", INFO(0x010216, 0x4d00, 64 * 1024, 128, 0) },
> { "s25fl256s0", INFO(0x010219, 0x4d00, 256 * 1024, 128, 0) },
> - { "s25fl256s1", INFO(0x010219, 0x4d01, 64 * 1024, 512,
M25P80_QUAD_READ)
> }, - { "s25fl512s", INFO(0x010220, 0x4d00, 256 * 1024, 256,
> M25P80_QUAD_READ) }, + { "s25fl256s1", INFO(0x010219, 0x4d01, 64 * 1024,
> 512, M25P80_DUAL_READ | M25P80_QUAD_READ) }, + { "s25fl512s",
> INFO(0x010220, 0x4d00, 256 * 1024, 256, M25P80_DUAL_READ |
> M25P80_QUAD_READ) }, { "s70fl01gs", INFO(0x010221, 0x4d00, 256 * 1024,
> 256, 0) },
> { "s25sl12800", INFO(0x012018, 0x0300, 256 * 1024, 64, 0) },
> { "s25sl12801", INFO(0x012018, 0x0301, 64 * 1024, 256, 0) },
Why don't you lump this together with 1/4 ? :)
Best regards,
Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
To: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Cc: David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Brian Norris
<computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Sourav Poddar <sourav.poddar-l0cyMroinI0@public.gmane.org>,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Geert Uytterhoeven
<geert+renesas-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Subject: Re: [PATCH 4/4] mtd: m25p80: Enable Dual SPI read transfers for s25fl256s1 and s25fl512s
Date: Tue, 21 Jan 2014 16:42:55 +0100 [thread overview]
Message-ID: <201401211642.55461.marex@denx.de> (raw)
In-Reply-To: <1390309159-19643-5-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
On Tuesday, January 21, 2014 at 01:59:19 PM, Geert Uytterhoeven wrote:
> From: Geert Uytterhoeven <geert+renesas-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
>
> Spansion s25fl256s1 and s25fl512s support Dual SPI transfers, hence set the
> M25P80_DUAL_READ flag.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
> ---
> drivers/mtd/devices/m25p80.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index 73bf661100f7..f0871a2e449d 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -960,8 +960,8 @@ static const struct spi_device_id m25p_ids[] = {
> { "s25sl032p", INFO(0x010215, 0x4d00, 64 * 1024, 64, 0) },
> { "s25sl064p", INFO(0x010216, 0x4d00, 64 * 1024, 128, 0) },
> { "s25fl256s0", INFO(0x010219, 0x4d00, 256 * 1024, 128, 0) },
> - { "s25fl256s1", INFO(0x010219, 0x4d01, 64 * 1024, 512,
M25P80_QUAD_READ)
> }, - { "s25fl512s", INFO(0x010220, 0x4d00, 256 * 1024, 256,
> M25P80_QUAD_READ) }, + { "s25fl256s1", INFO(0x010219, 0x4d01, 64 * 1024,
> 512, M25P80_DUAL_READ | M25P80_QUAD_READ) }, + { "s25fl512s",
> INFO(0x010220, 0x4d00, 256 * 1024, 256, M25P80_DUAL_READ |
> M25P80_QUAD_READ) }, { "s70fl01gs", INFO(0x010221, 0x4d00, 256 * 1024,
> 256, 0) },
> { "s25sl12800", INFO(0x012018, 0x0300, 256 * 1024, 64, 0) },
> { "s25sl12801", INFO(0x012018, 0x0301, 64 * 1024, 256, 0) },
Why don't you lump this together with 1/4 ? :)
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-01-21 15:43 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 12:59 [PATCH 0/4] m25p80 Quad/Dual updates Geert Uytterhoeven
2014-01-21 12:59 ` Geert Uytterhoeven
2014-01-21 12:59 ` [PATCH 1/4] mtd: m25p80: Enable Quad SPI read transfers for s25fl512s Geert Uytterhoeven
2014-01-21 12:59 ` Geert Uytterhoeven
2014-01-21 15:13 ` Marek Vasut
2014-01-21 15:13 ` Marek Vasut
2014-01-21 12:59 ` [PATCH 2/4] mtd: m25p80: Set rx_nbits for Quad SPI transfers Geert Uytterhoeven
2014-01-21 12:59 ` Geert Uytterhoeven
2014-01-21 15:18 ` Marek Vasut
2014-01-21 15:18 ` Marek Vasut
2014-01-21 12:59 ` [PATCH 3/4] mtd: m25p80: Add dual read support Geert Uytterhoeven
2014-01-21 12:59 ` Geert Uytterhoeven
2014-01-21 15:42 ` Marek Vasut
2014-01-21 15:42 ` Marek Vasut
2014-01-21 12:59 ` [PATCH 4/4] mtd: m25p80: Enable Dual SPI read transfers for s25fl256s1 and s25fl512s Geert Uytterhoeven
2014-01-21 12:59 ` Geert Uytterhoeven
2014-01-21 15:42 ` Marek Vasut [this message]
2014-01-21 15:42 ` Marek Vasut
2014-01-21 15:58 ` Geert Uytterhoeven
2014-01-21 15:58 ` Geert Uytterhoeven
2014-01-21 16:10 ` Marek Vasut
2014-01-21 16:10 ` Marek Vasut
2014-01-23 2:01 ` [PATCH 0/4] m25p80 Quad/Dual updates Huang Shijie
2014-01-23 2:01 ` Huang Shijie
2014-01-25 9:06 ` Brian Norris
2014-01-25 9:06 ` Brian Norris
2014-01-28 5:26 ` Brian Norris
2014-01-28 5:26 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201401211642.55461.marex@denx.de \
--to=marex@denx.de \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=geert+renesas@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=sourav.poddar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.