From: Daniel Vetter <daniel@ffwll.ch>
To: Todd Previte <tprevite@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH V2] drm/i915: (VLV2) Fix the hotplug detection bits
Date: Tue, 21 Jan 2014 18:45:54 +0100 [thread overview]
Message-ID: <20140121174554.GC9772@phenom.ffwll.local> (raw)
In-Reply-To: <1390324951-6711-1-git-send-email-tprevite@gmail.com>
On Tue, Jan 21, 2014 at 10:22:31AM -0700, Todd Previte wrote:
> These bits are in reverse order in the header from those defined in
> the specification. Change the bit positions for ports B and D to
> correctly match the spec.
>
> - Added sign-off
>
> Signed-off-by: Todd Previte <tprevite@gmail.com>
>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 10ecf90..2d77b51 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -2083,9 +2083,9 @@
> * Please check the detailed lore in the commit message for for experimental
> * evidence.
> */
> -#define PORTD_HOTPLUG_LIVE_STATUS (1 << 29)
> +#define PORTD_HOTPLUG_LIVE_STATUS (1 << 27)
> #define PORTC_HOTPLUG_LIVE_STATUS (1 << 28)
> -#define PORTB_HOTPLUG_LIVE_STATUS (1 << 27)
> +#define PORTB_HOTPLUG_LIVE_STATUS (1 << 29)
As Jani explained, this will break g4x. And it might very well be that
this particular lie has been carried forward until baytrail, so I think we
must cross check Bspec first with the reality of shipping platforms.
-Daniel
> #define PORTD_HOTPLUG_INT_STATUS (3 << 21)
> #define PORTC_HOTPLUG_INT_STATUS (3 << 19)
> #define PORTB_HOTPLUG_INT_STATUS (3 << 17)
> --
> 1.8.3.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-01-21 17:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 16:38 [PATCH] drm/i915: (VLV2) Fix the hotplug detection bits Todd Previte
2014-01-21 17:14 ` Jani Nikula
2014-01-21 17:22 ` [PATCH V2] " Todd Previte
2014-01-21 17:45 ` Daniel Vetter [this message]
2014-01-21 18:12 ` Ville Syrjälä
2014-01-21 17:49 ` Jani Nikula
2014-01-23 4:22 ` (no subject) Todd Previte
2014-01-23 4:22 ` [PATCH v3] drm/i915: VLV2 - Fix hotplug detect bits Todd Previte
2014-01-23 6:39 ` Jani Nikula
2014-01-23 6:41 ` Jani Nikula
2014-01-23 7:16 ` Todd Previte
2014-01-23 7:13 ` [PATCH V4] " Todd Previte
2014-01-23 7:13 ` [PATCH V4] drm/i915: " Todd Previte
2014-01-23 10:50 ` Daniel Vetter
2014-01-23 10:52 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140121174554.GC9772@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tprevite@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.