From: Daniel Vetter <daniel@ffwll.ch>
To: Todd Previte <tprevite@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH V4] drm/i915: VLV2 - Fix hotplug detect bits
Date: Thu, 23 Jan 2014 11:52:51 +0100 [thread overview]
Message-ID: <20140123105251.GT9772@phenom.ffwll.local> (raw)
In-Reply-To: <20140123105038.GS9772@phenom.ffwll.local>
On Thu, Jan 23, 2014 at 11:50:38AM +0100, Daniel Vetter wrote:
> On Thu, Jan 23, 2014 at 12:13:41AM -0700, Todd Previte wrote:
> > Add new definitions for hotplug live status bits for VLV2 since they're
> > in reverse order from the gen4x ones.
> >
> > Changelog:
> > - Restored gen4 bit definitions
> > - Added new definitions for VLV2
> > - Added platform check for IS_VALLEYVIEW() in dp_detect to use the correct
> > bit defintions
> > - Replaced a lost trailing brace for the added switch()
> >
> > Signed-off-by: Todd Previte <tprevite@gmail.com>
>
> I've bikeshedded your patch a bit for more consistency. Wrt the patch
> changelog please don't smash it all into one but keep a separate changelog
> per revision. Otherwise it's not clear what e.g. changed from v3->v4 and
> so no too useful for reviewers when rechecking patches.
Also please add bugzilla links and cc: stable for bugfixes like these into
the sob section of the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-01-23 10:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 16:38 [PATCH] drm/i915: (VLV2) Fix the hotplug detection bits Todd Previte
2014-01-21 17:14 ` Jani Nikula
2014-01-21 17:22 ` [PATCH V2] " Todd Previte
2014-01-21 17:45 ` Daniel Vetter
2014-01-21 18:12 ` Ville Syrjälä
2014-01-21 17:49 ` Jani Nikula
2014-01-23 4:22 ` (no subject) Todd Previte
2014-01-23 4:22 ` [PATCH v3] drm/i915: VLV2 - Fix hotplug detect bits Todd Previte
2014-01-23 6:39 ` Jani Nikula
2014-01-23 6:41 ` Jani Nikula
2014-01-23 7:16 ` Todd Previte
2014-01-23 7:13 ` [PATCH V4] " Todd Previte
2014-01-23 7:13 ` [PATCH V4] drm/i915: " Todd Previte
2014-01-23 10:50 ` Daniel Vetter
2014-01-23 10:52 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140123105251.GT9772@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tprevite@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.