[PATCH 1/2] asus-wmi: control wlan-led if wapf > 0

[PATCH 1/2] asus-wmi: control wlan-led if wapf > 0

[AceLan Kao]

Wifi will be controlled by asus-wmi driver when wapf > 0
So, controls the wifi-led when wapf > 0

Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
---
 drivers/platform/x86/asus-wmi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index 19c313b..cb22d3f 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers/platform/x86/asus-wmi.c
@@ -558,7 +558,7 @@ static int asus_wmi_led_init(struct asus_wmi *asus)
 			goto error;
 	}
 
-	if (wlan_led_presence(asus) && (asus->driver->quirks->wapf == 4)) {
+	if (wlan_led_presence(asus) && (asus->driver->quirks->wapf > 0)) {
 		INIT_WORK(&asus->wlan_led_work, wlan_led_update);
 
 		asus->wlan_led.name = "asus::wlan";
@@ -887,7 +887,7 @@ static int asus_new_rfkill(struct asus_wmi *asus,
 		return -EINVAL;
 
 	if ((dev_id == ASUS_WMI_DEVID_WLAN) &&
-			(asus->driver->quirks->wapf == 4))
+			(asus->driver->quirks->wapf > 0))
 		rfkill_set_led_trigger_name(*rfkill, "asus-wlan");
 
 	rfkill_init_sw_state(*rfkill, !result);
-- 
1.8.3.2

[PATCH 2/2] asus-nb-wmi: Add ASUSTeK COMPUTER INC. X200CA

[AceLan Kao]

BIOS won't light on the wifi-led after S3, so asus-wmi driver needs to
control the wifi and wifi-led status.
But, it'll lead to bt status error if asus-wmi driver controls bt as well.
So, for X200CA, asus-wmi driver controls wifi status only and have to set
wapf to 1.

Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
---
 drivers/platform/x86/asus-nb-wmi.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
index 563f59e..32a177b 100644
--- a/drivers/platform/x86/asus-nb-wmi.c
+++ b/drivers/platform/x86/asus-nb-wmi.c
@@ -74,6 +74,10 @@ static struct quirk_entry quirk_asus_x401u = {
 	.wapf = 4,
 };
 
+static struct quirk_entry quirk_asus_x200ca = {
+	.wapf = 2,
+};
+
 static int dmi_matched(const struct dmi_system_id *dmi)
 {
 	quirks = dmi->driver_data;
@@ -198,6 +202,15 @@ static struct dmi_system_id asus_quirks[] = {
 		},
 		.driver_data = &quirk_asus_x401u,
 	},
+	{
+		.callback = dmi_matched,
+		.ident = "ASUSTeK COMPUTER INC. X200CA",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "X200CA"),
+		},
+		.driver_data = &quirk_asus_x200ca,
+	},
 	{},
 };
 
-- 
1.8.3.2

Re: [PATCH 1/2] asus-wmi: control wlan-led if wapf > 0

[AceLan Kao]

Hi Mathew,

It looks like you miss the 2 patches, I didn't see them appear in
platform git tree.
Could you review the 2 patches and apply them?
Thanks.

Best regards,
AceLan Kao.

2013/10/2 AceLan Kao <acelan.kao@canonical.com>:
> Wifi will be controlled by asus-wmi driver when wapf > 0
> So, controls the wifi-led when wapf > 0
>
> Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
> ---
>  drivers/platform/x86/asus-wmi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> index 19c313b..cb22d3f 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -558,7 +558,7 @@ static int asus_wmi_led_init(struct asus_wmi *asus)
>                         goto error;
>         }
>
> -       if (wlan_led_presence(asus) && (asus->driver->quirks->wapf == 4)) {
> +       if (wlan_led_presence(asus) && (asus->driver->quirks->wapf > 0)) {
>                 INIT_WORK(&asus->wlan_led_work, wlan_led_update);
>
>                 asus->wlan_led.name = "asus::wlan";
> @@ -887,7 +887,7 @@ static int asus_new_rfkill(struct asus_wmi *asus,
>                 return -EINVAL;
>
>         if ((dev_id == ASUS_WMI_DEVID_WLAN) &&
> -                       (asus->driver->quirks->wapf == 4))
> +                       (asus->driver->quirks->wapf > 0))
>                 rfkill_set_led_trigger_name(*rfkill, "asus-wlan");
>
>         rfkill_init_sw_state(*rfkill, !result);
> --
> 1.8.3.2
>



-- 
Chia-Lin Kao(AceLan)
http://blog.acelan.idv.tw/
E-Mail: acelan.kaoATcanonical.com (s/AT/@/)

Re: [PATCH 1/2] asus-wmi: control wlan-led if wapf > 0

[AceLan Kao]

Hi Mathew,

It's been over 3 months since the 2 patches were submitted.
Could you please review them or should I re-submit them?
Thanks.

Best regards,
AceLan Kao.

2013/12/17 AceLan Kao <acelan.kao@canonical.com>:
> Hi Mathew,
>
> It looks like you miss the 2 patches, I didn't see them appear in
> platform git tree.
> Could you review the 2 patches and apply them?
> Thanks.
>
> Best regards,
> AceLan Kao.
>
> 2013/10/2 AceLan Kao <acelan.kao@canonical.com>:
>> Wifi will be controlled by asus-wmi driver when wapf > 0
>> So, controls the wifi-led when wapf > 0
>>
>> Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
>> ---
>>  drivers/platform/x86/asus-wmi.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
>> index 19c313b..cb22d3f 100644
>> --- a/drivers/platform/x86/asus-wmi.c
>> +++ b/drivers/platform/x86/asus-wmi.c
>> @@ -558,7 +558,7 @@ static int asus_wmi_led_init(struct asus_wmi *asus)
>>                         goto error;
>>         }
>>
>> -       if (wlan_led_presence(asus) && (asus->driver->quirks->wapf == 4)) {
>> +       if (wlan_led_presence(asus) && (asus->driver->quirks->wapf > 0)) {
>>                 INIT_WORK(&asus->wlan_led_work, wlan_led_update);
>>
>>                 asus->wlan_led.name = "asus::wlan";
>> @@ -887,7 +887,7 @@ static int asus_new_rfkill(struct asus_wmi *asus,
>>                 return -EINVAL;
>>
>>         if ((dev_id == ASUS_WMI_DEVID_WLAN) &&
>> -                       (asus->driver->quirks->wapf == 4))
>> +                       (asus->driver->quirks->wapf > 0))
>>                 rfkill_set_led_trigger_name(*rfkill, "asus-wlan");
>>
>>         rfkill_init_sw_state(*rfkill, !result);
>> --
>> 1.8.3.2
>>
>
>
>
> --
> Chia-Lin Kao(AceLan)
> http://blog.acelan.idv.tw/
> E-Mail: acelan.kaoATcanonical.com (s/AT/@/)



-- 
Chia-Lin Kao(AceLan)
http://blog.acelan.idv.tw/
E-Mail: acelan.kaoATcanonical.com (s/AT/@/)

Re: [PATCH 1/2] asus-wmi: control wlan-led if wapf > 0

[Matthew Garrett]

On Wed, Jan 22, 2014 at 04:33:06PM +0800, AceLan Kao wrote:
> Hi Mathew,
> 
> It's been over 3 months since the 2 patches were submitted.
> Could you please review them or should I re-submit them?

I've merged these, thanks!

-- 
Matthew Garrett | mjg59@srcf.ucam.org

[PATCH 1/2] asus-wmi: control wlan-led if wapf > 0

[AceLan Kao]

Wifi will be controlled by asus-wmi driver when wapf > 0
So, controls the wifi-led when wapf > 0

Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
---
 drivers/platform/x86/asus-wmi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index 19c313b..cb22d3f 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers/platform/x86/asus-wmi.c
@@ -558,7 +558,7 @@ static int asus_wmi_led_init(struct asus_wmi *asus)
 			goto error;
 	}
 
-	if (wlan_led_presence(asus) && (asus->driver->quirks->wapf == 4)) {
+	if (wlan_led_presence(asus) && (asus->driver->quirks->wapf > 0)) {
 		INIT_WORK(&asus->wlan_led_work, wlan_led_update);
 
 		asus->wlan_led.name = "asus::wlan";
@@ -887,7 +887,7 @@ static int asus_new_rfkill(struct asus_wmi *asus,
 		return -EINVAL;
 
 	if ((dev_id == ASUS_WMI_DEVID_WLAN) &&
-			(asus->driver->quirks->wapf == 4))
+			(asus->driver->quirks->wapf > 0))
 		rfkill_set_led_trigger_name(*rfkill, "asus-wlan");
 
 	rfkill_init_sw_state(*rfkill, !result);
-- 
1.8.3.2

Re: [PATCH 1/2] asus-wmi: control wlan-led if wapf > 0

[AceLan Kao]

Hi Matthew,

Sorry to re-send the patches.
I forgot to check the status of these 2 patches, it had been submitted
almost one year ago, but still didn't go into platform-drivers-x86 git
tree.
Please review them, many thanks.

Best regards,
AceLan Kao.

2014-07-09 16:18 GMT+08:00 AceLan Kao <acelan.kao@canonical.com>:
> Wifi will be controlled by asus-wmi driver when wapf > 0
> So, controls the wifi-led when wapf > 0
>
> Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
> ---
>  drivers/platform/x86/asus-wmi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> index 19c313b..cb22d3f 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -558,7 +558,7 @@ static int asus_wmi_led_init(struct asus_wmi *asus)
>                         goto error;
>         }
>
> -       if (wlan_led_presence(asus) && (asus->driver->quirks->wapf == 4)) {
> +       if (wlan_led_presence(asus) && (asus->driver->quirks->wapf > 0)) {
>                 INIT_WORK(&asus->wlan_led_work, wlan_led_update);
>
>                 asus->wlan_led.name = "asus::wlan";
> @@ -887,7 +887,7 @@ static int asus_new_rfkill(struct asus_wmi *asus,
>                 return -EINVAL;
>
>         if ((dev_id == ASUS_WMI_DEVID_WLAN) &&
> -                       (asus->driver->quirks->wapf == 4))
> +                       (asus->driver->quirks->wapf > 0))
>                 rfkill_set_led_trigger_name(*rfkill, "asus-wlan");
>
>         rfkill_init_sw_state(*rfkill, !result);
> --
> 1.8.3.2
>



-- 
Chia-Lin Kao(AceLan)
http://blog.acelan.idv.tw/
E-Mail: acelan.kaoATcanonical.com (s/AT/@/)