All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: xenmail43267@gmail.com
Cc: Ian.Campbell@citrix.com, andrew.cooper3@citrix.com,
	xen-devel@lists.xen.org, Mike Neilsen <mneilsen@acm.org>,
	stefano.stabellini@citrix.com, alex.sharp@orionvm.com
Subject: Re: [PATCH] mini-os: Fix stubdom build failures on gcc 4.8
Date: Wed, 22 Jan 2014 18:19:06 +0100	[thread overview]
Message-ID: <20140122171906.GT8171@type> (raw)
In-Reply-To: <1390410769-2517-1-git-send-email-xenmail43267@gmail.com>

xenmail43267@gmail.com, le Wed 22 Jan 2014 11:12:49 -0600, a écrit :
> index 16a4b49..ce5180c 100644
> --- a/extras/mini-os/pcifront.c
> +++ b/extras/mini-os/pcifront.c
> @@ -424,7 +424,7 @@ int pcifront_physical_to_virtual (struct pcifront_dev *dev,
>                  continue;
>              }
>  
> -            if (sscanf(s, "%x:%x:%x.%x", dom, bus, slot, fun) != 4) {
> +            if (sscanf(s, "%x:%x:%x.%lx", dom, bus, slot, fun) != 4) {
>                  printk("\"%s\" does not look like a PCI device address\n", s);
>                  free(s);
>                  continue;

Rather make fun an unsigned int, there is no reason why it should be an
unsigned long, I'm still wondering where that comes from.

There rest seems OK to me.

  reply	other threads:[~2014-01-22 17:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-22 17:12 [PATCH] mini-os: Fix stubdom build failures on gcc 4.8 xenmail43267
2014-01-22 17:19 ` Samuel Thibault [this message]
2014-01-23 10:32   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140122171906.GT8171@type \
    --to=samuel.thibault@ens-lyon.org \
    --cc=Ian.Campbell@citrix.com \
    --cc=alex.sharp@orionvm.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=mneilsen@acm.org \
    --cc=stefano.stabellini@citrix.com \
    --cc=xen-devel@lists.xen.org \
    --cc=xenmail43267@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.