All of lore.kernel.org
 help / color / mirror / Atom feed
From: jogo@openwrt.org (Jonas Gorski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ehci-platform: Add support for controllers with big-endian regs / descriptors
Date: Thu, 23 Jan 2014 00:03:30 +0100	[thread overview]
Message-ID: <20140123000330.00002567@openwrt.org> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1401221614550.1310-100000@iolanthe.rowland.org>

On Wed, 22 Jan 2014 16:17:42 -0500 (EST)
Alan Stern <stern@rowland.harvard.edu> wrote:

> On Wed, 22 Jan 2014, Jonas Gorski wrote:
> 
> > If it's safe to set ehci->big_endian_{desc,mmio} from the _probe()
> > routine, then maybe the pdata sets in _reset() should be moved into here
> > instead of adding extra cludges/checks into _reset().
> 
> Why?  What difference would it make?

Effectivewise none, but to me it seems to be cleaner to set them once in
probe() instead of everytime reset() is called.

I admit I don't know the code flow good enough if reset() is called
more than once in the lifetime of a hcd device.

And as I said, it would allow doing the checks the patch adds for both
DT and !DT, not just DT only.


Regards
Jonas

WARNING: multiple messages have this Message-ID (diff)
From: Jonas Gorski <jogo-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
To: Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>
Cc: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Florian Fainelli
	<f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-usb <linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 2/2] ehci-platform: Add support for controllers with big-endian regs / descriptors
Date: Thu, 23 Jan 2014 00:03:30 +0100	[thread overview]
Message-ID: <20140123000330.00002567@openwrt.org> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1401221614550.1310-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>

On Wed, 22 Jan 2014 16:17:42 -0500 (EST)
Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org> wrote:

> On Wed, 22 Jan 2014, Jonas Gorski wrote:
> 
> > If it's safe to set ehci->big_endian_{desc,mmio} from the _probe()
> > routine, then maybe the pdata sets in _reset() should be moved into here
> > instead of adding extra cludges/checks into _reset().
> 
> Why?  What difference would it make?

Effectivewise none, but to me it seems to be cleaner to set them once in
probe() instead of everytime reset() is called.

I admit I don't know the code flow good enough if reset() is called
more than once in the lifetime of a hcd device.

And as I said, it would allow doing the checks the patch adds for both
DT and !DT, not just DT only.


Regards
Jonas
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2014-01-22 23:03 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-21 15:48 [PATCH 1/2] ohci-platform: Add support for controllers with big-endian regs / descriptors Hans de Goede
2014-01-21 15:48 ` Hans de Goede
2014-01-21 15:48 ` [PATCH 2/2] ehci-platform: " Hans de Goede
2014-01-21 15:48   ` Hans de Goede
2014-01-21 19:39   ` Florian Fainelli
2014-01-21 19:39     ` Florian Fainelli
2014-01-22 19:28     ` Hans de Goede
2014-01-22 19:28       ` Hans de Goede
2014-01-22 20:34       ` Jonas Gorski
2014-01-22 20:34         ` Jonas Gorski
2014-01-22 20:52         ` Hans de Goede
2014-01-22 20:52           ` Hans de Goede
2014-01-22 21:02           ` Hans de Goede
2014-01-22 21:02             ` Hans de Goede
2014-01-22 21:17         ` Alan Stern
2014-01-22 21:17           ` Alan Stern
2014-01-22 23:03           ` Jonas Gorski [this message]
2014-01-22 23:03             ` Jonas Gorski
2014-01-23 15:46             ` Alan Stern
2014-01-23 15:46               ` Alan Stern
2014-01-21 16:40 ` [PATCH 1/2] ohci-platform: " Alan Stern
2014-01-21 16:40   ` Alan Stern
2014-01-21 17:01   ` Hans de Goede
2014-01-21 17:01     ` Hans de Goede
2014-01-21 18:09     ` Alan Stern
2014-01-21 18:09       ` Alan Stern
2014-01-21 19:48       ` Florian Fainelli
2014-01-21 19:48         ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140123000330.00002567@openwrt.org \
    --to=jogo@openwrt.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.