All of lore.kernel.org
 help / color / mirror / Atom feed
From: w@1wt.eu (Willy Tarreau)
To: linux-arm-kernel@lists.infradead.org
Subject: [BUG] FL1009: xHCI host not responding to stop endpoint command.
Date: Thu, 23 Jan 2014 12:09:14 +0100	[thread overview]
Message-ID: <20140123110914.GA22913@1wt.eu> (raw)
In-Reply-To: <87sisfjeba.fsf@natisbad.org>

On Thu, Jan 23, 2014 at 09:24:41AM +0100, Arnaud Ebalard wrote:
> Hi Sarah,
> 
> Sarah Sharp <sarah.a.sharp@linux.intel.com> writes:
> 
> >> > Can you pinpoint the commit that introduced the regression?
> >> 
> >> f5182b4155b9d686c5540a6822486400e34ddd98 "xhci: Disable MSI for some Fresco Logic hosts."
> >> 
> >> Technically, this is not per se the commit which introduced the
> >> regression but the one that *partially* fixed it by introducing the XHCI
> >> quirk to skip MSI enabling for Fresco Logic chips. The thing is it
> >> should have included the FL1009 in the targets. Sarah, can you confirm
> >> this?
> >
> > I don't know if it should have included FL1009, it was just a guess,
> > based on the fact that the 0x1000 and 0x1400 devices did need MSI
> > disabled.  I can attempt to ask the Fresco Logic folks I know, but I'm
> > not sure if/when I'll get a response back.
> >
> > That still doesn't necessarily rule out MSI issues in the Marvell PCI
> > host controller code.  Can you attach another PCI device with MSI
> > support under the host and see if it works?
> 
> The various Armada-based devices I have are NAS which do not have PCIe
> slots to plug additional devices (everything is soldered). I don't know
> which device Thomas used for its tests. Just in case, I also added Willy
> in CC: who have various boards and may also have done more test with
> additional PCIe devices and CONFIG_PCI_MSI enabled on 3.13 kernel.

I've been running an intel i350 dual-port NIC (igb driver) supporting
MSI on the mirabox, and it used to work in 3.10+many of the patches
coming from the Free-electrons team. Some recent changes to the PCI
code introduced a regression preventing this driver from correctly
registering an MSI interrupt, and I did not have enough time to
investigate it deep enough to fix it. That said, I know how to hack
it to work again, so if it can be of any use, I can run a test on
the mirabox (armada370) and on the XPGP board (armadaXP).

Willy

  reply	other threads:[~2014-01-23 11:09 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-12 20:13 [BUG] FL1009: xHCI host not responding to stop endpoint command Arnaud Ebalard
2014-01-12 21:36 ` Arnaud Ebalard
2014-01-14 17:07   ` Sarah Sharp
2014-01-14 18:11     ` Bjørn Mork
2014-01-14 21:54     ` Arnaud Ebalard
2014-01-15  9:59       ` David Laight
2014-01-15 19:04         ` Arnaud Ebalard
2014-01-16 18:50           ` Sarah Sharp
2014-01-17  6:25             ` Arnaud Ebalard
2014-01-17  8:31               ` Bjørn Mork
2014-01-17 20:54                 ` Sarah Sharp
2014-01-18 21:49                   ` Arnaud Ebalard
2014-01-21 21:17                     ` Sarah Sharp
2014-01-22 22:23                       ` Arnaud Ebalard
2014-01-22 22:26                         ` Jason Cooper
2014-01-22 22:43                           ` Arnaud Ebalard
2014-01-22 23:56                             ` Sarah Sharp
2014-01-23  8:24                               ` Arnaud Ebalard
2014-01-23 11:09                                 ` Willy Tarreau [this message]
2014-01-27 22:20                                   ` Arnaud Ebalard
2014-01-26 13:30                                 ` Thomas Petazzoni
2014-01-27 18:36                                   ` Arnaud Ebalard
2014-02-10 18:57                               ` Arnaud Ebalard
2014-02-14  0:09                                 ` Sarah Sharp
2014-02-14  8:26                                   ` Thomas Petazzoni
2014-02-18 13:10                     ` Thomas Petazzoni
2014-02-18 20:54                       ` Arnaud Ebalard
2014-02-18 21:24                         ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140123110914.GA22913@1wt.eu \
    --to=w@1wt.eu \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.