All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Benoît Canet" <benoit.canet@irqsave.net>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-trivial@nongnu.org, Michael Tokarev <mjt@tls.msk.ru>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] osdep: drop unused #include "trace.h"
Date: Thu, 23 Jan 2014 22:19:08 +0100	[thread overview]
Message-ID: <20140123211908.GB22578@irqsave.net> (raw)
In-Reply-To: <1390508879-13729-1-git-send-email-stefanha@redhat.com>

Le Thursday 23 Jan 2014 à 14:27:59 (-0600), Stefan Hajnoczi a écrit :
> osdep.c does not use trace_*() so we can just drop the include.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  util/osdep.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/util/osdep.c b/util/osdep.c
> index 62072b4..bd4f530 100644
> --- a/util/osdep.c
> +++ b/util/osdep.c
> @@ -46,7 +46,6 @@ extern int madvise(caddr_t, size_t, int);
>  #endif
>  
>  #include "qemu-common.h"
> -#include "trace.h"
>  #include "qemu/sockets.h"
>  #include "monitor/monitor.h"
>  
> -- 
> 1.8.4.2
> 
> 
Reviewed-by: Benoit Canet <benoit@irqsave.net>


WARNING: multiple messages have this Message-ID (diff)
From: "Benoît Canet" <benoit.canet@irqsave.net>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-trivial@nongnu.org, Michael Tokarev <mjt@tls.msk.ru>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] osdep: drop unused #include "trace.h"
Date: Thu, 23 Jan 2014 22:19:08 +0100	[thread overview]
Message-ID: <20140123211908.GB22578@irqsave.net> (raw)
In-Reply-To: <1390508879-13729-1-git-send-email-stefanha@redhat.com>

Le Thursday 23 Jan 2014 à 14:27:59 (-0600), Stefan Hajnoczi a écrit :
> osdep.c does not use trace_*() so we can just drop the include.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  util/osdep.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/util/osdep.c b/util/osdep.c
> index 62072b4..bd4f530 100644
> --- a/util/osdep.c
> +++ b/util/osdep.c
> @@ -46,7 +46,6 @@ extern int madvise(caddr_t, size_t, int);
>  #endif
>  
>  #include "qemu-common.h"
> -#include "trace.h"
>  #include "qemu/sockets.h"
>  #include "monitor/monitor.h"
>  
> -- 
> 1.8.4.2
> 
> 
Reviewed-by: Benoit Canet <benoit@irqsave.net>

  reply	other threads:[~2014-01-23 21:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-23 20:27 [Qemu-trivial] [PATCH] osdep: drop unused #include "trace.h" Stefan Hajnoczi
2014-01-23 20:27 ` [Qemu-devel] " Stefan Hajnoczi
2014-01-23 21:19 ` Benoît Canet [this message]
2014-01-23 21:19   ` Benoît Canet
2014-01-24 10:24 ` [Qemu-trivial] " Michael Tokarev
2014-01-24 10:24   ` [Qemu-devel] " Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140123211908.GB22578@irqsave.net \
    --to=benoit.canet@irqsave.net \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.