All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pratyush Anand <pratyush.anand@st.com>
To: Tejun Heo <tj@kernel.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Mohit KUMAR DCG <Mohit.KUMAR@st.com>,
	spear-devel <spear-devel@list.st.com>,
	"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
	Viresh Kumar <viresh.linux@gmail.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2 3/8] ahci: Add a driver_data field to struct ahci_platform_data
Date: Fri, 24 Jan 2014 09:07:54 +0530	[thread overview]
Message-ID: <20140124033754.GA2369@pratyush-vbox> (raw)
In-Reply-To: <20140123113644.GA28621@htj.dyndns.org>

On Thu, Jan 23, 2014 at 07:36:44PM +0800, Tejun Heo wrote:
> On Thu, Jan 23, 2014 at 04:02:43PM +0530, Mohit Kumar wrote:
> > diff --git a/include/linux/ahci_platform.h b/include/linux/ahci_platform.h
> > index 73a2500..76d35e8 100644
> > --- a/include/linux/ahci_platform.h
> > +++ b/include/linux/ahci_platform.h
> > @@ -28,6 +28,7 @@ struct ahci_platform_data {
> >  	const struct ata_port_info *ata_port_info;
> >  	unsigned int force_port_map;
> >  	unsigned int mask_port_map;
> > +	void *driver_data;
> 
> Please use private_data instead for consistency with other ata data
> structures.

Ok.. ll do that in V3.

Thanks for your review.

Regards
Pratyush
> 
> Thanks.
> 
> -- 
> tejun

WARNING: multiple messages have this Message-ID (diff)
From: pratyush.anand@st.com (Pratyush Anand)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 3/8] ahci: Add a driver_data field to struct ahci_platform_data
Date: Fri, 24 Jan 2014 09:07:54 +0530	[thread overview]
Message-ID: <20140124033754.GA2369@pratyush-vbox> (raw)
In-Reply-To: <20140123113644.GA28621@htj.dyndns.org>

On Thu, Jan 23, 2014 at 07:36:44PM +0800, Tejun Heo wrote:
> On Thu, Jan 23, 2014 at 04:02:43PM +0530, Mohit Kumar wrote:
> > diff --git a/include/linux/ahci_platform.h b/include/linux/ahci_platform.h
> > index 73a2500..76d35e8 100644
> > --- a/include/linux/ahci_platform.h
> > +++ b/include/linux/ahci_platform.h
> > @@ -28,6 +28,7 @@ struct ahci_platform_data {
> >  	const struct ata_port_info *ata_port_info;
> >  	unsigned int force_port_map;
> >  	unsigned int mask_port_map;
> > +	void *driver_data;
> 
> Please use private_data instead for consistency with other ata data
> structures.

Ok.. ll do that in V3.

Thanks for your review.

Regards
Pratyush
> 
> Thanks.
> 
> -- 
> tejun

  reply	other threads:[~2014-01-24  3:37 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-23 10:56 [PATCH V2 0/8] PCI: Add SPEAr13xx PCIe support Mohit Kumar
2014-01-23 10:56 ` Mohit Kumar
2014-01-23 10:32 ` [PATCH V2 1/8] SPEAr13xx: Set dt field entry <stmmac, phy-addr> for phy probe Mohit Kumar
2014-01-23 10:32   ` [PATCH V2 1/8] SPEAr13xx: Set dt field entry <stmmac,phy-addr> " Mohit Kumar
2014-01-24  5:02   ` Viresh Kumar
2014-01-24  5:02     ` Viresh Kumar
2014-01-24  6:02     ` Chen-Yu Tsai
2014-01-24  6:02       ` Chen-Yu Tsai
2014-01-24  6:51       ` Mohit KUMAR DCG
2014-01-24  6:51         ` Mohit KUMAR DCG
2014-01-23 10:32 ` [PATCH V2 2/8] SPEAr13xx: defconfig: Update Mohit Kumar
2014-01-24  5:03   ` Viresh Kumar
2014-01-23 10:32 ` [PATCH V2 3/8] ahci: Add a driver_data field to struct ahci_platform_data Mohit Kumar
2014-01-23 10:32   ` Mohit Kumar
2014-01-23 11:36   ` Tejun Heo
2014-01-23 11:36     ` Tejun Heo
2014-01-24  3:37     ` Pratyush Anand [this message]
2014-01-24  3:37       ` Pratyush Anand
2014-01-23 10:32 ` [PATCH V2 4/8] SPEAr13xx: Fixup: Move SPEAr1340 SATA platform code to system cfg driver Mohit Kumar
2014-01-23 10:32   ` Mohit Kumar
2014-01-23 12:22   ` Arnd Bergmann
2014-01-23 12:22     ` Arnd Bergmann
2014-01-24  4:29     ` Pratyush Anand
2014-01-24  4:29       ` Pratyush Anand
2014-01-24 20:53       ` Arnd Bergmann
2014-01-24 20:53         ` Arnd Bergmann
2014-01-25  5:36         ` Pratyush Anand
2014-01-25  5:36           ` Pratyush Anand
2014-01-23 10:32 ` [PATCH V2 5/8] clk: SPEAr13xx: Fix pcie clock name Mohit Kumar
2014-01-24  5:05   ` Viresh Kumar
2014-01-23 10:32 ` [PATCH V2 6/8] SPEAr13xx: Fix static mapping table Mohit Kumar
2014-01-23 12:12   ` Arnd Bergmann
2014-01-24  3:47     ` Pratyush Anand
2014-01-24  5:07   ` Viresh Kumar
2014-01-24  5:27     ` Pratyush Anand
2014-01-23 10:32 ` [PATCH V2 7/8] pcie: SPEAr13xx: Add designware pcie support Mohit Kumar
2014-01-24  8:13   ` Jingoo Han
2014-01-24  8:24     ` Pratyush Anand
2014-01-23 10:32 ` [PATCH V2 8/8] MAINTAINERS: Add ST SPEAr13xx PCIe driver maintainer Mohit Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140124033754.GA2369@pratyush-vbox \
    --to=pratyush.anand@st.com \
    --cc=Mohit.KUMAR@st.com \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=spear-devel@list.st.com \
    --cc=tj@kernel.org \
    --cc=viresh.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.