From: Mel Gorman <mgorman@suse.de>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Pavel Emelyanov <xemul@parallels.com>,
Andrew Morton <akpm@linux-foundation.org>,
gnome@rvzt.net, grawoc@darkrefraction.com,
alan@lxorguk.ukuu.org.uk, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
bugzilla-daemon@bugzilla.kernel.org
Subject: Re: [PATCH] mm: Ignore VM_SOFTDIRTY on VMA merging, v2
Date: Fri, 24 Jan 2014 10:14:16 +0000 [thread overview]
Message-ID: <20140124101416.GP4963@suse.de> (raw)
In-Reply-To: <20140123151445.GX1574@moon>
On Thu, Jan 23, 2014 at 07:14:45PM +0400, Cyrill Gorcunov wrote:
> On Thu, Jan 23, 2014 at 04:55:43PM +0400, Cyrill Gorcunov wrote:
> > On Thu, Jan 23, 2014 at 04:15:55PM +0400, Cyrill Gorcunov wrote:
> > > >
> > > > Thanks a lot, Mel! I'm testing the patch as well (manually though :).
> > > > I'll send the final fix today.
> > >
> > > The patch below should fix the problem. I would really appreaciate
> > > some additional testing.
> >
> > Forgot to refresh the patch, sorry.
> > ---
>
> I think setting up dirty bit inside vma_merge() body is a big hammer
> which should not be used, but it's up to caller of vma_merge() to figure
> out if dirty bit should be set or not if merge successed. Thus softdirty
> vma bit should be (and it already is) set at the end of mmap_region and do_brk
> routines. So patch could be simplified (below). Pavel, what do you think?
> ---
> From: Cyrill Gorcunov <gorcunov@gmail.com>
> Subject: [PATCH] mm: Ignore VM_SOFTDIRTY on VMA merging, v2
>
It passed the gimp launching test. Patch looks sane but I confess I did
not put a whole lot of thought into it because I see that Andrew is
already reviewing it so
Tested-by: Mel Gorman <mgorman@suse.de>
If this is merged then remember that it should be tagged for 3.12-stable
as 3.12.7 and 3.12.8 are affected by this bug.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Pavel Emelyanov <xemul@parallels.com>,
Andrew Morton <akpm@linux-foundation.org>,
gnome@rvzt.net, grawoc@darkrefraction.com,
alan@lxorguk.ukuu.org.uk, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
bugzilla-daemon@bugzilla.kernel.org
Subject: Re: [PATCH] mm: Ignore VM_SOFTDIRTY on VMA merging, v2
Date: Fri, 24 Jan 2014 10:14:16 +0000 [thread overview]
Message-ID: <20140124101416.GP4963@suse.de> (raw)
In-Reply-To: <20140123151445.GX1574@moon>
On Thu, Jan 23, 2014 at 07:14:45PM +0400, Cyrill Gorcunov wrote:
> On Thu, Jan 23, 2014 at 04:55:43PM +0400, Cyrill Gorcunov wrote:
> > On Thu, Jan 23, 2014 at 04:15:55PM +0400, Cyrill Gorcunov wrote:
> > > >
> > > > Thanks a lot, Mel! I'm testing the patch as well (manually though :).
> > > > I'll send the final fix today.
> > >
> > > The patch below should fix the problem. I would really appreaciate
> > > some additional testing.
> >
> > Forgot to refresh the patch, sorry.
> > ---
>
> I think setting up dirty bit inside vma_merge() body is a big hammer
> which should not be used, but it's up to caller of vma_merge() to figure
> out if dirty bit should be set or not if merge successed. Thus softdirty
> vma bit should be (and it already is) set at the end of mmap_region and do_brk
> routines. So patch could be simplified (below). Pavel, what do you think?
> ---
> From: Cyrill Gorcunov <gorcunov@gmail.com>
> Subject: [PATCH] mm: Ignore VM_SOFTDIRTY on VMA merging, v2
>
It passed the gimp launching test. Patch looks sane but I confess I did
not put a whole lot of thought into it because I see that Andrew is
already reviewing it so
Tested-by: Mel Gorman <mgorman@suse.de>
If this is merged then remember that it should be tagged for 3.12-stable
as 3.12.7 and 3.12.8 are affected by this bug.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2014-01-24 10:14 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 19:08 [Bug 67651] Bisected: Lots of fragmented mmaps cause gimp to fail in 3.12 after exceeding vm_max_map_count Mel Gorman
2014-01-22 19:08 ` Mel Gorman
2014-01-22 19:19 ` Cyrill Gorcunov
2014-01-22 19:19 ` Cyrill Gorcunov
2014-01-22 22:33 ` Cyrill Gorcunov
2014-01-22 22:33 ` Cyrill Gorcunov
2014-01-23 9:55 ` Mel Gorman
2014-01-23 9:55 ` Mel Gorman
2014-01-23 10:36 ` Cyrill Gorcunov
2014-01-23 10:36 ` Cyrill Gorcunov
2014-01-23 12:15 ` Cyrill Gorcunov
2014-01-23 12:15 ` Cyrill Gorcunov
2014-01-23 12:55 ` Cyrill Gorcunov
2014-01-23 12:55 ` Cyrill Gorcunov
2014-01-23 15:14 ` [PATCH] mm: Ignore VM_SOFTDIRTY on VMA merging, v2 Cyrill Gorcunov
2014-01-23 15:14 ` Cyrill Gorcunov
2014-01-23 18:07 ` Pavel Emelyanov
2014-01-23 18:07 ` Pavel Emelyanov
2014-01-23 21:02 ` Andrew Morton
2014-01-23 21:02 ` Andrew Morton
2014-01-23 21:45 ` Cyrill Gorcunov
2014-01-23 21:45 ` Cyrill Gorcunov
2014-01-24 10:14 ` Mel Gorman [this message]
2014-01-24 10:14 ` Mel Gorman
2014-01-24 11:56 ` Cyrill Gorcunov
2014-01-24 11:56 ` Cyrill Gorcunov
2014-01-24 13:41 ` Mel Gorman
2014-01-24 13:41 ` Mel Gorman
2014-01-24 14:23 ` Cyrill Gorcunov
2014-01-24 14:23 ` Cyrill Gorcunov
2014-01-23 10:30 ` [Bug 67651] Bisected: Lots of fragmented mmaps cause gimp to fail in 3.12 after exceeding vm_max_map_count Mel Gorman
2014-01-23 10:30 ` Mel Gorman
2022-12-07 22:00 ` Cyrill Gorcunov
2014-01-22 19:52 ` Andrew Morton
2014-01-22 19:52 ` Andrew Morton
2014-01-23 7:28 ` Mel Gorman
2014-01-23 7:28 ` Mel Gorman
2014-01-22 22:45 ` Andy Lutomirski
2014-01-22 22:45 ` Andy Lutomirski
2014-01-23 5:59 ` Cyrill Gorcunov
2014-01-23 5:59 ` Cyrill Gorcunov
2014-01-23 6:09 ` Andrew Morton
2014-01-23 6:09 ` Andrew Morton
2014-01-23 6:27 ` Cyrill Gorcunov
2014-01-23 6:27 ` Cyrill Gorcunov
2022-11-21 17:23 ` Muhammad Usama Anjum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140124101416.GP4963@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bugzilla-daemon@bugzilla.kernel.org \
--cc=gnome@rvzt.net \
--cc=gorcunov@gmail.com \
--cc=grawoc@darkrefraction.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.