From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: fix build error if DMA_CMA is enabled
Date: Fri, 24 Jan 2014 15:37:56 +0000 [thread overview]
Message-ID: <20140124153756.GH19052@arm.com> (raw)
In-Reply-To: <1390551788-6138-1-git-send-email-pankaj.dubey@samsung.com>
On Fri, Jan 24, 2014 at 08:23:08AM +0000, Pankaj Dubey wrote:
> arm64/include/asm/dma-contiguous.h is trying to include
> <asm-genric/dma-contiguous.h> which does not exist, and thus failing
> build for arm64 if we enable CONFIG_DMA_CMA. This patch fixes build
> error by removing unwanted header inclusion from arm64's dma-contiguous.h.
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> Signed-off-by: Somraj Mani <somraj.mani@samsung.com>
> ---
> arch/arm64/include/asm/dma-contiguous.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/include/asm/dma-contiguous.h b/arch/arm64/include/asm/dma-contiguous.h
> index d6aacb6..14c4c0c 100644
> --- a/arch/arm64/include/asm/dma-contiguous.h
> +++ b/arch/arm64/include/asm/dma-contiguous.h
> @@ -18,7 +18,6 @@
> #ifdef CONFIG_DMA_CMA
>
> #include <linux/types.h>
> -#include <asm-generic/dma-contiguous.h>
Thanks for this.
Laura, did you have additional patches adding
asm-generic/dma-contiguous.h?
--
Catalin
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Pankaj Dubey <pankaj.dubey@samsung.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Will Deacon <Will.Deacon@arm.com>,
"lauraa@codeaurora.org" <lauraa@codeaurora.org>,
Somraj Mani <somraj.mani@samsung.com>
Subject: Re: [PATCH] arm64: fix build error if DMA_CMA is enabled
Date: Fri, 24 Jan 2014 15:37:56 +0000 [thread overview]
Message-ID: <20140124153756.GH19052@arm.com> (raw)
In-Reply-To: <1390551788-6138-1-git-send-email-pankaj.dubey@samsung.com>
On Fri, Jan 24, 2014 at 08:23:08AM +0000, Pankaj Dubey wrote:
> arm64/include/asm/dma-contiguous.h is trying to include
> <asm-genric/dma-contiguous.h> which does not exist, and thus failing
> build for arm64 if we enable CONFIG_DMA_CMA. This patch fixes build
> error by removing unwanted header inclusion from arm64's dma-contiguous.h.
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> Signed-off-by: Somraj Mani <somraj.mani@samsung.com>
> ---
> arch/arm64/include/asm/dma-contiguous.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/include/asm/dma-contiguous.h b/arch/arm64/include/asm/dma-contiguous.h
> index d6aacb6..14c4c0c 100644
> --- a/arch/arm64/include/asm/dma-contiguous.h
> +++ b/arch/arm64/include/asm/dma-contiguous.h
> @@ -18,7 +18,6 @@
> #ifdef CONFIG_DMA_CMA
>
> #include <linux/types.h>
> -#include <asm-generic/dma-contiguous.h>
Thanks for this.
Laura, did you have additional patches adding
asm-generic/dma-contiguous.h?
--
Catalin
next prev parent reply other threads:[~2014-01-24 15:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-24 8:23 [PATCH] arm64: fix build error if DMA_CMA is enabled Pankaj Dubey
2014-01-24 8:23 ` Pankaj Dubey
2014-01-24 15:37 ` Catalin Marinas [this message]
2014-01-24 15:37 ` Catalin Marinas
2014-01-24 22:13 ` Laura Abbott
2014-01-24 22:13 ` Laura Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140124153756.GH19052@arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.