From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Fabian Frederick <fabf@skynet.be>
Cc: joern@lazybastard.org, akpm@linux-foundation.org,
rdunlap@infradead.org, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] mtd: block2mtd: char mtd major check
Date: Fri, 24 Jan 2014 19:10:11 -0300 [thread overview]
Message-ID: <20140124214836.GA14088@localhost> (raw)
In-Reply-To: <20140123204947.fc1c03dc0a1624d3347b3837@skynet.be>
On Thu, Jan 23, 2014 at 08:49:47PM +0100, Fabian Frederick wrote:
> Deny use of a char mtd device to map as a block device.
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/mtd/devices/block2mtd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/devices/block2mtd.c b/drivers/mtd/devices/block2mtd.c
> index d9fd87a..0efee5b 100644
> --- a/drivers/mtd/devices/block2mtd.c
> +++ b/drivers/mtd/devices/block2mtd.c
> @@ -244,7 +244,8 @@ static struct block2mtd_dev *add_device(char *devname, int erase_size)
> }
> dev->blkdev = bdev;
>
> - if (MAJOR(bdev->bd_dev) == MTD_BLOCK_MAJOR) {
> + if ((MAJOR(bdev->bd_dev) == MTD_BLOCK_MAJOR) ||
> + (MAJOR(bdev->bd_dev) == MTD_CHAR_MAJOR)) {
> pr_err("attempting to use an MTD device as a block device\n");
> goto devinit_err;
> }
> --
> 1.8.1.4
Now that the changes are separated on a per-patch basis they're much
much easier to review. Thanks!
Regarding this changes, it seems to me it's not needed. Are you sure
you can attach "block2mtd" to a char MTD device?
That would be odd, given this function calls blkdev_get_by_{path/dev};
which will check the device is of block type in the first place.
What's your motivation for this change?
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-mtd@lists.infradead.org, akpm@linux-foundation.org,
rdunlap@infradead.org, joern@lazybastard.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] mtd: block2mtd: char mtd major check
Date: Fri, 24 Jan 2014 19:10:11 -0300 [thread overview]
Message-ID: <20140124214836.GA14088@localhost> (raw)
In-Reply-To: <20140123204947.fc1c03dc0a1624d3347b3837@skynet.be>
On Thu, Jan 23, 2014 at 08:49:47PM +0100, Fabian Frederick wrote:
> Deny use of a char mtd device to map as a block device.
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/mtd/devices/block2mtd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/devices/block2mtd.c b/drivers/mtd/devices/block2mtd.c
> index d9fd87a..0efee5b 100644
> --- a/drivers/mtd/devices/block2mtd.c
> +++ b/drivers/mtd/devices/block2mtd.c
> @@ -244,7 +244,8 @@ static struct block2mtd_dev *add_device(char *devname, int erase_size)
> }
> dev->blkdev = bdev;
>
> - if (MAJOR(bdev->bd_dev) == MTD_BLOCK_MAJOR) {
> + if ((MAJOR(bdev->bd_dev) == MTD_BLOCK_MAJOR) ||
> + (MAJOR(bdev->bd_dev) == MTD_CHAR_MAJOR)) {
> pr_err("attempting to use an MTD device as a block device\n");
> goto devinit_err;
> }
> --
> 1.8.1.4
Now that the changes are separated on a per-patch basis they're much
much easier to review. Thanks!
Regarding this changes, it seems to me it's not needed. Are you sure
you can attach "block2mtd" to a char MTD device?
That would be odd, given this function calls blkdev_get_by_{path/dev};
which will check the device is of block type in the first place.
What's your motivation for this change?
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-01-24 22:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 19:49 [PATCH 1/4] mtd: block2mtd: char mtd major check Fabian Frederick
2014-01-24 22:10 ` Ezequiel Garcia [this message]
2014-01-24 22:10 ` Ezequiel Garcia
2014-01-25 2:53 ` Fabian Frederick
2014-01-25 2:53 ` Fabian Frederick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140124214836.GA14088@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=joern@lazybastard.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.