From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Fabian Frederick <fabf@skynet.be>
Cc: joern@lazybastard.org, akpm@linux-foundation.org,
rdunlap@infradead.org, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] mtd: block2mtd: mutex_init moved
Date: Sat, 25 Jan 2014 02:26:12 -0300 [thread overview]
Message-ID: <20140125052611.GA24609@localhost> (raw)
In-Reply-To: <20140123205456.10e45ea0baff94cf3f785a21@skynet.be>
On Thu, Jan 23, 2014 at 08:54:56PM +0100, Fabian Frederick wrote:
> mutex_init declared when mtd structure is available
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/mtd/devices/block2mtd.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mtd/devices/block2mtd.c b/drivers/mtd/devices/block2mtd.c
> index f0fd4fc..5b9b145 100644
> --- a/drivers/mtd/devices/block2mtd.c
> +++ b/drivers/mtd/devices/block2mtd.c
> @@ -254,16 +254,15 @@ static struct block2mtd_dev *add_device(char *devname, int erase_size)
> goto devinit_err1;
> }
>
> + name = kasprintf(GFP_KERNEL, "block2mtd: %s", devname);
> + if (!name)
> + goto devinit_err1;
> +
> mutex_init(&dev->write_mutex);
>
> /* Setup the MTD structure */
> /* make the name contain the block device in */
> - name = kasprintf(GFP_KERNEL, "block2mtd: %s", devname);
> - if (!name)
> - goto devinit_err2;
> -
> dev->mtd.name = name;
> -
> dev->mtd.size = dev->blkdev->bd_inode->i_size & PAGE_MASK;
> dev->mtd.erasesize = erase_size;
> dev->mtd.writesize = 1;
> --
> 1.8.1.4
Hm.. this change doesn't seem to make sense. You just moved the name
format to happen before the mutex_init. I wonder if I'm missing something.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-mtd@lists.infradead.org, akpm@linux-foundation.org,
rdunlap@infradead.org, joern@lazybastard.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] mtd: block2mtd: mutex_init moved
Date: Sat, 25 Jan 2014 02:26:12 -0300 [thread overview]
Message-ID: <20140125052611.GA24609@localhost> (raw)
In-Reply-To: <20140123205456.10e45ea0baff94cf3f785a21@skynet.be>
On Thu, Jan 23, 2014 at 08:54:56PM +0100, Fabian Frederick wrote:
> mutex_init declared when mtd structure is available
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/mtd/devices/block2mtd.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mtd/devices/block2mtd.c b/drivers/mtd/devices/block2mtd.c
> index f0fd4fc..5b9b145 100644
> --- a/drivers/mtd/devices/block2mtd.c
> +++ b/drivers/mtd/devices/block2mtd.c
> @@ -254,16 +254,15 @@ static struct block2mtd_dev *add_device(char *devname, int erase_size)
> goto devinit_err1;
> }
>
> + name = kasprintf(GFP_KERNEL, "block2mtd: %s", devname);
> + if (!name)
> + goto devinit_err1;
> +
> mutex_init(&dev->write_mutex);
>
> /* Setup the MTD structure */
> /* make the name contain the block device in */
> - name = kasprintf(GFP_KERNEL, "block2mtd: %s", devname);
> - if (!name)
> - goto devinit_err2;
> -
> dev->mtd.name = name;
> -
> dev->mtd.size = dev->blkdev->bd_inode->i_size & PAGE_MASK;
> dev->mtd.erasesize = erase_size;
> dev->mtd.writesize = 1;
> --
> 1.8.1.4
Hm.. this change doesn't seem to make sense. You just moved the name
format to happen before the mutex_init. I wonder if I'm missing something.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-01-25 5:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 19:54 [PATCH 4/4] mtd: block2mtd: mutex_init moved Fabian Frederick
2014-01-25 5:26 ` Ezequiel Garcia [this message]
2014-01-25 5:26 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140125052611.GA24609@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=joern@lazybastard.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.