From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-watchdog@vger.kernel.org, Wim Van Sebroeck <wim@iguana.be>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Fabio Estevam <festevam@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@free-electrons.com>,
Tawfik Bayouk <tawfik@marvell.com>,
Lior Amsalem <alior@marvell.com>,
Guenter Roeck <linux@roeck-us.net>,
Jason Cooper <jason@lakedaemon.net>
Subject: Re: [PATCH v4 07/18] watchdog: orion: Handle IRQ
Date: Sun, 26 Jan 2014 15:57:51 +0100 [thread overview]
Message-ID: <20140126155751.6c6ea59d@skate> (raw)
In-Reply-To: <20140126131445.GA14713@localhost>
Dear Ezequiel Garcia,
On Sun, 26 Jan 2014 10:14:46 -0300, Ezequiel Garcia wrote:
> > I don't quiite understand the first sentence of this commit log, and
> > the commit title looks wrong. Maybe a bad copy/paste or something?
> >
>
> Hm... yes it doesn't look right. It should read:
>
> "DT-enabled platforms, where the irqchip driver for the brigde interrupt
> controller is available, can handle the watchdog IRQ properly. Therefore,
> we request the interrupt and add a dummy handler that merely calls panic()".
Ok.
> I guess we can re-phrase it be a bit more readable.
>
> Why does th commit title looks wrong? By requesting the IRQ we are
> "handling it", no?
Right, but it looks "truncated". Maybe something like:
watchdog: orion: handle irq to avoid having to clear BRIDGE_CLAUSE
or something like that (adjust to the actual reality, I haven't
followed all the implications).
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 07/18] watchdog: orion: Handle IRQ
Date: Sun, 26 Jan 2014 15:57:51 +0100 [thread overview]
Message-ID: <20140126155751.6c6ea59d@skate> (raw)
In-Reply-To: <20140126131445.GA14713@localhost>
Dear Ezequiel Garcia,
On Sun, 26 Jan 2014 10:14:46 -0300, Ezequiel Garcia wrote:
> > I don't quiite understand the first sentence of this commit log, and
> > the commit title looks wrong. Maybe a bad copy/paste or something?
> >
>
> Hm... yes it doesn't look right. It should read:
>
> "DT-enabled platforms, where the irqchip driver for the brigde interrupt
> controller is available, can handle the watchdog IRQ properly. Therefore,
> we request the interrupt and add a dummy handler that merely calls panic()".
Ok.
> I guess we can re-phrase it be a bit more readable.
>
> Why does th commit title looks wrong? By requesting the IRQ we are
> "handling it", no?
Right, but it looks "truncated". Maybe something like:
watchdog: orion: handle irq to avoid having to clear BRIDGE_CLAUSE
or something like that (adjust to the actual reality, I haven't
followed all the implications).
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Ezequiel Garcia
<ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Wim Van Sebroeck <wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org>,
Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>,
Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Daniel Lezcano
<daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Gregory Clement
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Tawfik Bayouk <tawfik-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Lior Amsalem <alior-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
Subject: Re: [PATCH v4 07/18] watchdog: orion: Handle IRQ
Date: Sun, 26 Jan 2014 15:57:51 +0100 [thread overview]
Message-ID: <20140126155751.6c6ea59d@skate> (raw)
In-Reply-To: <20140126131445.GA14713@localhost>
Dear Ezequiel Garcia,
On Sun, 26 Jan 2014 10:14:46 -0300, Ezequiel Garcia wrote:
> > I don't quiite understand the first sentence of this commit log, and
> > the commit title looks wrong. Maybe a bad copy/paste or something?
> >
>
> Hm... yes it doesn't look right. It should read:
>
> "DT-enabled platforms, where the irqchip driver for the brigde interrupt
> controller is available, can handle the watchdog IRQ properly. Therefore,
> we request the interrupt and add a dummy handler that merely calls panic()".
Ok.
> I guess we can re-phrase it be a bit more readable.
>
> Why does th commit title looks wrong? By requesting the IRQ we are
> "handling it", no?
Right, but it looks "truncated". Maybe something like:
watchdog: orion: handle irq to avoid having to clear BRIDGE_CLAUSE
or something like that (adjust to the actual reality, I haven't
followed all the implications).
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-01-26 14:58 UTC|newest]
Thread overview: 126+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 23:04 [PATCH v4 00/18] Armada 370/XP watchdog support Ezequiel Garcia
2014-01-22 23:04 ` Ezequiel Garcia
2014-01-22 23:04 ` Ezequiel Garcia
2014-01-22 23:04 ` [PATCH v4 01/18] ARM: Introduce atomic MMIO modify Ezequiel Garcia
2014-01-22 23:04 ` Ezequiel Garcia
2014-01-22 23:04 ` Ezequiel Garcia
2014-01-25 20:32 ` Jason Cooper
2014-01-25 20:32 ` Jason Cooper
2014-01-25 20:32 ` Jason Cooper
2014-01-22 23:04 ` [PATCH v4 02/18] clocksource: orion: Use atomic access for shared registers Ezequiel Garcia
2014-01-22 23:04 ` Ezequiel Garcia
2014-01-22 23:04 ` Ezequiel Garcia
2014-01-22 23:05 ` [PATCH v4 03/18] watchdog: orion: Add clock error handling Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-25 18:12 ` Guenter Roeck
2014-01-25 18:12 ` Guenter Roeck
2014-01-25 18:12 ` Guenter Roeck
2014-01-22 23:05 ` [PATCH v4 04/18] watchdog: orion: Use atomic access for shared registers Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-25 18:12 ` Guenter Roeck
2014-01-25 18:12 ` Guenter Roeck
2014-01-25 18:12 ` Guenter Roeck
2014-01-22 23:05 ` [PATCH v4 05/18] watchdog: orion: Remove unused macros Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-25 18:13 ` Guenter Roeck
2014-01-25 18:13 ` Guenter Roeck
2014-01-25 18:13 ` Guenter Roeck
2014-01-22 23:05 ` [PATCH v4 06/18] watchdog: orion: Make sure the watchdog is initially stopped Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-25 18:13 ` Guenter Roeck
2014-01-25 18:13 ` Guenter Roeck
2014-01-25 18:13 ` Guenter Roeck
2014-01-22 23:05 ` [PATCH v4 07/18] watchdog: orion: Handle IRQ Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-25 18:15 ` Guenter Roeck
2014-01-25 18:15 ` Guenter Roeck
2014-01-25 18:15 ` Guenter Roeck
2014-01-26 8:04 ` Thomas Petazzoni
2014-01-26 8:04 ` Thomas Petazzoni
2014-01-26 8:04 ` Thomas Petazzoni
2014-01-26 13:14 ` Ezequiel Garcia
2014-01-26 13:14 ` Ezequiel Garcia
2014-01-26 13:14 ` Ezequiel Garcia
2014-01-26 14:57 ` Thomas Petazzoni [this message]
2014-01-26 14:57 ` Thomas Petazzoni
2014-01-26 14:57 ` Thomas Petazzoni
2014-01-22 23:05 ` [PATCH v4 08/18] watchdog: orion: Make RSTOUT register a separate resource Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-25 18:19 ` Guenter Roeck
2014-01-25 18:19 ` Guenter Roeck
2014-01-25 18:19 ` Guenter Roeck
2014-01-26 13:20 ` Ezequiel Garcia
2014-01-26 13:20 ` Ezequiel Garcia
2014-01-26 13:20 ` Ezequiel Garcia
2014-01-26 8:17 ` Thomas Petazzoni
2014-01-26 8:17 ` Thomas Petazzoni
2014-01-26 8:17 ` Thomas Petazzoni
2014-01-26 13:18 ` Ezequiel Garcia
2014-01-26 13:18 ` Ezequiel Garcia
2014-01-26 13:18 ` Ezequiel Garcia
2014-01-22 23:05 ` [PATCH v4 09/18] watchdog: orion: Remove unneeded BRIDGE_CAUSE clear Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-25 18:20 ` Guenter Roeck
2014-01-25 18:20 ` Guenter Roeck
2014-01-25 18:20 ` Guenter Roeck
2014-01-22 23:05 ` [PATCH v4 10/18] watchdog: orion: Introduce an orion_watchdog device structure Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-25 18:21 ` Guenter Roeck
2014-01-25 18:21 ` Guenter Roeck
2014-01-25 18:21 ` Guenter Roeck
2014-01-22 23:05 ` [PATCH v4 11/18] watchdog: orion: Introduce per-compatible of_device_id data Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-25 18:23 ` Guenter Roeck
2014-01-25 18:23 ` Guenter Roeck
2014-01-25 18:23 ` Guenter Roeck
2014-01-22 23:05 ` [PATCH v4 12/18] watchdog: orion: Add per-compatible clock initialization Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-25 18:24 ` Guenter Roeck
2014-01-25 18:24 ` Guenter Roeck
2014-01-25 18:24 ` Guenter Roeck
2014-01-22 23:05 ` [PATCH v4 13/18] watchdog: orion: Add per-compatible watchdog start implementation Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-25 18:24 ` Guenter Roeck
2014-01-25 18:24 ` Guenter Roeck
2014-01-25 18:24 ` Guenter Roeck
2014-01-22 23:05 ` [PATCH v4 14/18] watchdog: orion: Add support for Armada 370 and Armada XP SoC Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-25 18:25 ` Guenter Roeck
2014-01-25 18:25 ` Guenter Roeck
2014-01-25 18:25 ` Guenter Roeck
2014-01-22 23:05 ` [PATCH v4 15/18] ARM: mvebu: Enable Armada 370/XP watchdog in the devicetree Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-22 23:05 ` [PATCH v4 16/18] ARM: kirkwood: Add RSTOUT 'reg' entry to devicetree Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-22 23:05 ` [PATCH v4 17/18] watchdog: orion: Enable the build on ARCH_MVEBU Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-22 23:05 ` [PATCH v4 18/18] ARM: mvebu: Enable watchdog support in defconfig Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-22 23:05 ` Ezequiel Garcia
2014-01-23 22:40 ` [PATCH v4 00/18] Armada 370/XP watchdog support Sebastian Hesselbarth
2014-01-23 22:40 ` Sebastian Hesselbarth
2014-01-23 22:40 ` Sebastian Hesselbarth
2014-01-25 17:09 ` Ezequiel Garcia
2014-01-25 17:09 ` Ezequiel Garcia
2014-01-25 17:09 ` Ezequiel Garcia
2014-01-27 14:49 ` Ezequiel Garcia
2014-01-27 14:49 ` Ezequiel Garcia
2014-01-27 14:49 ` Ezequiel Garcia
2014-01-25 16:57 ` Ezequiel Garcia
2014-01-25 16:57 ` Ezequiel Garcia
2014-01-25 16:57 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140126155751.6c6ea59d@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=festevam@gmail.com \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tawfik@marvell.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.