From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Hugh Dickins <hughd@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: bring back /sys/kernel/mm
Date: Sun, 26 Jan 2014 23:03:31 -0500 [thread overview]
Message-ID: <20140127040330.GA17584@windriver.com> (raw)
In-Reply-To: <alpine.LSU.2.11.1401261849120.1259@eggly.anvils>
[[PATCH] mm: bring back /sys/kernel/mm] On 26/01/2014 (Sun 18:52) Hugh Dickins wrote:
> Commit da29bd36224b ("mm/mm_init.c: make creation of the mm_kobj happen
> earlier than device_initcall") changed to pure_initcall(mm_sysfs_init).
>
> That's too early: mm_sysfs_init() depends on core_initcall(ksysfs_init)
> to have made the kernel_kobj directory "kernel" in which to create "mm".
>
> Make it postcore_initcall(mm_sysfs_init). We could use core_initcall(),
> and depend upon Makefile link order kernel/ mm/ fs/ ipc/ security/ ...
> as core_initcall(debugfs_init) and core_initcall(securityfs_init) do;
> but better not.
Agreed, N+1 is better than link order. I guess it silently fails then,
with /sys/kernel/mm missing as the symptom? I'd booted i386 and ppc
and didn't spot this, unfortunately... wondering now if there was a
hint in dmesg that I simply failed to notice.
>
> Signed-off-by: Hugh Dickins <hughd@google.com>
Acked-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Thanks,
Paul.
> ---
>
> mm/mm_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- 3.13.0+/mm/mm_init.c 2014-01-23 21:51:26.004001378 -0800
> +++ linux/mm/mm_init.c 2014-01-26 18:06:40.488488209 -0800
> @@ -202,4 +202,4 @@ static int __init mm_sysfs_init(void)
>
> return 0;
> }
> -pure_initcall(mm_sysfs_init);
> +postcore_initcall(mm_sysfs_init);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Hugh Dickins <hughd@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: bring back /sys/kernel/mm
Date: Sun, 26 Jan 2014 23:03:31 -0500 [thread overview]
Message-ID: <20140127040330.GA17584@windriver.com> (raw)
In-Reply-To: <alpine.LSU.2.11.1401261849120.1259@eggly.anvils>
[[PATCH] mm: bring back /sys/kernel/mm] On 26/01/2014 (Sun 18:52) Hugh Dickins wrote:
> Commit da29bd36224b ("mm/mm_init.c: make creation of the mm_kobj happen
> earlier than device_initcall") changed to pure_initcall(mm_sysfs_init).
>
> That's too early: mm_sysfs_init() depends on core_initcall(ksysfs_init)
> to have made the kernel_kobj directory "kernel" in which to create "mm".
>
> Make it postcore_initcall(mm_sysfs_init). We could use core_initcall(),
> and depend upon Makefile link order kernel/ mm/ fs/ ipc/ security/ ...
> as core_initcall(debugfs_init) and core_initcall(securityfs_init) do;
> but better not.
Agreed, N+1 is better than link order. I guess it silently fails then,
with /sys/kernel/mm missing as the symptom? I'd booted i386 and ppc
and didn't spot this, unfortunately... wondering now if there was a
hint in dmesg that I simply failed to notice.
>
> Signed-off-by: Hugh Dickins <hughd@google.com>
Acked-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Thanks,
Paul.
> ---
>
> mm/mm_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- 3.13.0+/mm/mm_init.c 2014-01-23 21:51:26.004001378 -0800
> +++ linux/mm/mm_init.c 2014-01-26 18:06:40.488488209 -0800
> @@ -202,4 +202,4 @@ static int __init mm_sysfs_init(void)
>
> return 0;
> }
> -pure_initcall(mm_sysfs_init);
> +postcore_initcall(mm_sysfs_init);
next prev parent reply other threads:[~2014-01-27 8:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-27 2:52 [PATCH] mm: bring back /sys/kernel/mm Hugh Dickins
2014-01-27 2:52 ` Hugh Dickins
2014-01-27 4:03 ` Paul Gortmaker [this message]
2014-01-27 4:03 ` Paul Gortmaker
2014-01-27 5:02 ` Hugh Dickins
2014-01-27 5:02 ` Hugh Dickins
2014-01-27 5:29 ` Paul Gortmaker
2014-01-27 5:29 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140127040330.GA17584@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.