From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-arm-kernel@lists.infradead.org,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
Wim Van Sebroeck <wim@iguana.be>,
Gregory Clement <gregory.clement@free-electrons.com>,
Lior Amsalem <alior@marvell.com>,
Tawfik Bayouk <tawfik@marvell.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Jason Cooper <jason@lakedaemon.net>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Andrew Lunn <andrew@lunn.ch>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH v3 04/15] watchdog: orion: Handle IRQ
Date: Mon, 27 Jan 2014 03:30:41 -0300 [thread overview]
Message-ID: <20140127063040.GA17506@localhost> (raw)
In-Reply-To: <52DE84A6.6090909@roeck-us.net>
Hi Guenter,
On Tue, Jan 21, 2014 at 06:31:02AM -0800, Guenter Roeck wrote:
[..]
> > @@ -131,6 +138,19 @@ static int orion_wdt_probe(struct platform_device *pdev)
> > if (!wdt_reg)
> > return -ENOMEM;
> >
> > + irq = platform_get_irq(pdev, 0);
> > + if (irq > 0) {
>
> 0 is a valid interrupt number, and platform_get_irq returns an error code on errors.
> Should be >= 0.
>
I'm revisiting this one. I believe this is not the hardware interrupt
number, but the one mapped into virq space. So, 0 is not a valid
interrupt number.
Right?
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 04/15] watchdog: orion: Handle IRQ
Date: Mon, 27 Jan 2014 03:30:41 -0300 [thread overview]
Message-ID: <20140127063040.GA17506@localhost> (raw)
In-Reply-To: <52DE84A6.6090909@roeck-us.net>
Hi Guenter,
On Tue, Jan 21, 2014 at 06:31:02AM -0800, Guenter Roeck wrote:
[..]
> > @@ -131,6 +138,19 @@ static int orion_wdt_probe(struct platform_device *pdev)
> > if (!wdt_reg)
> > return -ENOMEM;
> >
> > + irq = platform_get_irq(pdev, 0);
> > + if (irq > 0) {
>
> 0 is a valid interrupt number, and platform_get_irq returns an error code on errors.
> Should be >= 0.
>
I'm revisiting this one. I believe this is not the hardware interrupt
number, but the one mapped into virq space. So, 0 is not a valid
interrupt number.
Right?
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Wim Van Sebroeck <wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org>,
Gregory Clement
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Lior Amsalem <alior-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Tawfik Bayouk <tawfik-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Thomas Petazzoni
<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Daniel Lezcano
<daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v3 04/15] watchdog: orion: Handle IRQ
Date: Mon, 27 Jan 2014 03:30:41 -0300 [thread overview]
Message-ID: <20140127063040.GA17506@localhost> (raw)
In-Reply-To: <52DE84A6.6090909-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
Hi Guenter,
On Tue, Jan 21, 2014 at 06:31:02AM -0800, Guenter Roeck wrote:
[..]
> > @@ -131,6 +138,19 @@ static int orion_wdt_probe(struct platform_device *pdev)
> > if (!wdt_reg)
> > return -ENOMEM;
> >
> > + irq = platform_get_irq(pdev, 0);
> > + if (irq > 0) {
>
> 0 is a valid interrupt number, and platform_get_irq returns an error code on errors.
> Should be >= 0.
>
I'm revisiting this one. I believe this is not the hardware interrupt
number, but the one mapped into virq space. So, 0 is not a valid
interrupt number.
Right?
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-01-27 6:30 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 13:25 [PATCH v3 00/15] Armada 370/XP watchdog support Ezequiel Garcia
2014-01-21 13:25 ` Ezequiel Garcia
2014-01-21 13:25 ` Ezequiel Garcia
2014-01-21 13:26 ` [PATCH v3 01/15] ARM: Introduce atomic MMIO modify Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
2014-01-21 13:26 ` [PATCH v3 02/15] clocksource: orion: Use atomic access for shared registers Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
2014-01-21 13:26 ` [PATCH v3 03/15] watchdog: " Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
2014-01-21 13:26 ` [PATCH v3 04/15] watchdog: orion: Handle IRQ Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
2014-01-21 14:31 ` Guenter Roeck
2014-01-21 14:31 ` Guenter Roeck
2014-01-21 14:31 ` Guenter Roeck
2014-01-21 14:35 ` Ezequiel Garcia
2014-01-21 14:35 ` Ezequiel Garcia
2014-01-21 14:35 ` Ezequiel Garcia
2014-01-27 6:30 ` Ezequiel Garcia [this message]
2014-01-27 6:30 ` Ezequiel Garcia
2014-01-27 6:30 ` Ezequiel Garcia
2014-01-27 6:42 ` Guenter Roeck
2014-01-27 6:42 ` Guenter Roeck
2014-01-27 6:42 ` Guenter Roeck
2014-01-27 7:18 ` Ezequiel Garcia
2014-01-27 7:18 ` Ezequiel Garcia
2014-01-27 7:18 ` Ezequiel Garcia
2014-01-21 13:26 ` [PATCH v3 05/15] watchdog: orion: Make RSTOUT register a separate resource Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
2014-01-21 13:26 ` [PATCH v3 06/15] watchdog: orion: Remove unneeded BRIDGE_CAUSE clear Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
2014-01-21 13:26 ` [PATCH v3 07/15] watchdog: orion: Introduce an orion_watchdog device structure Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
2014-01-21 13:26 ` [PATCH v3 08/15] watchdog: orion: Introduce per-compatible of_device_id data Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
2014-01-21 16:35 ` Guenter Roeck
2014-01-21 16:35 ` Guenter Roeck
2014-01-21 16:35 ` Guenter Roeck
2014-01-22 17:06 ` Ezequiel Garcia
2014-01-22 17:06 ` Ezequiel Garcia
2014-01-22 17:06 ` Ezequiel Garcia
2014-01-21 13:26 ` [PATCH v3 09/15] watchdog: orion: Add per-compatible clock initialization Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
2014-01-21 13:26 ` [PATCH v3 10/15] watchdog: orion: Add per-compatible watchdog start implementation Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
2014-01-21 13:26 ` [PATCH v3 11/15] watchdog: orion: Add support for Armada 370 and Armada XP SoC Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
2014-01-21 16:41 ` Guenter Roeck
2014-01-21 16:41 ` Guenter Roeck
2014-01-21 16:41 ` Guenter Roeck
2014-01-21 13:26 ` [PATCH v3 12/15] ARM: mvebu: Enable Armada 370/XP watchdog in the devicetree Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
2014-01-21 13:26 ` [PATCH v3 13/15] ARM: kirkwood: Add RSTOUT 'reg' entry to devicetree Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
2014-01-21 13:26 ` [PATCH v3 14/15] watchdog: orion: Enable the build on ARCH_MVEBU Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
2014-01-21 13:26 ` [PATCH v3 15/15] ARM: mvebu: Enable watchdog support in defconfig Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
2014-01-21 13:26 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140127063040.GA17506@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tawfik@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.