All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Weijie Yang <weijie.yang@samsung.com>
Cc: hughd@google.com, 'Andrew Morton' <akpm@linux-foundation.org>,
	'Minchan Kim' <minchan@kernel.org>,
	shli@kernel.org, 'Bob Liu' <bob.liu@oracle.com>,
	weijie.yang.kh@gmail.com,
	'Seth Jennings' <sjennings@variantweb.net>,
	'Linux-MM' <linux-mm@kvack.org>,
	'linux-kernel' <linux-kernel@vger.kernel.org>,
	stable@vger.kernel.org, 'Heesub Shin' <heesub.shin@samsung.com>,
	mguzik@redhat.com
Subject: Re: [PATCH 0/8] mm/swap: fix some rare issues in swap subsystem
Date: Mon, 27 Jan 2014 05:19:50 -0800	[thread overview]
Message-ID: <20140127131950.GD16027@kroah.com> (raw)
In-Reply-To: <000501cf1b46$b899edb0$29cdc910$%yang@samsung.com>

On Mon, Jan 27, 2014 at 06:00:03PM +0800, Weijie Yang wrote:
> This patch series focus on some tiny and rare issues in swap subsystem.
> These issues happen rarely, so it is just for the correctness of the code.
> 
> It firstly add some comments to try to make swap flag/lock usage in
> swapfile.c more clear and readable,
> and fix some rare issues in swap subsystem that cause race condition among
> swapon, swapoff and frontswap_register_ops.
> and fix some not race issues.
> 
> Please see individual patch for details, any complaint and suggestion
> are welcome.
> 
> Regards
> 
> patch 1/8: add some comments for swap flag/lock usage
> 
> patch 2/8: fix race on swap_info reuse between swapoff and swapon
> 	This patch has been in akpm -mm tree, however I improve it according
> 	to Heesub Shin and Mateusz Guzik's suggestion. So, that old patch need
> 	to be dropped.
> 
> patch 3/8: prevent concurrent swapon on the same S_ISBLK blockdev
> 
> patch 4/8: fix race among frontswap_register_ops, swapoff and swapon
> 
> patch 5/8: drop useless and bug frontswap_shrink codes
> 
> patch 6/8: remove swap_lock to simplify si_swapinfo()
> 
> patch 7/8: check swapfile blocksize greater than PAGE_SIZE
> 
> patch 8/8: add missing handle on a dup-store failure
> 
>  include/linux/blkdev.h    |    4 +++-
>  include/linux/frontswap.h |    2 --
>  include/linux/swapfile.h  |    4 +---
>  mm/frontswap.c            |  127 +++++++------------------------------------------------------------------------------------------------------------------------
>  mm/page_io.c              |    2 ++
>  mm/rmap.c                 |    2 +-
>  mm/swapfile.c             |  138 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------
>  7 files changed, 112 insertions(+), 167 deletions(-)


<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

</formletter>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Weijie Yang <weijie.yang@samsung.com>
Cc: hughd@google.com, "'Andrew Morton'" <akpm@linux-foundation.org>,
	"'Minchan Kim'" <minchan@kernel.org>,
	shli@kernel.org, "'Bob Liu'" <bob.liu@oracle.com>,
	weijie.yang.kh@gmail.com,
	"'Seth Jennings'" <sjennings@variantweb.net>,
	"'Linux-MM'" <linux-mm@kvack.org>,
	"'linux-kernel'" <linux-kernel@vger.kernel.org>,
	stable@vger.kernel.org, "'Heesub Shin'" <heesub.shin@samsung.com>,
	mguzik@redhat.com
Subject: Re: [PATCH 0/8] mm/swap: fix some rare issues in swap subsystem
Date: Mon, 27 Jan 2014 05:19:50 -0800	[thread overview]
Message-ID: <20140127131950.GD16027@kroah.com> (raw)
In-Reply-To: <000501cf1b46$b899edb0$29cdc910$%yang@samsung.com>

On Mon, Jan 27, 2014 at 06:00:03PM +0800, Weijie Yang wrote:
> This patch series focus on some tiny and rare issues in swap subsystem.
> These issues happen rarely, so it is just for the correctness of the code.
> 
> It firstly add some comments to try to make swap flag/lock usage in
> swapfile.c more clear and readable,
> and fix some rare issues in swap subsystem that cause race condition among
> swapon, swapoff and frontswap_register_ops.
> and fix some not race issues.
> 
> Please see individual patch for details, any complaint and suggestion
> are welcome.
> 
> Regards
> 
> patch 1/8: add some comments for swap flag/lock usage
> 
> patch 2/8: fix race on swap_info reuse between swapoff and swapon
> 	This patch has been in akpm -mm tree, however I improve it according
> 	to Heesub Shin and Mateusz Guzik's suggestion. So, that old patch need
> 	to be dropped.
> 
> patch 3/8: prevent concurrent swapon on the same S_ISBLK blockdev
> 
> patch 4/8: fix race among frontswap_register_ops, swapoff and swapon
> 
> patch 5/8: drop useless and bug frontswap_shrink codes
> 
> patch 6/8: remove swap_lock to simplify si_swapinfo()
> 
> patch 7/8: check swapfile blocksize greater than PAGE_SIZE
> 
> patch 8/8: add missing handle on a dup-store failure
> 
>  include/linux/blkdev.h    |    4 +++-
>  include/linux/frontswap.h |    2 --
>  include/linux/swapfile.h  |    4 +---
>  mm/frontswap.c            |  127 +++++++------------------------------------------------------------------------------------------------------------------------
>  mm/page_io.c              |    2 ++
>  mm/rmap.c                 |    2 +-
>  mm/swapfile.c             |  138 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------
>  7 files changed, 112 insertions(+), 167 deletions(-)


<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

</formletter>

  reply	other threads:[~2014-01-27 13:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-27 10:00 [PATCH 0/8] mm/swap: fix some rare issues in swap subsystem Weijie Yang
2014-01-27 10:00 ` Weijie Yang
2014-01-27 13:19 ` Greg KH [this message]
2014-01-27 13:19   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140127131950.GD16027@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=bob.liu@oracle.com \
    --cc=heesub.shin@samsung.com \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mguzik@redhat.com \
    --cc=minchan@kernel.org \
    --cc=shli@kernel.org \
    --cc=sjennings@variantweb.net \
    --cc=stable@vger.kernel.org \
    --cc=weijie.yang.kh@gmail.com \
    --cc=weijie.yang@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.