From: Fengguang Wu <fengguang.wu@intel.com>
To: Dave Hansen <dave@sr71.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
cl@linux-foundation.org, penberg@kernel.org, mpm@selenic.com,
pshelar@nicira.com
Subject: Re: [PATCH] mm: slub: fix page->_count corruption (again)
Date: Wed, 29 Jan 2014 14:43:50 +0800 [thread overview]
Message-ID: <20140129064350.GA20252@localhost> (raw)
In-Reply-To: <52E842CF.7090102@sr71.net>
On Tue, Jan 28, 2014 at 03:52:47PM -0800, Dave Hansen wrote:
> On 01/28/2014 03:29 PM, Andrew Morton wrote:
> > On Tue, 28 Jan 2014 15:17:22 -0800 Dave Hansen <dave@sr71.net> wrote:
> > This code is borderline insane.
>
> No argument here.
>
> > Yes, struct page is special and it's worth spending time and doing
> > weird things to optimise it. But sheesh.
> >
> > An alternative is to make that cmpxchg quietly go away. Is it more
> > trouble than it is worth?
>
> It has measurable performance benefits, and the benefits go up as the
> cost of en/disabling interrupts goes up (like if it takes you a hypercall).
>
> Fengguang, could you run a set of tests for the top patch in this branch
> to see if we'd be giving much up by axing the code?
>
> https://github.com/hansendc/linux/tree/slub-nocmpxchg-for-Fengguang-20140128
Sure, I've queued tests for the branch. Will report back after 1-2
days.
Thanks,
Fengguang
> I was talking with one of the distros about turning it off as well.
> They mentioned that they saw a few performance regressions when it was
> turned off. I'll share details when I get them.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Fengguang Wu <fengguang.wu@intel.com>
To: Dave Hansen <dave@sr71.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
cl@linux-foundation.org, penberg@kernel.org, mpm@selenic.com,
pshelar@nicira.com
Subject: Re: [PATCH] mm: slub: fix page->_count corruption (again)
Date: Wed, 29 Jan 2014 14:43:50 +0800 [thread overview]
Message-ID: <20140129064350.GA20252@localhost> (raw)
In-Reply-To: <52E842CF.7090102@sr71.net>
On Tue, Jan 28, 2014 at 03:52:47PM -0800, Dave Hansen wrote:
> On 01/28/2014 03:29 PM, Andrew Morton wrote:
> > On Tue, 28 Jan 2014 15:17:22 -0800 Dave Hansen <dave@sr71.net> wrote:
> > This code is borderline insane.
>
> No argument here.
>
> > Yes, struct page is special and it's worth spending time and doing
> > weird things to optimise it. But sheesh.
> >
> > An alternative is to make that cmpxchg quietly go away. Is it more
> > trouble than it is worth?
>
> It has measurable performance benefits, and the benefits go up as the
> cost of en/disabling interrupts goes up (like if it takes you a hypercall).
>
> Fengguang, could you run a set of tests for the top patch in this branch
> to see if we'd be giving much up by axing the code?
>
> https://github.com/hansendc/linux/tree/slub-nocmpxchg-for-Fengguang-20140128
Sure, I've queued tests for the branch. Will report back after 1-2
days.
Thanks,
Fengguang
> I was talking with one of the distros about turning it off as well.
> They mentioned that they saw a few performance regressions when it was
> turned off. I'll share details when I get them.
next prev parent reply other threads:[~2014-01-29 6:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 23:17 [PATCH] mm: slub: fix page->_count corruption (again) Dave Hansen
2014-01-28 23:17 ` Dave Hansen
2014-01-28 23:29 ` Andrew Morton
2014-01-28 23:29 ` Andrew Morton
2014-01-28 23:52 ` Dave Hansen
2014-01-28 23:52 ` Dave Hansen
2014-01-29 6:43 ` Fengguang Wu [this message]
2014-01-29 6:43 ` Fengguang Wu
2014-01-29 8:13 ` Fengguang Wu
2014-01-29 8:13 ` Fengguang Wu
2014-01-29 8:30 ` David Rientjes
2014-01-29 8:30 ` David Rientjes
2014-02-01 12:00 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140129064350.GA20252@localhost \
--to=fengguang.wu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=dave@sr71.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.