From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: bcm2835: config.mk isn't needed
Date: Wed, 29 Jan 2014 12:32:23 -0500 [thread overview]
Message-ID: <20140129173223.GQ3277@bill-the-cat> (raw)
In-Reply-To: <52E8C84A.3010300@suse.de>
On Wed, Jan 29, 2014 at 10:22:18AM +0100, Andreas F?rber wrote:
> Hi,
>
> Am 29.01.2014 06:42, schrieb Stephen Warren:
> > The entries in config.mk were needed so that U-Boot could be built
> > with an old version of the Raspberry Pi Foundation's toolchain. Without
> > them, the build would error out with:
> >
> > ...-ld: error: .../libgcc.a(_bswapsi2.o) uses VFP register arguments,
> > u-boot does not
> >
> > However, none of the 3 toolchains in the latest version of their
> > tools.git, nor the Ubuntu/Linaro ARM compilers in at least Ubuntu Quantal
> > or Saucy, need these options set in order to compile a working U-Boot.
> > Hence, remove the options for simplicity.
> >
> > Reported-by: Tom Rini <trini@ti.com>
> > Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
> > ---
> > arch/arm/cpu/arm1176/bcm2835/config.mk | 19 -------------------
> > 1 file changed, 19 deletions(-)
> > delete mode 100644 arch/arm/cpu/arm1176/bcm2835/config.mk
>
> No objection against the patch, but why was arch/arm/config.mk using
> -msoft-float in the first place? It's been changed from hardcoded to
> $(call cc-option ...)-wrapped [1], which may explain your experimental
> results, but IIUC it will still prefer -msoft-float if the compiler
> supports it [2] rather than if the SoC needs it, right? tegra20 for
> instance does support the hard-float ABI, too.
U-Boot for ARM _is_ soft-float. There's some issue with an older RPi
foundation toolchain that causes what at first glance looks like an odd
choice of VFP using function to be used when it doesn't need to be.
That's not to say we cannot compile with an armhf-only toolchain. We
can and I do daily.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140129/0418092d/attachment.pgp>
next prev parent reply other threads:[~2014-01-29 17:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-29 5:42 [U-Boot] [PATCH] ARM: bcm2835: config.mk isn't needed Stephen Warren
2014-01-29 9:22 ` Andreas Färber
2014-01-29 17:32 ` Tom Rini [this message]
2014-01-29 18:38 ` Stephen Warren
2014-01-29 19:41 ` Andreas Färber
2014-01-29 19:47 ` Tom Rini
2014-01-30 7:03 ` Andreas Färber
2014-02-05 2:19 ` Stephen Warren
2014-02-13 14:07 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140129173223.GQ3277@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.