All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: bcm2835: config.mk isn't needed
Date: Wed, 29 Jan 2014 11:38:55 -0700	[thread overview]
Message-ID: <52E94ABF.8090906@wwwdotorg.org> (raw)
In-Reply-To: <52E8C84A.3010300@suse.de>

On 01/29/2014 02:22 AM, Andreas F?rber wrote:
> Hi,
> 
> Am 29.01.2014 06:42, schrieb Stephen Warren:
>> The entries in config.mk were needed so that U-Boot could be built
>> with an old version of the Raspberry Pi Foundation's toolchain. Without
>> them, the build would error out with:
>>
>> ...-ld: error: .../libgcc.a(_bswapsi2.o) uses VFP register arguments,
>> u-boot does not
>>
>> However, none of the 3 toolchains in the latest version of their
>> tools.git, nor the Ubuntu/Linaro ARM compilers in at least Ubuntu Quantal
>> or Saucy, need these options set in order to compile a working U-Boot.
>> Hence, remove the options for simplicity.
>>
>> Reported-by: Tom Rini <trini@ti.com>
>> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
>> ---
>>  arch/arm/cpu/arm1176/bcm2835/config.mk | 19 -------------------
>>  1 file changed, 19 deletions(-)
>>  delete mode 100644 arch/arm/cpu/arm1176/bcm2835/config.mk
> 
> No objection against the patch, but why was arch/arm/config.mk using
> -msoft-float in the first place?

It wasn't. It was filtering -msoft-float out of the compiler flags,
which then left the ABI up to the toolchain default, which was hardfp
for one of the Raspberry Pi Foundation's toolchains - the same one that
caused the error messages quoted above unless -msoft-float was removed
from the compiler options.

  parent reply	other threads:[~2014-01-29 18:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-29  5:42 [U-Boot] [PATCH] ARM: bcm2835: config.mk isn't needed Stephen Warren
2014-01-29  9:22 ` Andreas Färber
2014-01-29 17:32   ` Tom Rini
2014-01-29 18:38   ` Stephen Warren [this message]
2014-01-29 19:41     ` Andreas Färber
2014-01-29 19:47       ` Tom Rini
2014-01-30  7:03         ` Andreas Färber
2014-02-05  2:19 ` Stephen Warren
2014-02-13 14:07 ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52E94ABF.8090906@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.