All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: anthony.perard@citrix.com, stefano.stabellini@eu.citrix.com,
	Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH] libxl: add option for discard support to xl disk configuration
Date: Wed, 29 Jan 2014 19:24:42 +0100	[thread overview]
Message-ID: <20140129182442.GA12903@aepfle.de> (raw)
In-Reply-To: <20140129142357.GA27051@aepfle.de>

On Wed, Jan 29, Olaf Hering wrote:

> On Wed, Jan 29, Ian Campbell wrote:
> > On Wed, 2014-01-29 at 12:19 +0100, Olaf Hering wrote:
> > > Thats what I'm asking you. Why is readwrite set here, and later on also
> > > in the .l file? At least just setting it here did not unconditionally
> > > enable it if no discard= was specified. I have not traced the code why
> > > that happens.
> > 
> > One for Ian J I think. Perhaps it is just setting the default?
> 
> For some reason this setting is lost, at least for my discard flag.  The
> readwrite part may suffer from the same issue, otherwise access_set
> could be removed.  I will trace the code to understand how it works.

I think the failure was caused by incompatibility between libxl.so and xl
because I did just copy libs around.

Its working fine with a fresh rpm package. I will remove the discard_set
variable.


Olaf

  reply	other threads:[~2014-01-29 18:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-28 18:24 [PATCH] libxl: add option for discard support to xl disk configuration Olaf Hering
2014-01-28 18:26 ` [PATCH] qemu-upstream: add discard support for xen_disk Olaf Hering
2014-01-28 20:10   ` Stefano Stabellini
2014-01-29 10:30     ` Ian Campbell
2014-01-29 10:28 ` [PATCH] libxl: add option for discard support to xl disk configuration Ian Campbell
2014-01-29 11:19   ` Olaf Hering
2014-01-29 11:45     ` Ian Campbell
2014-01-29 14:23       ` Olaf Hering
2014-01-29 18:24         ` Olaf Hering [this message]
2014-01-30 10:56   ` Olaf Hering
2014-01-30 11:07     ` Ian Campbell
2014-01-29 15:06 ` Olaf Hering
2014-01-29 16:01   ` Ian Campbell
2014-01-29 16:07     ` Olaf Hering
2014-01-29 16:19       ` Ian Campbell
2014-01-30 11:32     ` Ian Jackson
2014-01-30 11:36       ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140129182442.GA12903@aepfle.de \
    --to=olaf@aepfle.de \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=anthony.perard@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.