All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joby Poriyath <joby.poriyath@citrix.com>
To: xen-devel@lists.xen.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH] xen/pygrub: grub2/grub.cfg from RHEL 7 has new commands in menuentry.
Date: Thu, 30 Jan 2014 11:31:40 +0000	[thread overview]
Message-ID: <20140130113126.GA3326@citrix.com> (raw)

menuentry in grub2/grub.cfg uses linux16 and initrd16 commands
instead of linux and initrd. Due to this RHEL 7 (beta) guest failed to
boot after the installation.

In addition to this, menuentry has some options as well
(--class red, --class gnu, etc).

Signed-off-by: Joby Poriyath <joby.poriyath@citrix.com>
---
 tools/pygrub/src/GrubConf.py |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/pygrub/src/GrubConf.py b/tools/pygrub/src/GrubConf.py
index cb853c9..974cded 100644
--- a/tools/pygrub/src/GrubConf.py
+++ b/tools/pygrub/src/GrubConf.py
@@ -348,7 +348,9 @@ class Grub2Image(_GrubImage):
                 
     commands = {'set:root': 'root',
                 'linux': 'kernel',
+                'linux16': 'kernel',
                 'initrd': 'initrd',
+                'initrd16': 'initrd',
                 'echo': None,
                 'insmod': None,
                 'search': None}
@@ -394,7 +396,7 @@ class Grub2ConfigFile(_GrubConfigFile):
                 continue
 
             # new image
-            title_match = re.match('^menuentry ["\'](.*)["\'] (.*){', l)
+            title_match = re.match('^menuentry ["\'](.*?)["\'] (.*){', l)
             if title_match:
                 if img is not None:
                     raise RuntimeError, "syntax error: cannot nest menuentry (%d %s)" % (len(img),img)
-- 
1.7.10.4

             reply	other threads:[~2014-01-30 11:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-30 11:31 Joby Poriyath [this message]
2014-01-30 11:45 ` [PATCH] xen/pygrub: grub2/grub.cfg from RHEL 7 has new commands in menuentry Andrew Cooper
2014-01-30 12:01   ` Joby Poriyath
2014-01-30 12:07     ` Ian Campbell
2014-01-30 13:02       ` Joby Poriyath
2014-01-30 14:06         ` Ian Campbell
2014-01-30 14:32           ` M A Young
2014-01-30 14:38             ` Ian Campbell
2014-01-30 14:43               ` M A Young
2014-01-30 14:45                 ` Ian Campbell
2014-01-30 14:55           ` Joby Poriyath
2014-01-30 15:00             ` Ian Campbell
2014-01-30 12:24     ` Igor Kozhukhov
2014-01-30 12:28       ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140130113126.GA3326@citrix.com \
    --to=joby.poriyath@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.