All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joby Poriyath <joby.poriyath@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, xen-devel@lists.xen.org
Subject: Re: [PATCH] xen/pygrub: grub2/grub.cfg from RHEL 7 has new commands in menuentry.
Date: Thu, 30 Jan 2014 14:55:47 +0000	[thread overview]
Message-ID: <20140130145547.GA5100@citrix.com> (raw)
In-Reply-To: <1391090818.29487.36.camel@kazak.uk.xensource.com>

On Thu, Jan 30, 2014 at 02:06:58PM +0000, Ian Campbell wrote:
> > > Perhaps ["\']([^"\']*)["\'] is more accurate (i.e. disallow quotes in
> > > the name itself, although you might have to split into handling " and '
> > > separately to be more correct
> 
> Any thoughts on this?

The two regexes seems to be equivalent. My only worry with '.*?' was 
compatibility with older python. Luckily, it's supported in Python 2.2 
and later.

> 
> I suppose it depends a bit on the rules for mixing quotes in grub, e.g.
> is
> 	menuentry "Ian's super cool Linux"
> 
> allowed.
> 
> On the other hand pygrub is very much best effort so as long as it works
> with the current set of inputs which we are aware of then .*? is fine.
> 

Ok.

Should I send an updated patch along with an example of RHEL 7 grub.cfg
or is this patch acceptable as it is?

Thanks,
Joby

  parent reply	other threads:[~2014-01-30 14:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-30 11:31 [PATCH] xen/pygrub: grub2/grub.cfg from RHEL 7 has new commands in menuentry Joby Poriyath
2014-01-30 11:45 ` Andrew Cooper
2014-01-30 12:01   ` Joby Poriyath
2014-01-30 12:07     ` Ian Campbell
2014-01-30 13:02       ` Joby Poriyath
2014-01-30 14:06         ` Ian Campbell
2014-01-30 14:32           ` M A Young
2014-01-30 14:38             ` Ian Campbell
2014-01-30 14:43               ` M A Young
2014-01-30 14:45                 ` Ian Campbell
2014-01-30 14:55           ` Joby Poriyath [this message]
2014-01-30 15:00             ` Ian Campbell
2014-01-30 12:24     ` Igor Kozhukhov
2014-01-30 12:28       ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140130145547.GA5100@citrix.com \
    --to=joby.poriyath@citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.