From: Peter Zijlstra <peterz@infradead.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Nicolas Pitre <nicolas.pitre@linaro.org>,
Preeti U Murthy <preeti@linux.vnet.ibm.com>,
Olof Johansson <olof@lixom.net>,
Russell King <linux@arm.linux.org.uk>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mundt <lethal@linux-sh.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/6] idle: move the cpuidle entry point to the generic idle loop
Date: Thu, 30 Jan 2014 19:06:59 +0100 [thread overview]
Message-ID: <20140130180659.GI5002@laptop.programming.kicks-ass.net> (raw)
In-Reply-To: <52EA8BD4.6020803@linaro.org>
On Thu, Jan 30, 2014 at 06:28:52PM +0100, Daniel Lezcano wrote:
> Ok, I think the mess is coming from 'default_idle' which does not re-enable
> the local_irq but used from different places like amd_e400_idle and
> apm_cpu_idle.
>
> void default_idle(void)
> {
> trace_cpu_idle_rcuidle(1, smp_processor_id());
> safe_halt();
> trace_cpu_idle_rcuidle(PWR_EVENT_EXIT, smp_processor_id());
> }
>
> Considering the system configured without cpuidle because this one *always*
> enable the local irq, we have the different cases:
>
> x86_idle = default_idle();
> ==> local_irq_enable is missing
>
safe_halt() is "sti; hlt" and so very much does the irq_enable.
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/6] idle: move the cpuidle entry point to the generic idle loop
Date: Thu, 30 Jan 2014 18:06:59 +0000 [thread overview]
Message-ID: <20140130180659.GI5002@laptop.programming.kicks-ass.net> (raw)
In-Reply-To: <52EA8BD4.6020803@linaro.org>
On Thu, Jan 30, 2014 at 06:28:52PM +0100, Daniel Lezcano wrote:
> Ok, I think the mess is coming from 'default_idle' which does not re-enable
> the local_irq but used from different places like amd_e400_idle and
> apm_cpu_idle.
>
> void default_idle(void)
> {
> trace_cpu_idle_rcuidle(1, smp_processor_id());
> safe_halt();
> trace_cpu_idle_rcuidle(PWR_EVENT_EXIT, smp_processor_id());
> }
>
> Considering the system configured without cpuidle because this one *always*
> enable the local irq, we have the different cases:
>
> x86_idle = default_idle();
> => local_irq_enable is missing
>
safe_halt() is "sti; hlt" and so very much does the irq_enable.
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Nicolas Pitre <nicolas.pitre@linaro.org>,
linaro-kernel@lists.linaro.org,
Russell King <linux@arm.linux.org.uk>,
linux-pm@vger.kernel.org, linux-sh@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org, Olof Johansson <olof@lixom.net>,
Paul Mundt <lethal@linux-sh.org>,
Preeti U Murthy <preeti@linux.vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
linuxppc-dev@lists.ozlabs.org, Ingo Molnar <mingo@redhat.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/6] idle: move the cpuidle entry point to the generic idle loop
Date: Thu, 30 Jan 2014 19:06:59 +0100 [thread overview]
Message-ID: <20140130180659.GI5002@laptop.programming.kicks-ass.net> (raw)
In-Reply-To: <52EA8BD4.6020803@linaro.org>
On Thu, Jan 30, 2014 at 06:28:52PM +0100, Daniel Lezcano wrote:
> Ok, I think the mess is coming from 'default_idle' which does not re-enable
> the local_irq but used from different places like amd_e400_idle and
> apm_cpu_idle.
>
> void default_idle(void)
> {
> trace_cpu_idle_rcuidle(1, smp_processor_id());
> safe_halt();
> trace_cpu_idle_rcuidle(PWR_EVENT_EXIT, smp_processor_id());
> }
>
> Considering the system configured without cpuidle because this one *always*
> enable the local irq, we have the different cases:
>
> x86_idle = default_idle();
> ==> local_irq_enable is missing
>
safe_halt() is "sti; hlt" and so very much does the irq_enable.
WARNING: multiple messages have this Message-ID (diff)
From: peterz@infradead.org (Peter Zijlstra)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/6] idle: move the cpuidle entry point to the generic idle loop
Date: Thu, 30 Jan 2014 19:06:59 +0100 [thread overview]
Message-ID: <20140130180659.GI5002@laptop.programming.kicks-ass.net> (raw)
In-Reply-To: <52EA8BD4.6020803@linaro.org>
On Thu, Jan 30, 2014 at 06:28:52PM +0100, Daniel Lezcano wrote:
> Ok, I think the mess is coming from 'default_idle' which does not re-enable
> the local_irq but used from different places like amd_e400_idle and
> apm_cpu_idle.
>
> void default_idle(void)
> {
> trace_cpu_idle_rcuidle(1, smp_processor_id());
> safe_halt();
> trace_cpu_idle_rcuidle(PWR_EVENT_EXIT, smp_processor_id());
> }
>
> Considering the system configured without cpuidle because this one *always*
> enable the local irq, we have the different cases:
>
> x86_idle = default_idle();
> ==> local_irq_enable is missing
>
safe_halt() is "sti; hlt" and so very much does the irq_enable.
next prev parent reply other threads:[~2014-01-30 18:06 UTC|newest]
Thread overview: 128+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-29 17:45 [PATCH v2 0/6] setting the table for integration of cpuidle with the scheduler Nicolas Pitre
2014-01-29 17:45 ` Nicolas Pitre
2014-01-29 17:45 ` Nicolas Pitre
2014-01-29 17:45 ` Nicolas Pitre
2014-01-29 17:45 ` [PATCH v2 1/6] idle: move the cpuidle entry point to the generic idle loop Nicolas Pitre
2014-01-29 17:45 ` Nicolas Pitre
2014-01-29 17:45 ` Nicolas Pitre
2014-01-29 17:45 ` Nicolas Pitre
2014-01-29 20:31 ` Nicolas Pitre
2014-01-29 20:31 ` Nicolas Pitre
2014-01-29 20:31 ` Nicolas Pitre
2014-01-29 20:31 ` Nicolas Pitre
2014-01-30 3:38 ` Preeti U Murthy
2014-01-30 3:50 ` Preeti U Murthy
2014-01-30 3:38 ` Preeti U Murthy
2014-01-30 3:38 ` Preeti U Murthy
2014-01-30 5:28 ` Nicolas Pitre
2014-01-30 5:28 ` Nicolas Pitre
2014-01-30 5:28 ` Nicolas Pitre
2014-01-30 5:28 ` Nicolas Pitre
2014-01-30 5:50 ` Preeti U Murthy
2014-01-30 5:53 ` Preeti U Murthy
2014-01-30 5:50 ` Preeti U Murthy
2014-01-30 5:50 ` Preeti U Murthy
2014-01-30 13:44 ` Daniel Lezcano
2014-01-30 13:44 ` Daniel Lezcano
2014-01-30 13:44 ` Daniel Lezcano
2014-01-30 13:44 ` Daniel Lezcano
2014-01-30 16:07 ` Nicolas Pitre
2014-01-30 16:07 ` Nicolas Pitre
2014-01-30 16:07 ` Nicolas Pitre
2014-01-30 16:07 ` Nicolas Pitre
2014-01-30 17:28 ` Daniel Lezcano
2014-01-30 17:28 ` Daniel Lezcano
2014-01-30 17:28 ` Daniel Lezcano
2014-01-30 17:28 ` Daniel Lezcano
2014-01-30 18:06 ` Peter Zijlstra [this message]
2014-01-30 18:06 ` Peter Zijlstra
2014-01-30 18:06 ` Peter Zijlstra
2014-01-30 18:06 ` Peter Zijlstra
2014-01-30 19:24 ` Nicolas Pitre
2014-01-30 19:24 ` Nicolas Pitre
2014-01-30 19:24 ` Nicolas Pitre
2014-01-30 19:24 ` Nicolas Pitre
2014-02-11 12:17 ` [tip:sched/core] sched/idle: Move " tip-bot for Nicolas Pitre
2014-01-29 17:45 ` [PATCH v2 2/6] ARM: remove redundant cpuidle_idle_call() Nicolas Pitre
2014-01-29 17:45 ` Nicolas Pitre
2014-01-29 17:45 ` Nicolas Pitre
2014-01-29 17:45 ` Nicolas Pitre
2014-01-29 17:45 ` [PATCH v2 3/6] PPC: " Nicolas Pitre
2014-01-29 17:45 ` Nicolas Pitre
2014-01-29 17:45 ` Nicolas Pitre
2014-01-29 17:45 ` Nicolas Pitre
2014-01-29 17:45 ` [PATCH v2 4/6] SH: " Nicolas Pitre
2014-01-29 17:45 ` Nicolas Pitre
2014-01-29 17:45 ` Nicolas Pitre
2014-01-29 17:45 ` Nicolas Pitre
2014-01-29 17:45 ` [PATCH v2 5/6] X86: " Nicolas Pitre
2014-01-29 17:45 ` Nicolas Pitre
2014-01-29 17:45 ` Nicolas Pitre
2014-01-29 17:45 ` Nicolas Pitre
2014-01-29 19:02 ` Olof Johansson
2014-01-29 19:02 ` Olof Johansson
2014-01-29 19:02 ` Olof Johansson
2014-01-29 19:02 ` Olof Johansson
2014-01-29 20:14 ` Nicolas Pitre
2014-01-29 20:14 ` Nicolas Pitre
2014-01-29 20:14 ` Nicolas Pitre
2014-01-29 20:14 ` Nicolas Pitre
2014-01-30 9:24 ` Peter Zijlstra
2014-01-30 9:24 ` Peter Zijlstra
2014-01-30 9:24 ` Peter Zijlstra
2014-01-30 9:24 ` Peter Zijlstra
2014-01-30 9:24 ` Peter Zijlstra
2014-01-29 17:45 ` [PATCH v2 6/6] cpu/idle.c: move to sched/idle.c Nicolas Pitre
2014-01-29 17:45 ` Nicolas Pitre
2014-01-29 17:45 ` Nicolas Pitre
2014-01-29 17:45 ` Nicolas Pitre
2014-01-30 15:25 ` Peter Zijlstra
2014-01-30 15:25 ` Peter Zijlstra
2014-01-30 15:25 ` Peter Zijlstra
2014-01-30 15:25 ` Peter Zijlstra
2014-01-30 15:25 ` Peter Zijlstra
2014-01-30 16:03 ` Nicolas Pitre
2014-01-30 16:03 ` Nicolas Pitre
2014-01-30 16:03 ` Nicolas Pitre
2014-01-30 16:03 ` Nicolas Pitre
2014-01-30 16:27 ` Peter Zijlstra
2014-01-30 16:27 ` Peter Zijlstra
2014-01-30 16:27 ` Peter Zijlstra
2014-01-30 16:27 ` Peter Zijlstra
2014-01-30 16:27 ` Peter Zijlstra
2014-01-30 16:41 ` Joe Perches
2014-01-30 16:41 ` Joe Perches
2014-01-30 16:41 ` Joe Perches
2014-01-30 16:41 ` Joe Perches
2014-01-30 16:52 ` Peter Zijlstra
2014-01-30 16:52 ` Peter Zijlstra
2014-01-30 16:52 ` Peter Zijlstra
2014-01-30 16:52 ` Peter Zijlstra
2014-01-30 16:52 ` Peter Zijlstra
2014-02-06 14:09 ` Nicolas Pitre
2014-02-06 14:09 ` Nicolas Pitre
2014-02-06 14:09 ` Nicolas Pitre
2014-02-06 14:09 ` Nicolas Pitre
2014-02-06 16:43 ` Peter Zijlstra
2014-02-06 16:43 ` Peter Zijlstra
2014-02-06 16:43 ` Peter Zijlstra
2014-02-06 16:43 ` Peter Zijlstra
2014-02-07 11:09 ` Nicolas Pitre
2014-02-07 11:09 ` Nicolas Pitre
2014-02-07 11:09 ` Nicolas Pitre
2014-02-07 11:09 ` Nicolas Pitre
2014-02-07 12:32 ` Peter Zijlstra
2014-02-07 12:32 ` Peter Zijlstra
2014-02-07 12:32 ` Peter Zijlstra
2014-02-07 12:32 ` Peter Zijlstra
2014-02-07 12:32 ` Peter Zijlstra
2014-02-11 12:18 ` [tip:sched/core] sched/idle: Move cpu/idle.c " tip-bot for Nicolas Pitre
2014-01-30 9:28 ` [PATCH v2 0/6] setting the table for integration of cpuidle with the scheduler Peter Zijlstra
2014-01-30 9:28 ` Peter Zijlstra
2014-01-30 9:28 ` Peter Zijlstra
2014-01-30 9:28 ` Peter Zijlstra
2014-01-30 9:28 ` Peter Zijlstra
2014-01-30 13:31 ` Nicolas Pitre
2014-01-30 13:31 ` Nicolas Pitre
2014-01-30 13:31 ` Nicolas Pitre
2014-01-30 13:31 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140130180659.GI5002@laptop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=benh@kernel.crashing.org \
--cc=daniel.lezcano@linaro.org \
--cc=lethal@linux-sh.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=nicolas.pitre@linaro.org \
--cc=olof@lixom.net \
--cc=preeti@linux.vnet.ibm.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.