From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Brian Austin <brian.austin@cirrus.com>
Cc: "Lior Amsalem" <alior@marvell.com>,
alsa-devel@alsa-project.org,
"Liam Girdwood" <liam.r.girdwood@linux.intel.com>,
"Mark Brown" <broonie@kernel.org>,
"Ezequiel Garcia" <ezequiel.garcia@free-electrons.com>,
"Gregory Clément" <gregory.clement@free-electrons.com>
Subject: Re: Regression caused by "ASoC: core: Rework SOC_DOUBLE_R_SX_TLV add SOC_SINGLE_SX_TLV"
Date: Thu, 30 Jan 2014 18:16:07 +0100 [thread overview]
Message-ID: <20140130181607.6a694b8f@skate> (raw)
In-Reply-To: <alpine.DEB.2.10.1401301108450.10630@heelrod.ad.cirrus.com>
Dear Brian Austin,
On Thu, 30 Jan 2014 11:13:36 -0600, Brian Austin wrote:
> > I've tried again, and I confirm the problem. When the PCM is muted, I
> > can only toggle it between the values 62 and 64. When the PCM is
> > unmuted, I can only toggle it between the values 60 and 61.
> OK, that is very odd. I will take a look when I get a chance. I have an
> L51 board, but need to do some other stuff first.
Ok, thanks!
> > The ugly attached patch fixes the problem for me (the patch is a
> > partial revert of your patch).
> >
>
> Thanks! but...
>
> SOC_DOUBLE_R_SX_TLV("Analog Playback Volume",
> CS42L51_AOUTA_VOL, CS42L51_AOUTB_VOL,
> - 0, 0x34, 0xE4, aout_tlv),
> + 8, 0xffffff19, 0x18, aout_tlv),
> SOC_DOUBLE_R_SX_TLV("ADC Mixer Volume",
>
> shifting 8 on an 8bit register?
These values are just the ones that were here before your commit
1d99f2436d0d1c7741d6dfd9d27b5376cdbbca40. I didn't invent anything,
just reverted partially your commit.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-01-30 17:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 13:48 Regression caused by "ASoC: core: Rework SOC_DOUBLE_R_SX_TLV add SOC_SINGLE_SX_TLV" Thomas Petazzoni
2014-01-30 14:59 ` Brian Austin
2014-01-30 15:05 ` Thomas Petazzoni
2014-01-30 15:23 ` Brian Austin
2014-01-30 15:37 ` Brian Austin
2014-01-30 16:56 ` Thomas Petazzoni
2014-01-30 17:13 ` Brian Austin
2014-01-30 17:16 ` Thomas Petazzoni [this message]
2014-01-30 17:23 ` Brian Austin
2014-02-10 14:22 ` Thomas Petazzoni
2014-02-14 20:17 ` Mark Brown
2014-02-17 13:14 ` Thomas Petazzoni
2014-02-17 14:59 ` Michael Trimarchi
2014-02-17 15:03 ` Michael Trimarchi
2014-02-17 15:16 ` Thomas Petazzoni
2014-03-19 15:31 ` Brian Austin
2014-03-19 16:46 ` Thomas Petazzoni
2014-03-19 16:50 ` Mark Brown
2014-03-19 17:45 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140130181607.6a694b8f@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=alior@marvell.com \
--cc=alsa-devel@alsa-project.org \
--cc=brian.austin@cirrus.com \
--cc=broonie@kernel.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=liam.r.girdwood@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.