All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Michael Trimarchi <michael@amarulasolutions.com>
Cc: "Lior Amsalem" <alior@marvell.com>,
	"Brian Austin" <brian.austin@cirrus.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"Liam Girdwood" <liam.r.girdwood@linux.intel.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Ezequiel Garcia" <ezequiel.garcia@free-electrons.com>,
	"Gregory Clément" <gregory.clement@free-electrons.com>
Subject: Re: Regression caused by "ASoC: core: Rework SOC_DOUBLE_R_SX_TLV add SOC_SINGLE_SX_TLV"
Date: Mon, 17 Feb 2014 16:16:13 +0100	[thread overview]
Message-ID: <20140217161613.3d6fe44e@skate> (raw)
In-Reply-To: <CAOf5uwncvsUmLJynYZW2kzFf7Dp728HNciLFdLRovFRC8Je35A@mail.gmail.com>

Dear Michael Trimarchi,

On Mon, 17 Feb 2014 15:59:35 +0100, Michael Trimarchi wrote:

> > Note that I haven't looked myself in details at the code of the audio
> > codec. I simply noticed there was a volume control problem and that
> > reverting Brian's patch made the volume control work again. I have not
> > investigated at all to fix the codec code, as I was suspecting that
> > Brian may have immediately an idea on what could be wrong. If he
> > doesn't have the time to look into this, I can certainly spend a bit of
> > time to investigate what's going on.
> >
> why you don't just use regmap and check what happen on registers?

I did have a look at the codec_reg debugfs file from ASoC, and the
values were indeed not correct, as far as I remember. But I don't have
the board powered up right now, so I'd need to set it up again to make
a more precise report of what's going on.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2014-02-17 15:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-30 13:48 Regression caused by "ASoC: core: Rework SOC_DOUBLE_R_SX_TLV add SOC_SINGLE_SX_TLV" Thomas Petazzoni
2014-01-30 14:59 ` Brian Austin
2014-01-30 15:05   ` Thomas Petazzoni
2014-01-30 15:23     ` Brian Austin
2014-01-30 15:37       ` Brian Austin
2014-01-30 16:56         ` Thomas Petazzoni
2014-01-30 17:13           ` Brian Austin
2014-01-30 17:16             ` Thomas Petazzoni
2014-01-30 17:23               ` Brian Austin
2014-02-10 14:22                 ` Thomas Petazzoni
2014-02-14 20:17                   ` Mark Brown
2014-02-17 13:14                     ` Thomas Petazzoni
2014-02-17 14:59                       ` Michael Trimarchi
2014-02-17 15:03                         ` Michael Trimarchi
2014-02-17 15:16                         ` Thomas Petazzoni [this message]
2014-03-19 15:31                   ` Brian Austin
2014-03-19 16:46                     ` Thomas Petazzoni
2014-03-19 16:50                       ` Mark Brown
2014-03-19 17:45                         ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140217161613.3d6fe44e@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=alior@marvell.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=brian.austin@cirrus.com \
    --cc=broonie@kernel.org \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=gregory.clement@free-electrons.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=michael@amarulasolutions.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.