From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Simon Guinot <simon.guinot@sequanux.org>
Cc: Jeff Garzik <jgarzik@redhat.com>, Tejun Heo <tj@kernel.org>,
linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Lior Amsalem <alior@marvell.com>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@free-electrons.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2 2/3] ata: sata_mv: fix disk hotplug for Armada 370/XP SoCs
Date: Fri, 31 Jan 2014 11:54:10 +0100 [thread overview]
Message-ID: <20140131115410.557cf050@skate> (raw)
In-Reply-To: <20140131104643.GC10250@kw.sim.vm.gnt>
Dear Simon Guinot,
On Fri, 31 Jan 2014 11:46:44 +0100, Simon Guinot wrote:
> > > + /*
> > > + * To allow disk hotplug on Armada 370/XP SoCs, the PHY speed must be
> > > + * updated in the LP_PHY_CTL register.
> > > + */
> > > + if (pdev->dev.of_node &&
> > > + of_device_is_compatible(pdev->dev.of_node,
> > > + "marvell,armada-370-xp-sata"))
> >
> > Testing whether pdev->dev.of_node is not NULL does not seems to be
> > useful. A quick read of of_device_is_compatible() and the function it's
> > calling seem to indicate that of_device_is_compatible will return false
> > if the passed struct device_node * is NULL.
>
> I see.
>
> It seems to me, you already have a patch ready to send. Isn't it ?
> Or do you want me to do the update ?
I see that your patches have been merged, so I will send followup fixes.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/3] ata: sata_mv: fix disk hotplug for Armada 370/XP SoCs
Date: Fri, 31 Jan 2014 11:54:10 +0100 [thread overview]
Message-ID: <20140131115410.557cf050@skate> (raw)
In-Reply-To: <20140131104643.GC10250@kw.sim.vm.gnt>
Dear Simon Guinot,
On Fri, 31 Jan 2014 11:46:44 +0100, Simon Guinot wrote:
> > > + /*
> > > + * To allow disk hotplug on Armada 370/XP SoCs, the PHY speed must be
> > > + * updated in the LP_PHY_CTL register.
> > > + */
> > > + if (pdev->dev.of_node &&
> > > + of_device_is_compatible(pdev->dev.of_node,
> > > + "marvell,armada-370-xp-sata"))
> >
> > Testing whether pdev->dev.of_node is not NULL does not seems to be
> > useful. A quick read of of_device_is_compatible() and the function it's
> > calling seem to indicate that of_device_is_compatible will return false
> > if the passed struct device_node * is NULL.
>
> I see.
>
> It seems to me, you already have a patch ready to send. Isn't it ?
> Or do you want me to do the update ?
I see that your patches have been merged, so I will send followup fixes.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-01-31 10:54 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 14:50 [PATCH v2 0/3] Fix SATA disk hotplug for Armada 370/XP SoCs Simon Guinot
2014-01-14 14:50 ` Simon Guinot
2014-01-14 14:50 ` [PATCH v2 1/3] ata: sata_mv: introduce compatible string "marvell,armada-370-xp-sata" Simon Guinot
2014-01-14 14:50 ` [PATCH v2 1/3] ata: sata_mv: introduce compatible string "marvell, armada-370-xp-sata" Simon Guinot
2014-01-14 14:59 ` [PATCH v2 1/3] ata: sata_mv: introduce compatible string "marvell,armada-370-xp-sata" Gregory CLEMENT
2014-01-14 14:59 ` [PATCH v2 1/3] ata: sata_mv: introduce compatible string "marvell, armada-370-xp-sata" Gregory CLEMENT
2014-01-14 14:50 ` [PATCH v2 2/3] ata: sata_mv: fix disk hotplug for Armada 370/XP SoCs Simon Guinot
2014-01-14 14:50 ` Simon Guinot
2014-01-26 7:32 ` Thomas Petazzoni
2014-01-26 7:32 ` Thomas Petazzoni
2014-01-31 10:46 ` Simon Guinot
2014-01-31 10:46 ` Simon Guinot
2014-01-31 10:54 ` Thomas Petazzoni [this message]
2014-01-31 10:54 ` Thomas Petazzoni
2014-01-14 14:50 ` [PATCH v2 3/3] ARM: mvebu: update the SATA compatible string for Armada 370/XP Simon Guinot
2014-01-14 14:50 ` Simon Guinot
2014-01-14 14:58 ` Gregory CLEMENT
2014-01-14 14:58 ` Gregory CLEMENT
2014-01-14 15:14 ` [PATCH v2 0/3] Fix SATA disk hotplug for Armada 370/XP SoCs Jason Cooper
2014-01-14 15:14 ` Jason Cooper
2014-01-14 15:21 ` Tejun Heo
2014-01-14 15:21 ` Tejun Heo
2014-01-14 15:22 ` Tejun Heo
2014-01-14 15:22 ` Tejun Heo
2014-01-14 15:28 ` Russell King - ARM Linux
2014-01-14 15:28 ` Russell King - ARM Linux
2014-01-14 15:48 ` Simon Guinot
2014-01-14 15:48 ` Simon Guinot
2014-01-14 15:50 ` Andrew Lunn
2014-01-14 15:50 ` Andrew Lunn
2014-01-14 15:52 ` Tejun Heo
2014-01-14 15:52 ` Tejun Heo
2014-01-14 15:59 ` Jason Cooper
2014-01-14 15:59 ` Jason Cooper
2014-01-14 16:08 ` Jason Cooper
2014-01-14 16:08 ` Jason Cooper
2014-01-14 16:20 ` Luis Henriques
2014-01-14 16:20 ` Luis Henriques
2014-01-14 23:15 ` Simon Guinot
2014-01-14 23:15 ` Simon Guinot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140131115410.557cf050@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=jgarzik@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=simon.guinot@sequanux.org \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.